From: Miroslav Rezanina Subject: Re: Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor Date: Fri, 18 Sep 2009 01:02:37 -0400 (EDT) Message-ID: <255160165.266571253250157721.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> References: <625566043.266451253249879910.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <625566043.266451253249879910.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org ----- "Jeremy Fitzhardinge" wrote: > From: "Jeremy Fitzhardinge" > To: "Miroslav Rezanina" > Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, "Konrad Rzeszutek Wilk" > Sent: Thursday, September 17, 2009 6:47:10 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: [Xen-devel] Re: [PATCH][v2.6.29][XEN] Return unused memory to hypervisor > > On 09/17/09 01:14, Miroslav Rezanina wrote: > > Hi Jeremy, > > I check your application. It won't work correctly. You are calling > return_unused_memory in xen_memory_setup that is too soon. > > When you are calling it, there is no hole in map in any case. > Calling should be in xen_post_allocator_init function (in > arch/x86/xen/mmu.c). > > > > OK. Where does the e820 map get changed in the meantime? > xen_memory_setup just set RAM map from 0 to initial nr_pages. Only one place I'm sure map is changed is parsing mem parameter. You mentioned that there can be other cases when some parts of map are removed. > J > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- Miroslav Rezanina Software Engineer - Virtualization Team - XEN kernel