Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03F9EC433EF for ; Tue, 18 Jan 2022 19:47:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D17283867; Tue, 18 Jan 2022 20:47:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RwZr6nOc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 957E08386E; Tue, 18 Jan 2022 20:47:47 +0100 (CET) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D69F383003 for ; Tue, 18 Jan 2022 20:47:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-wm1-x330.google.com with SMTP id c2so460919wml.1 for ; Tue, 18 Jan 2022 11:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=L9b2XJg19Ws6Hcpfc9QYR25HMN08DD6MNA/NLBQCjnA=; b=RwZr6nOcuiAFdlfH7gdGSoRVUo09LC9htZvRnDTIu18iNn5rXUl/ZcuNy7Mc9tyPfO xUXYgr5z1HQdfN+EjE2O+kosAhQrXSYdoQVQnAyTH7SbzICatXI5+eJhZtyBHpMSjCof 4JJIdypCokTzD9oprrdU5wULfQWuOCdj/W909X0jf+3BvRJXSX2sSmI6l744aaYovWqW SfbDlfvwDaMf3ONFFVR0J9BfUpDTrbwd9q91+hCcbER58w82uGY7SF9T9xZcEuVMT8AR LMUTs3YpusqaeFguvr1OvzFoF3j6BCO/rmIqlRoQneZjaeYtJhdI17P2+3y/oxnr8OH9 ssnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=L9b2XJg19Ws6Hcpfc9QYR25HMN08DD6MNA/NLBQCjnA=; b=FDr5znMcT5mTlLjvz83HGYi+THfBjBJYFhUCWmZhSugQM2wRNuBMCkV4nXW+ptT7ri HDndsbBAya54GE/Fqxv1VIqvMXhYrru4XqgaSDkV2GJR0cFXmfbaWUGYfrNnB3fUc/oy pwyklbrx7LRbCJ0AFSy7Bs+8S4QvQy0g+4E8MHCaDQWlNbJC0LVv8cKUyZJczozwDq1K vR1g3M8A1nQiC95u+h9J/vstCV6yFiZfwx3AAhiLSKI258bzbeOuQg2VxI1qcXdncEtK Vo30NTRCCIJBNuztNJhpcxyh6q7VdaWdSRQ7+nn2qYs3+BentHuAwYMA3m63x9tLLH8Q wSoA== X-Gm-Message-State: AOAM531J4IPcAeTpuX/ojnxIUqemuSek6AKCIZkdVzp3IrgaHDwkfZJN RQ7T6lc4wdf5dpFxbIjh7Jk= X-Google-Smtp-Source: ABdhPJzpMVTIuwv9xI7woDHR2UxkQW840Fk2xcm0zvGFMe7rHRc2uQbBhaIqRaLJyhIlhH/7G81L3w== X-Received: by 2002:a1c:a507:: with SMTP id o7mr131951wme.32.1642535264488; Tue, 18 Jan 2022 11:47:44 -0800 (PST) Received: from workstation.lan.schwierd.dedyn.io (i5E860656.versanet.de. [94.134.6.86]) by smtp.googlemail.com with ESMTPSA id o13sm10845304wrc.5.2022.01.18.11.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 11:47:43 -0800 (PST) Message-ID: <255feb439172767e21378bce8924b8f3480e3934.camel@gmail.com> Subject: Re: [PATCH v4 02/13] mips: Avoid using config_enabled() directly From: Daniel Schwierzeck To: Simon Glass , U-Boot Mailing List Cc: Tom Rini , Rasmus Villemoes Date: Tue, 18 Jan 2022 20:47:42 +0100 In-Reply-To: <20220116131907.v4.2.I27d11850b1f0208d8c61cb3257a346da036cc3ce@changeid> References: <20220116201937.1387697-1-sjg@chromium.org> <20220116131907.v4.2.I27d11850b1f0208d8c61cb3257a346da036cc3ce@changeid> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am Sonntag, dem 16.01.2022 um 13:19 -0700 schrieb Simon Glass: > Use IS_ENABLED() instead, which is the correct macro for checking a > CONFIG > option. > > Signed-off-by: Simon Glass Reviewed-by: Daniel Schwierzeck > --- > > (no changes since v1) > > arch/mips/lib/cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/lib/cache.c b/arch/mips/lib/cache.c > index 51a8f433475..ec652f0fba8 100644 > --- a/arch/mips/lib/cache.c > +++ b/arch/mips/lib/cache.c > @@ -38,7 +38,7 @@ static void probe_l2(void) > l2c = read_c0_config5() & MIPS_CONF5_L2C; > } > > - if (l2c && config_enabled(CONFIG_MIPS_CM)) { > + if (l2c && IS_ENABLED(CONFIG_MIPS_CM)) { > gd->arch.l2_line_size = mips_cm_l2_line_size(); > } else if (l2c) { > /* We don't know how to retrieve L2 config on this > system */ -- - Daniel