Message-ID: <257522ae-92d0-9b32-1e98-0941a348147b@...1227...> Date: Sun, 25 Dec 2022 01:23:06 +0100 MIME-Version: 1.0 References: <20221224194253.3202231-1-arne@...1227...> <20221224194253.3202231-10-arne@...1227...> Content-Language: en-GB From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 9/9] Ignore OVPN_DEL_PEER_REASON_USERSPACE to avoid race conditions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Gert Doering Cc: openvpn-devel@lists.sourceforge.net Am 25.12.22 um 00:13 schrieb Gert Doering: > Hi, > > On Sat, Dec 24, 2022 at 08:42:53PM +0100, Arne Schwabe wrote: >> buf_printf(&out, "%s", mroute_addr_print(&mi->real, gc)); >> + if (mi->context.c2.tls_multi) >> + { >> + buf_printf(&out, " peer-id=%d", mi->context.c2.tls_multi->peer_id); >> + } > > Do I read this right, this will add the peer-id=%d to every single > log line in p2mp mode? In DCO mode, this might be a relevant information > (... for things related to DCO), but in non-DCO mode, it's mostly > "uninteresting", no? > > I'm all for complete log information, but making the lines too long > isn't that helpful either... Yeah. This accidentially slipped into the patch set. I am sorry for including it. It was however really helpful for doing the debugging. Arne