From: "plaisthos (Code Review)" Date: Mon, 11 Dec 2023 14:42:48 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2593a1d9f7a8f102f555cdba9af7386ed134bd30-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="VfWPSTOVnWE="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --VfWPSTOVnWE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/468?usp=3Demail ) Change subject: test_user_pass: new UT for get_user_pass ...................................................................... Patch Set 3: (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/468/comment/ced071e8_e7d892e4 : PS3, Line 625: ENVIRONMENT "srcdir=3D${CMAKE_CURRENT_SOURCE= _DIR}/tests/unit_tests/openvpn") Why not use a define instead like add_compile_definition(${target} -DSRCDIR=3D"${CMAKE_CURRENT_SOURCE_DIR}"? = That seems less fragile then an environment variable. File tests/unit_tests/openvpn/test_user_pass.c: http://gerrit.openvpn.net/c/openvpn/+/468/comment/c4d4854d_87b23353 : PS3, Line 86: } I think we should be consistent here. Either do the (void) var; in all mock= ed functions or none. I would prefer not to use them if not necessary. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Gerrit-Change-Number: 468 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 11 Dec 2023 14:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --VfWPSTOVnWE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

View C= hange

2 comments:

    =
  • File CMakeLists.txt:

    • Patch Set #3, Line 625: ENVIRONMENT &q= uot;srcdir=3D${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn")

      Why not = use a define instead like

      add_compile_definition(${target} -DSRCDIR=3D"${CMAKE_CUR= RENT_SOURCE_DIR}"? That seems less fragile then an environment variabl= e.

  • File tests/uni= t_tests/openvpn/test_user_pass.c:

    • Patch Set #3, Line 86: }

      I think we should be consistent here. Either do the (void) var; = in all mocked functions or none. I would prefer not to use them if not nece= ssary.

To view, visit change 468. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I193aef06912f01426dd4ac298aa= dfab97dd75a35
Gerrit-Change-Number: 468
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 11 Dec 2023 14:42:48= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--VfWPSTOVnWE=--