Received: from [140.186.70.92] (port=41536 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJBVt-0007SB-12 for qemu-devel@nongnu.org; Mon, 31 May 2010 16:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJBVb-0002mm-BP for qemu-devel@nongnu.org; Mon, 31 May 2010 16:22:53 -0400 Received: from mail.gmx.net ([213.165.64.20]:41236) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OJBV4-0002fC-Hi for qemu-devel@nongnu.org; Mon, 31 May 2010 16:22:51 -0400 Message-ID: <25D441EFB9404F87853E4AA52144648B@FSCPC> From: "Sebastian Herbszt" References: <1275336761$1514@local> In-Reply-To: Date: Mon, 31 May 2010 22:21:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [Qemu-ahci-devel] [PATCH] ahci: drop board_ahci constants List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ahci-devel@lists.sourceforge.net, qemu-devel@nongnu.org Alexander Graf wrote: > On 31.05.2010, at 22:12, Sebastian Herbszt wrote: >> Drop not used board_ahci constants. >> >> Signed-off-by: Sebastian Herbszt >> >> diff --git a/hw/ahci.c b/hw/ahci.c >> index 3476cea..4090def 100644 >> --- a/hw/ahci.c >> +++ b/hw/ahci.c >> @@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0) >> #define RX_FIS_SDB 0x58 /* offset of SDB FIS data */ >> #define RX_FIS_UNK 0x60 /* offset of Unknown FIS data */ >> >> -#define board_ahci 0 >> -#define board_ahci_pi 1 >> -#define board_ahci_vt8251 2 >> -#define board_ahci_ign_iferr 3 >> -#define board_ahci_sb600 4 >> - > > They weren't used before? Why are they there at all then? > > Alex Copy and paste from the linux kernel (ahci.c/h)? Sebastian