Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32178C83003 for ; Tue, 13 Jun 2023 13:25:18 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QgTnT2ZWgz30P4 for ; Tue, 13 Jun 2023 23:25:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.133; helo=out30-133.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QgTnN1Zjpz2xwG for ; Tue, 13 Jun 2023 23:25:10 +1000 (AEST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vl2cNV1_1686662703; Received: from 30.221.134.22(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vl2cNV1_1686662703) by smtp.aliyun-inc.com; Tue, 13 Jun 2023 21:25:04 +0800 Message-ID: <25a8daec-e1c4-2164-c210-4ee6b9924c99@linux.alibaba.com> Date: Tue, 13 Jun 2023 21:25:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 4/5] erofs: unify inline/shared xattr iterators for listxattr/getxattr To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org References: <20230613074114.120115-1-jefflexu@linux.alibaba.com> <20230613074114.120115-5-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230613074114.120115-5-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2023/6/13 15:41, Jingbo Xu wrote: ... > + > +int erofs_getxattr(struct inode *inode, int index, > + const char *name, > + void *buffer, size_t buffer_size) I changed these line above into: int erofs_getxattr(struct inode *inode, int index, const char *name, void *buffer, size_t buffer_size) > +{ > + int ret; ... > ssize_t erofs_listxattr(struct dentry *dentry, > @@ -568,8 +523,9 @@ ssize_t erofs_listxattr(struct dentry *dentry, I also move erofs_listxattr definition into a line (since it's just 80 chars). Otherwise it looks good to me, Reviewed-by: Gao Xiang Thanks, Gao Xiang