From: "flichtenheld (Code Review)" Date: Mon, 26 Jan 2026 13:56:32 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <25f5a29febde10e94f6d900f68635bbdd0d2f6c4-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1Gsn8p3ZGBo="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: Run openvpnserv UT for MinGW builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --1Gsn8p3ZGBo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=3Demail to review the following change. Change subject: GHA: Run openvpnserv UT for MinGW builds ...................................................................... GHA: Run openvpnserv UT for MinGW builds Should have been added in commit b10ee38ccde5f155d02fcd3e8f1b1ab454826ab0. Note that test_openvpnserv.exe lives in a separate directory, so we need to make the code a bit more flexible. Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index ef9b3f5..5f5d624 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${= { matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**= /${{ matrix.build }}/test_*.exe - uses: actions/upload-artifact@...2978... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{= matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{= matrix.build }}/*.dll mingw-unittest: @@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_= parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_= parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pas= s] build: [Release, Debug] runs-on: windows-2025 @@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=3D(Get-ChildItem -Path unittests -Filter test_${{ mat= rix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b Gerrit-Change-Number: 1487 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --1Gsn8p3ZGBo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

GHA: Run openvpnserv UT for MinGW builds
Should have been added in commit
b10ee38ccde5f155d02fcd3e8f1b1ab454= 826ab0.

Note that test_openvpnserv.exe lives in a
separate direct= ory, so we need to make the
code a bit more flexible.

Change-Id: = If61a91b4580864fd22162c94467ba3dda2045b7b
Signed-off-by: Frank Lichtenhe= ld <frank@...2641...>
---
M .github/workflows/build.yaml
1 f= ile changed, 6 insertions(+), 4 deletions(-)

git=
 pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index ef9b3f5..5f5d624 100644
--- a/.github/= workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -100,13 +100,13 @@
path: |

${{ github.workspace }}/out/build/mingw/${{ matrix.= arch }}/**/${{ matrix.build }}/*.exe
${{ githu= b.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.= dll
- !${{ g= ithub.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/t= est_*.exe
+ = !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix= .build }}/test_*.exe

- uses: actio= ns/upload-artifact@...2978... # v6.0.0
with:
name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.bui= ld }}-tests
path: |
- ${{ github.workspace }}/out/build/ming= w/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe
+ ${{ github.workspace }}/out/b= uild/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe
<= span> ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }= }/${{ matrix.build }}/*.dll


mingw-unit= test:
@@ -115,7 +115,7 @@
fail-fast:= false
matrix:
arch: [x86, = x64]
- test: [ar= gv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, packet= _id, pkt, provider, ssl, tls_crypt, user_pass]
+ test: [argv, auth_token, buffer, cryptoa= pi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, provider= , ssl, tls_crypt, user_pass]
build: [Release, Debu= g]

runs-on: windows-2025
<= span>@@ -129,7 +129,9 @@
name: openvpn-mingw-${{= matrix.arch }}-${{ matrix.build }}-tests
path: = unittests
- name: Run ${{ matrix.test }} unit test
- run: ./unittest= s/test_${{ matrix.test }}.exe
+ run: |
+ $test_file=3D(Get-ChildItem -Path unittests -Filter test_${{= matrix.test }}.exe -Recurse).fullname
+ & $test_file
env:=
srcdir: "${{ github.workspace }}/tests/uni= t_tests/openvpn"


To view, visit change 1487. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467= ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --1Gsn8p3ZGBo=--