From: "d12fk (Code Review)" Date: Wed, 26 Mar 2025 03:54:10 +0000 In-Reply-To: References: Reply-To: heiko@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <25f84623bb9be5365243ea81bb8f36c13e5d06b3-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fV9IguiHUEM="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stipa , flichtenheld , plaisthos , openvpn-devel --fV9IguiHUEM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 14: (2 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/b99905f4_e88c89db : PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected= : " > At least on my machine I have 6 "real" network adapters (according to Get= -NetAdapter | Format-List N [=E2=80=A6] Hm, I do not have adapters I can reproduce this on my system. Shall we do a= joined session figuring this out, or do you have an idea already, why thes= e adapters are listed in the interfaces registry hive, but fail to produce = a LUID? http://gerrit.openvpn.net/c/openvpn/+/837/comment/44df0b7c_cc86afff : PS14, Line 2510: for (int i =3D 0; i < _countof(data); ++i) > Does it really make sense to create keys for all adapters, even if there = are no domains/servers defi [=E2=80=A6] Yeah, if no domains or nameservers are defined the adapters are not added a= s exclude data, so there will be no RoutingX NRPT rules for those. I think = that was what you were asking, right? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 14 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: stipa Gerrit-Comment-Date: Wed, 26 Mar 2025 03:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa Gerrit-MessageType: comment --fV9IguiHUEM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, stipa.

View C= hange

2 comments:

    =
  • File src/openvpnserv/interactive.c:=

    • Patch Set #14, Lin= e 2259: MsgToEv= entLog(M_SYSERR, TEXT("IsInterfaceConnected: "

      At least on my machine I have 6 "real" network adapters (acco= rding to Get-NetAdapter | Format-List N [=E2=80=A6]

      Hm, I do not have adapt= ers I can reproduce this on my system. Shall we do a joined session figurin= g this out, or do you have an idea already, why these adapters are listed i= n the interfaces registry hive, but fail to produce a LUID?

    • Patch Set #14, Line 2510: for (int i =3D 0; i < _countof(data); ++i)

      Yeah, if no domains or nameservers = are defined the adapters are not added as exclude data, so there will be no= RoutingX NRPT rules for those. I think that was what you were asking, righ= t?

To view, visit change 837. To unsubscribe, or for h= elp writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Wed, 26 Mar 2025 03:54:10= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--fV9IguiHUEM=--