From: "Koenig, Christian" Subject: Re: [PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2) Date: Thu, 12 Sep 2019 11:48:30 +0000 Message-ID: <26355f8a-d16b-e406-8cfc-b30742419121@amd.com> References: <1568202584-14471-1-git-send-email-ray.huang@amd.com> <1568202584-14471-15-git-send-email-ray.huang@amd.com> <5704cdc8-754e-538e-9547-738ef81efa7c@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <7543AE53771BB84A8B95D608D6EAC4D7-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Huang, Ray" Cc: "Deucher, Alexander" , "Tuikov, Luben" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Liu, Aaron" QW0gMTIuMDkuMTkgdW0gMTI6Mjcgc2NocmllYiBIdWFuZywgUmF5Og0KPiBPbiBXZWQsIFNlcCAx MSwgMjAxOSBhdCAwODoxMzoxOVBNICswODAwLCBLb2VuaWcsIENocmlzdGlhbiB3cm90ZToNCj4+ IEFtIDExLjA5LjE5IHVtIDEzOjUwIHNjaHJpZWIgSHVhbmcsIFJheToNCj4+PiBGcm9tOiBBbGV4 IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+DQo+Pj4NCj4+PiBJZiBvbmUgYm8g aXMgc2VjdXJlIChjcmVhdGVkIHdpdGggQU1ER1BVX0dFTV9DUkVBVEVfRU5DUllQVEVEKSwgdGhl IFRNWiBiaXRzIG9mDQo+Pj4gUFRFcyB0aGF0IGJlbG9uZ3MgdGhhdCBibyBzaG91bGQgYmUgc2V0 LiBUaGVuIHBzcCBpcyBhYmxlIHRvIHByb3RlY3QgdGhlIHBhZ2VzDQo+Pj4gb2YgdGhpcyBibyB0 byBhdm9pZCB0aGUgYWNjZXNzIGZyb20gYW4gInVudHJ1c3QiIGRvbWFpbiBzdWNoIGFzIENQVS4N Cj4+Pg0KPj4+IHYxOiBkZXNpZ24gYW5kIGRyYWZ0IHRoZSBza2VsZXRpb24gb2YgdG16IGJpdHMg c2V0dGluZyBvbiBQVEVzIChBbGV4KQ0KPj4+IHYyOiByZXR1cm4gZmFpbHVyZSBvbmNlIGNyZWF0 ZSBzZWN1cmUgYm8gb24gbm8tdG16IHBsYXRmb3JtICAoUmF5KQ0KPj4+DQo+Pj4gU2lnbmVkLW9m Zi1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPg0KPj4+IFJldmll d2VkLWJ5OiBIdWFuZyBSdWkgPHJheS5odWFuZ0BhbWQuY29tPg0KPj4+IFNpZ25lZC1vZmYtYnk6 IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+DQo+Pj4gLS0tDQo+Pj4gICAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jICAgIHwgMTIgKysrKysrKysrKystDQo+Pj4g ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5oIHwgMTAgKysrKysr KysrKw0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyAgICB8 ICA1ICsrKysrDQo+Pj4gICAgMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pDQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5j DQo+Pj4gaW5kZXggMjJlYWI3NC4uNTMzMjEwNCAxMDA2NDQNCj4+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMNCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMNCj4+PiBAQCAtMjIyLDcgKzIyMiw4IEBAIGludCBhbWRn cHVfZ2VtX2NyZWF0ZV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLA0K Pj4+ICAgIAkJICAgICAgQU1ER1BVX0dFTV9DUkVBVEVfQ1BVX0dUVF9VU1dDIHwNCj4+PiAgICAJ CSAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX1ZSQU1fQ0xFQVJFRCB8DQo+Pj4gICAgCQkgICAgICBB TURHUFVfR0VNX0NSRUFURV9WTV9BTFdBWVNfVkFMSUQgfA0KPj4+IC0JCSAgICAgIEFNREdQVV9H RU1fQ1JFQVRFX0VYUExJQ0lUX1NZTkMpKQ0KPj4+ICsJCSAgICAgIEFNREdQVV9HRU1fQ1JFQVRF X0VYUExJQ0lUX1NZTkMgfA0KPj4+ICsJCSAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX0VOQ1JZUFRF RCkpDQo+Pj4gICAgDQo+Pj4gICAgCQlyZXR1cm4gLUVJTlZBTDsNCj4+PiAgICANCj4+PiBAQCAt MjMwLDYgKzIzMSwxMSBAQCBpbnQgYW1kZ3B1X2dlbV9jcmVhdGVfaW9jdGwoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwNCj4+PiAgICAJaWYgKGFyZ3MtPmluLmRvbWFpbnMgJiB+ QU1ER1BVX0dFTV9ET01BSU5fTUFTSykNCj4+PiAgICAJCXJldHVybiAtRUlOVkFMOw0KPj4+ICAg IA0KPj4+ICsJaWYgKCFhZGV2LT50bXouZW5hYmxlZCAmJiAoZmxhZ3MgJiBBTURHUFVfR0VNX0NS RUFURV9FTkNSWVBURUQpKSB7DQo+Pj4gKwkJRFJNX0VSUk9SKCJDYW5ub3QgYWxsb2NhdGUgc2Vj dXJlIGJ1ZmZlciB3aGlsZSB0bXogaXMgZGlzYWJsZWRcbiIpOw0KPj4+ICsJCXJldHVybiAtRUlO VkFMOw0KPj4+ICsJfQ0KPj4+ICsNCj4+PiAgICAJLyogY3JlYXRlIGEgZ2VtIG9iamVjdCB0byBj b250YWluIHRoaXMgb2JqZWN0IGluICovDQo+Pj4gICAgCWlmIChhcmdzLT5pbi5kb21haW5zICYg KEFNREdQVV9HRU1fRE9NQUlOX0dEUyB8DQo+Pj4gICAgCSAgICBBTURHUFVfR0VNX0RPTUFJTl9H V1MgfCBBTURHUFVfR0VNX0RPTUFJTl9PQSkpIHsNCj4+PiBAQCAtMjUxLDYgKzI1NywxMCBAQCBp bnQgYW1kZ3B1X2dlbV9jcmVhdGVfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAq ZGF0YSwNCj4+PiAgICAJCXJlc3YgPSB2bS0+cm9vdC5iYXNlLmJvLT50Ym8ucmVzdjsNCj4+PiAg ICAJfQ0KPj4+ICAgIA0KPj4+ICsJaWYgKGZsYWdzICYgQU1ER1BVX0dFTV9DUkVBVEVfRU5DUllQ VEVEKSB7DQo+Pj4gKwkJLyogWFhYOiBwYWQgb3V0IGFsaWdubWVudCB0byBtZWV0IFRNWiByZXF1 aXJlbWVudHMgKi8NCj4+PiArCX0NCj4+PiArDQo+Pj4gICAgCXIgPSBhbWRncHVfZ2VtX29iamVj dF9jcmVhdGUoYWRldiwgc2l6ZSwgYXJncy0+aW4uYWxpZ25tZW50LA0KPj4+ICAgIAkJCQkgICAg ICh1MzIpKDB4ZmZmZmZmZmYgJiBhcmdzLT5pbi5kb21haW5zKSwNCj4+PiAgICAJCQkJICAgICBm bGFncywgdHRtX2JvX3R5cGVfZGV2aWNlLCByZXN2LCAmZ29iaik7DQo+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuaCBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuaA0KPj4+IGluZGV4IDVhM2MxNzcuLjI4NmUy ZTIgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29i amVjdC5oDQo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVj dC5oDQo+Pj4gQEAgLTIyNCw2ICsyMjQsMTYgQEAgc3RhdGljIGlubGluZSBib29sIGFtZGdwdV9i b19leHBsaWNpdF9zeW5jKHN0cnVjdCBhbWRncHVfYm8gKmJvKQ0KPj4+ICAgIAlyZXR1cm4gYm8t PmZsYWdzICYgQU1ER1BVX0dFTV9DUkVBVEVfRVhQTElDSVRfU1lOQzsNCj4+PiAgICB9DQo+Pj4g ICAgDQo+Pj4gKy8qKg0KPj4+ICsgKiBhbWRncHVfYm9fZW5jcnlwdGVkIC0gcmV0dXJuIHdoZXRo ZXIgdGhlIGJvIGlzIGVuY3J5cHRlZA0KPj4+ICsgKi8NCj4+PiArc3RhdGljIGlubGluZSBib29s IGFtZGdwdV9ib19lbmNyeXB0ZWQoc3RydWN0IGFtZGdwdV9ibyAqYm8pDQo+Pj4gK3sNCj4+PiAr CXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gYW1kZ3B1X3R0bV9hZGV2KGJvLT50Ym8uYmRl dik7DQo+Pj4gKw0KPj4+ICsJcmV0dXJuIGFkZXYtPnRtei5lbmFibGVkICYmIChiby0+ZmxhZ3Mg JiBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQpOw0KPj4gQ2hlY2tpbmcgdGhlIGFkZXYtPnRt ei5lbmFibGVkIGZsYWdzIHNob3VsZCBiZSBkcm9wcGVkIGhlcmUuDQo+Pg0KPiBUaGF0J3MgZmlu ZS4gQk8gc2hvdWxkIGJlIHZhbGlkYXRlZCB3aGlsZSBpdCBpcyBjcmVhdGVkLg0KPg0KPiBCdXQg aWYgdGhlIEJPIGlzIGNyZWF0ZWQgYnkgdm1pZCAwLCBpcyB0aGlzIGNoZWNraW5nIG5lZWRlZD8N Cj4NCj4+PiArfQ0KPj4+ICsNCj4+PiAgICBib29sIGFtZGdwdV9ib19pc19hbWRncHVfYm8oc3Ry dWN0IHR0bV9idWZmZXJfb2JqZWN0ICpibyk7DQo+Pj4gICAgdm9pZCBhbWRncHVfYm9fcGxhY2Vt ZW50X2Zyb21fZG9tYWluKHN0cnVjdCBhbWRncHVfYm8gKmFibywgdTMyIGRvbWFpbik7DQo+Pj4g ICAgDQo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90 dG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYw0KPj4+IGluZGV4 IDM2NjM2NTUuLjhmMDBiYjIgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3R0bS5jDQo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X3R0bS5jDQo+Pj4gQEAgLTE0MzQsNiArMTQzNCw4IEBAIGJvb2wgYW1kZ3B1X3R0bV90 dF9pc19yZWFkb25seShzdHJ1Y3QgdHRtX3R0ICp0dG0pDQo+Pj4gICAgdWludDY0X3QgYW1kZ3B1 X3R0bV90dF9wZGVfZmxhZ3Moc3RydWN0IHR0bV90dCAqdHRtLCBzdHJ1Y3QgdHRtX21lbV9yZWcg Km1lbSkNCj4+PiAgICB7DQo+Pj4gICAgCXVpbnQ2NF90IGZsYWdzID0gMDsNCj4+PiArCXN0cnVj dCB0dG1fYnVmZmVyX29iamVjdCAqdGJvID0gdHRtX21lbV9yZWdfdG9fYm8obWVtKTsNCj4+PiAr CXN0cnVjdCBhbWRncHVfYm8gKmFibyA9IHR0bV90b19hbWRncHVfYm8odGJvKTsNCj4+IFRoYXQn cyBhIGNsZWFyIE5BSy4gVGhlIGZ1bmN0aW9uIGlzIG5vdCBuZWNlc3NhcmlseSBjYWxsZWQgd2l0 aA0KPj4gJmJvLT5tZW0sIHdoaWNoIGlzIGFsc28gdGhlIHJlYXNvbiB3aHkgdGhpcyBmdW5jdGlv biBkb2Vzbid0IGdldHMgdGhlIEJPDQo+PiBhcyBwYXJhbWV0ZXIuDQo+Pg0KPiBEbyB5b3UgbWVh biB3ZSBjYW4gcmV2aXNlIHRoZSBiZWxvdyBmdW5jdGlvbnMgdG8gdXNlIGJvIGFzIHRoZSBwYXJh bWV0ZXINCj4gaW5zdGVhZD8NCj4NCj4gdWludDY0X3QgYW1kZ3B1X3R0bV90dF9wZGVfZmxhZ3Mo c3RydWN0IHR0bV90dCAqdHRtLCBzdHJ1Y3QgYW1kZ3B1X2JvICpibykNCj4gdWludDY0X3QgYW1k Z3B1X3R0bV90dF9wdGVfZmxhZ3Moc3RydWN0IHR0bV90dCAqdHRtLCBzdHJ1Y3QgYW1kZ3B1X2Jv ICpibykNCg0KSWYgdGhhdCBpcyBwb3NzaWJsZSB0aGVuIHRoaXMgd291bGQgaW5kZWVkIGJlIGEg c29sdXRpb24gZm9yIHRoZSBwcm9ibGVtLg0KDQpDaHJpc3RpYW4uDQoNCj4NCj4gVGhhbmtzLA0K PiBSYXkNCj4NCj4+IENocmlzdGlhbi4NCj4+DQo+Pj4gICAgDQo+Pj4gICAgCWlmIChtZW0gJiYg bWVtLT5tZW1fdHlwZSAhPSBUVE1fUExfU1lTVEVNKQ0KPj4+ICAgIAkJZmxhZ3MgfD0gQU1ER1BV X1BURV9WQUxJRDsNCj4+PiBAQCAtMTQ0NCw2ICsxNDQ2LDkgQEAgdWludDY0X3QgYW1kZ3B1X3R0 bV90dF9wZGVfZmxhZ3Moc3RydWN0IHR0bV90dCAqdHRtLCBzdHJ1Y3QgdHRtX21lbV9yZWcgKm1l bSkNCj4+PiAgICAJCWlmICh0dG0tPmNhY2hpbmdfc3RhdGUgPT0gdHRfY2FjaGVkKQ0KPj4+ICAg IAkJCWZsYWdzIHw9IEFNREdQVV9QVEVfU05PT1BFRDsNCj4+PiAgICAJfQ0KPj4+ICsJaWYgKGFt ZGdwdV9ib19lbmNyeXB0ZWQoYWJvKSkgew0KPj4+ICsJCWZsYWdzIHw9IEFNREdQVV9QVEVfVE1a Ow0KPj4+ICsJfQ0KPj4+ICAgIA0KPj4+ICAgIAlyZXR1cm4gZmxhZ3M7DQo+Pj4gICAgfQ0KDQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1h aWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=