Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C1DC433EF for ; Thu, 10 Mar 2022 19:36:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C264C83AE6; Thu, 10 Mar 2022 20:36:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FrWJ8Cwf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C82EC83AE1; Thu, 10 Mar 2022 20:36:19 +0100 (CET) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8F76A83ADD for ; Thu, 10 Mar 2022 20:36:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x631.google.com with SMTP id qt6so14336949ejb.11 for ; Thu, 10 Mar 2022 11:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=jdHOM6A8mTnn1H1TuffKqjbyUm3JbfMQa0Ylt7aDvI0=; b=FrWJ8CwflGjl413Li7sqcC+ZBVTY/qn7tBx/Hmwtiwt+NU6kaDMoxJ25BE7W+bHjZN W9gsQj+1wh8R9bjMLPx8aflsF8v0s0wPluaeL/RXOHwxQjNvHJT884Xs0UaUBePY56YQ J+wulb2tctaipnocuWtRNASr/BtnleKbITTtU+gkfNb3RRtFylch2jJaCmlYp5f0z5Zm 8Vfrqe3Q0DCidL19Wnd9/M1SEIv0Vm+SiwboNH2tPPgc69aGd8VmoTc5kYQlaSKi1QQn xgqjQPDSyx6rs6kv1A81q6OMTw8PH71a9nTUrIIZwA+8XXWj+18pOWbSLTnRikjcp44z EQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=jdHOM6A8mTnn1H1TuffKqjbyUm3JbfMQa0Ylt7aDvI0=; b=DsBIkAbQSte38AGZMblG64Aj1s2UvwM+7RtxoKqTsYbcOWdTjXnpt4yjJNveBPUHpI xbgCVcfm2BY5sk8N66EMUwSNW2dhtfmkeKerW8ffWORleoFjEmCdEOFbn4HeZ7b78aTQ hr9yAwP2G+tjvNCR6y0sGBYlJJIqaI0oxx1dux6PQrB1ZK3C+Jo69BL92dp29grhBeGY 4un3s/xg95ap/5X2ezHfz/ynkf46sSu7vpCjxP1MC0BSf5+Km0J8XQg92bzTjZ1NxV0h 4V8jhWgHGkBAdQELEFRv6jbFtzpHK2UaVMD3yzmnBGuWGt2jof8U6ZJKUZFX4O3OWVvW ACXA== X-Gm-Message-State: AOAM531h5ebkH6Y7fb7EVLl2SbRTAotLODCzCbUuf3t/wf9g6A5Qd0as cqftUsjHhz9ktcfS/NyFMA4= X-Google-Smtp-Source: ABdhPJykjP5dR5R2sVh+0SGMvIqSD7pIzBUB3MkMBjSfGgDx7WZePd3qFDlcoaOB5F+olgeyNFxuHQ== X-Received: by 2002:a17:906:7316:b0:6d7:16be:b584 with SMTP id di22-20020a170906731600b006d716beb584mr5569673ejc.759.1646940973050; Thu, 10 Mar 2022 11:36:13 -0800 (PST) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id y41-20020a50bb2c000000b0041622779c50sm2316174ede.37.2022.03.10.11.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 11:36:12 -0800 (PST) Message-ID: <263b8679-75dd-ada5-7d1f-409702320d27@gmail.com> Date: Thu, 10 Mar 2022 22:29:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Alper Nebi Yasak Subject: Re: [PATCH v2 12/25] binman: Change how faked blobs are created To: Simon Glass Cc: Ivan Mikhaylov , Tom Rini , Philippe Reynes , huang lin , Jeffy Chen , Kever Yang , U-Boot Mailing List References: <20220223230040.159317-1-sjg@chromium.org> <20220223230040.159317-13-sjg@chromium.org> <22d5d296-65b4-2a97-5879-d038d400efc5@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 06/03/2022 06:08, Simon Glass wrote: > On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote: >> On 24/02/2022 02:00, Simon Glass wrote: >>> +- Put faked files into a separate subdir and remove them on start-up, to avoid >>> + seeing them as 'real' files on a subsequent run >> >> Do we need to create actual files, or is it a convenience thing for blob >> entry types (because they already read their contents from files)? > > We need the files for mkimage. But the mkimage etype creates its own files to pass to mkimage anyway, using entry.GetData() in collect_contents_to_file() without reaching into subentries' files. More specifically, what I'm thinking of is removing check_fake_fname() entirely, instead of managing/removing the files it creates. At a cursory glance, only blob and blob-ext-list seem to use that directly.