From: David Howells In-Reply-To: <20061115155205.GA3911@infradead.org> References: <20061115155205.GA3911@infradead.org> <20061114200621.12943.18023.stgit@warthog.cambridge.redhat.com> <20061114200702.12943.39624.stgit@warthog.cambridge.redhat.com> To: Christoph Hellwig Cc: David Howells , torvalds@osdl.org, akpm@osdl.org, sds@tycho.nsa.gov, trond.myklebust@fys.uio.no, selinux@tycho.nsa.gov, linux-kernel@vger.kernel.org, aviro@redhat.com, steved@redhat.com Subject: Re: [PATCH 19/19] CacheFiles: Permit daemon to probe inuseness of a cache file Date: Wed, 15 Nov 2006 16:10:08 +0000 Message-ID: <26620.1163607008@redhat.com> Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov Christoph Hellwig wrote: > Once again a very strong NACK for anything that gets a fd argument as > text from userspace. Why? Would you rather I passed it in a struct to an ioctl? > Also a very strong NACK for use of fget/fget_light from non-core code and > exports for either of them. Why? I could possibly pass the pathname as text, except that (a) the path length may exceed PAGE_SIZE and MAXPATHLEN, and (b) doing a full path lookup() is a complete waste of time as the daemon already has the directory open on a file descriptor, and so effectively has a bookmark to the location that I can use, if I can but get hold of it. David -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.