From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Subject: Re: [PATCH 2/5] drm/bridge: add encoder support to specify bridge input format Date: Mon, 27 May 2019 17:29:33 +0200 Message-ID: <2679412.W4MLjRXsPJ@jernej-laptop> References: <20190520133753.23871-1-narmstrong@baylibre.com> <20190520133753.23871-3-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190520133753.23871-3-narmstrong@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong Cc: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, hverkuil@xs4all.nl, dri-devel@lists.freedesktop.org, heiko@sntech.de, maxime.ripard@bootlin.com, hjc@rock-chips.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi! Thanks for working on this! Dne ponedeljek, 20. maj 2019 ob 15:37:50 CEST je Neil Armstrong napisal(a): > This patch adds a new format_set() callback to the bridge ops permitting > the encoder to specify the new input format and encoding. > > This allows supporting the very specific HDMI2.0 YUV420 output mode > when the bridge cannot convert from RGB or YUV444 to YUV420. > > In this case, the encode must downsample before the bridge and must > specify the bridge the new input bus format differs. > > This will also help supporting the YUV420 mode where the bridge cannot > downsample, and also support 10bit, 12bit and 16bit output modes > when the bridge cannot convert between different bit depths. > > Signed-off-by: Neil Armstrong > --- Reviewed-by: Jernej Skrabec Best regards, Jernej