Received: from eggs.gnu.org ([2001:4830:134:3::10]:57715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwvIn-00054R-1C for qemu-devel@nongnu.org; Tue, 26 Sep 2017 15:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwvIm-0005y1-7c for qemu-devel@nongnu.org; Tue, 26 Sep 2017 15:13:52 -0400 References: <20170913160333.23622-1-eblake@redhat.com> <20170913160333.23622-6-eblake@redhat.com> From: John Snow Message-ID: <26912d14-28af-219d-3bc0-0e0c19e333a8@redhat.com> Date: Tue, 26 Sep 2017 15:13:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170913160333.23622-6-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 05/23] block: Switch bdrv_make_zero() to byte-based List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Change the internal > loop iteration of zeroing a device to track by bytes instead of > sectors (although we are still guaranteed that we iterate by steps > that are sector-aligned). > > Signed-off-by: Eric Blake > Reviewed-by: Fam Zheng Reviewed-by: John Snow