From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/3] drm/amdgpu: Add SPSC queue to scheduler. Date: Mon, 23 Oct 2017 14:38:50 +0200 Message-ID: <26bf0d27-6768-2588-a9c2-e83e348ce4b4@gmail.com> References: <1508506327-1084-1-git-send-email-Andrey.Grodzovsky@amd.com> <1508506327-1084-2-git-send-email-Andrey.Grodzovsky@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508506327-1084-2-git-send-email-Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Andrey Grodzovsky , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org QW0gMjAuMTAuMjAxNyB1bSAxNTozMiBzY2hyaWViIEFuZHJleSBHcm9kem92c2t5Ogo+IEl0IGlz IGludGVuZGVkIHRvIHNhYnN0aXR1dGUgdGhlIGJvdW5kZWQgZmlmbyB3ZSBhcmUgY3VycmVudGx5 Cj4gdXNpbmcuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkgR3JvZHpvdnNreSA8QW5kcmV5Lkdy b2R6b3Zza3lAYW1kLmNvbT4KClR3byBzdHlsZSBuaXQgcGlja3MgYmVsb3csIHdpdGggdGhvc2Ug Zml4ZWQgdGhlIHBhdGNoIGlzIFJldmlld2VkLWJ5OiAKQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0 aWFuLmtvZW5pZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvc2NoZWR1 bGVyL3Nwc2NfcXVldWUuaCB8IDEyMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAg MSBmaWxlIGNoYW5nZWQsIDEyMCBpbnNlcnRpb25zKCspCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvc3BzY19xdWV1ZS5oCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9zY2hlZHVsZXIvc3BzY19xdWV1ZS5oIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9zY2hlZHVsZXIvc3BzY19xdWV1ZS5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQK PiBpbmRleCAwMDAwMDAwLi5hMzM5NGYxCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvc2NoZWR1bGVyL3Nwc2NfcXVldWUuaAo+IEBAIC0wLDAgKzEsMTIwIEBACj4g Ky8qCj4gKyAqIENvcHlyaWdodCAyMDE3IEFkdmFuY2VkIE1pY3JvIERldmljZXMsIEluYy4KPiAr ICoKPiArICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBjaGFyZ2UsIHRv IGFueSBwZXJzb24gb2J0YWluaW5nIGEKPiArICogY29weSBvZiB0aGlzIHNvZnR3YXJlIGFuZCBh c3NvY2lhdGVkIGRvY3VtZW50YXRpb24gZmlsZXMgKHRoZSAiU29mdHdhcmUiKSwKPiArICogdG8g ZGVhbCBpbiB0aGUgU29mdHdhcmUgd2l0aG91dCByZXN0cmljdGlvbiwgaW5jbHVkaW5nIHdpdGhv dXQgbGltaXRhdGlvbgo+ICsgKiB0aGUgcmlnaHRzIHRvIHVzZSwgY29weSwgbW9kaWZ5LCBtZXJn ZSwgcHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwKPiArICogYW5kL29yIHNlbGwgY29w aWVzIG9mIHRoZSBTb2Z0d2FyZSwgYW5kIHRvIHBlcm1pdCBwZXJzb25zIHRvIHdob20gdGhlCj4g KyAqIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVjdCB0byB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnM6Cj4gKyAqCj4gKyAqIFRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNlIGFu ZCB0aGlzIHBlcm1pc3Npb24gbm90aWNlIHNoYWxsIGJlIGluY2x1ZGVkIGluCj4gKyAqIGFsbCBj b3BpZXMgb3Igc3Vic3RhbnRpYWwgcG9ydGlvbnMgb2YgdGhlIFNvZnR3YXJlLgo+ICsgKgo+ICsg KiBUSEUgU09GVFdBUkUgSVMgUFJPVklERUQgIkFTIElTIiwgV0lUSE9VVCBXQVJSQU5UWSBPRiBB TlkgS0lORCwgRVhQUkVTUyBPUgo+ICsgKiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBMSU1J VEVEIFRPIFRIRSBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSwKPiArICogRklUTkVTUyBG T1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQU5EIE5PTklORlJJTkdFTUVOVC4gIElOIE5PIEVWRU5U IFNIQUxMCj4gKyAqIFRIRSBDT1BZUklHSFQgSE9MREVSKFMpIE9SIEFVVEhPUihTKSBCRSBMSUFC TEUgRk9SIEFOWSBDTEFJTSwgREFNQUdFUyBPUgo+ICsgKiBPVEhFUiBMSUFCSUxJVFksIFdIRVRI RVIgSU4gQU4gQUNUSU9OIE9GIENPTlRSQUNULCBUT1JUIE9SIE9USEVSV0lTRSwKPiArICogQVJJ U0lORyBGUk9NLCBPVVQgT0YgT1IgSU4gQ09OTkVDVElPTiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBU SEUgVVNFIE9SCj4gKyAqIE9USEVSIERFQUxJTkdTIElOIFRIRSBTT0ZUV0FSRS4KPiArICoKPiAr ICovCj4gKwo+ICsjaWZuZGVmIEFNRF9TQ0hFRFVMRVJfU1BTQ19RVUVVRV9IXwo+ICsjZGVmaW5l IEFNRF9TQ0hFRFVMRVJfU1BTQ19RVUVVRV9IXwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2F0b21p Yy5oPgo+ICsKPiArLyoqIFNQU0MgbG9ja2xlc3MgcXVldWUgKi8KPiArCj4gK3N0cnVjdCBzcHNj X25vZGUgewo+ICsKPiArCS8qIFN0b3JlcyBzcHNjX25vZGUqICovCj4gKwlzdHJ1Y3Qgc3BzY19u b2RlICpuZXh0Owo+ICt9Owo+ICsKPiArc3RydWN0IHNwc2NfcXVldWUgewo+ICsKPiArCSBzdHJ1 Y3Qgc3BzY19ub2RlICpoZWFkOwo+ICsKPiArCS8qIGF0b21pYyBwb2ludGVyIHRvIHN0cnVjdCBz cHNjX25vZGUqICovCj4gKwlhdG9taWNfbG9uZ190IHRhaWw7Cj4gKwo+ICsJYXRvbWljX3Qgam9i X2NvdW50Owo+ICt9Owo+ICsKPiArc3RhdGljIGlubGluZSB2b2lkIHNwc2NfcXVldWVfaW5pdChz dHJ1Y3Qgc3BzY19xdWV1ZSAqcXVldWUpCj4gK3sKPiArCXF1ZXVlLT5oZWFkID0gTlVMTDsKPiAr CWF0b21pY19sb25nX3NldCgmcXVldWUtPnRhaWwsIChsb25nKSZxdWV1ZS0+aGVhZCk7Cj4gKwlh dG9taWNfc2V0KCZxdWV1ZS0+am9iX2NvdW50LCAwKTsKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSBzdHJ1Y3Qgc3BzY19ub2RlICpzcHNjX3F1ZXVlX3BlZWsoc3RydWN0IHNwc2NfcXVldWUgKnF1 ZXVlCj4gK3sKPiArCXJldHVybiBxdWV1ZS0+aGVhZDsKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSBpbnQgc3BzY19xdWV1ZV9jb3VudChzdHJ1Y3Qgc3BzY19xdWV1ZSAqcXVldWUpIHsKClRoZSAi eyIgc2hvdWxkIGJlIG9uIGEgbmV3IGxpbmUuCgo+ICsJcmV0dXJuIGF0b21pY19yZWFkKCZxdWV1 ZS0+am9iX2NvdW50KTsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSBib29sIHNwc2NfcXVldWVf cHVzaChzdHJ1Y3Qgc3BzY19xdWV1ZSAqcXVldWUsIHN0cnVjdCBzcHNjX25vZGUgKm5vZGUpCj4g K3sKPiArCXN0cnVjdCBzcHNjX25vZGUgKip0YWlsOwo+ICsKPiArCW5vZGUtPm5leHQgPSBOVUxM Owo+ICsKPiArCXByZWVtcHRfZGlzYWJsZSgpOwo+ICsKPiArCXRhaWwgPSAoc3RydWN0IHNwc2Nf bm9kZSAqKilhdG9taWNfbG9uZ194Y2hnKCZxdWV1ZS0+dGFpbCwgKGxvbmcpJm5vZGUtPm5leHQp Owo+ICsJV1JJVEVfT05DRSgqdGFpbCwgbm9kZSk7Cj4gKwlhdG9taWNfaW5jKCZxdWV1ZS0+am9i X2NvdW50KTsKPiArCj4gKwkvKgo+ICsJICogSW4gY2FzZSBvZiBmaXJzdCBlbGVtZW50IHZlcmlm eSBuZXcgbm9kZSB3aWxsIGJlIHZpc2libGUgdG8gdGhlIGNvbnN1bWVyCj4gKwkgKiB0aHJlYWQg d2hlbiB3ZSBwaW5nIHRoZSBrZXJuZWwgdGhyZWFkIHRoYXQgdGhlcmUgaXMgbmV3IHdvcmsgdG8g ZG8uCj4gKwkgKi8KPiArCXNtcF93bWIoKTsKPiArCj4gKwlwcmVlbXB0X2VuYWJsZSgpOwo+ICsK PiArCXJldHVybiB0YWlsID09ICZxdWV1ZS0+aGVhZDsKPiArfQo+ICsKPiArCj4gK3N0YXRpYyBp bmxpbmUgc3RydWN0IHNwc2Nfbm9kZSAqc3BzY19xdWV1ZV9wb3Aoc3RydWN0IHNwc2NfcXVldWUg KnF1ZXVlKQo+ICt7Cj4gKwlzdHJ1Y3Qgc3BzY19ub2RlICpuZXh0LCAqbm9kZTsKPiArCj4gKwkv KiBWZXJpZnkgcmVhZGluZyBmcm9tIG1lbW9yeSBhbmQgbm90IHRoZSBjYWNoZSAqLwo+ICsJc21w X3JtYigpOwo+ICsKPiArCW5vZGUgPSBSRUFEX09OQ0UocXVldWUtPmhlYWQpOwo+ICsKPiArCWlm ICghbm9kZSkKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwluZXh0ID0gUkVBRF9PTkNFKG5vZGUt Pm5leHQpOwo+ICsJV1JJVEVfT05DRShxdWV1ZS0+aGVhZCwgbmV4dCk7Cj4gKwo+ICsJaWYgKHVu bGlrZWx5KCFuZXh0KSkgewo+ICsJCS8qIHNsb3dwYXRoIGZvciB0aGUgbGFzdCBlbGVtZW50IGlu IHRoZSBxdWV1ZSAqLwo+ICsKPiArCQlpZiAoYXRvbWljX2xvbmdfY21weGNoZygmcXVldWUtPnRh aWwsCj4gKwkJCQkobG9uZykmbm9kZS0+bmV4dCwobG9uZykgJnF1ZXVlLT5oZWFkKSAhPSAobG9u Zykmbm9kZS0+bmV4dCkgewo+ICsJCQkvKiBVcGRhdGluZyB0YWlsIGZhaWxlZCB3YWl0IGZvciBu ZXcgbmV4dCB0byBhcHBlYXIgKi8KPiArCQkJZG8gewo+ICsJCQkJc21wX3JtYigpOwo+ICsJCQl9 d2hpbGUgKHVubGlrZWx5KCEocXVldWUtPmhlYWQgPSBSRUFEX09OQ0Uobm9kZS0+bmV4dCkpKSk7 CgpNaXNzaW5nIHNwYWNlIGJldHdlZW4gfSBhbmQgd2hpbGUuCgpSZWdhcmRzLApDaHJpc3RpYW4u Cgo+ICsJCX0KPiArCX0KPiArCj4gKwlhdG9taWNfZGVjKCZxdWV1ZS0+am9iX2NvdW50KTsKPiAr CXJldHVybiBub2RlOwo+ICt9Cj4gKwo+ICsKPiArCj4gKyNlbmRpZiAvKiBBTURfU0NIRURVTEVS X1NQU0NfUVVFVUVfSF8gKi8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK