Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:56906 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdERNnD (ORCPT ); Thu, 18 May 2017 09:43:03 -0400 From: Sahitya Tummala Subject: __list_lru_walk_one() acquiring spin lock for longer time To: linux-fsdevel@vger.kernel.org Cc: stummala@codeaurora.org Message-ID: <26f4cf76-818c-d324-ed01-12207c258d0f@codeaurora.org> Date: Thu, 18 May 2017 19:12:58 +0530 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi all, I am observing "BUG: spinlock lockup suspected" issue in the below path - [] spin_bug+0x90 [] do_raw_spin_lock+0xfc [] _raw_spin_lock+0x28 [] list_lru_add+0x28 [] dput+0x1c8 [] path_put+0x20 [] terminate_walk+0x3c [] path_lookupat+0x100 [] filename_lookup+0x6c [] user_path_at_empty+0x54 [] SyS_faccessat+0xd0 [] el0_svc_naked+0x24 This nlru->lock has been acquired by another CPU in this path - [] d_lru_shrink_move+0x34 [] dentry_lru_isolate_shrink+0x48 [] __list_lru_walk_one.isra.10+0x94 [] list_lru_walk_node+0x40 [] shrink_dcache_sb+0x60 [] do_remount_sb+0xbc [] do_emergency_remount+0xb0 [] process_one_work+0x228 [] worker_thread+0x2e0 [] kthread+0xf4 [] ret_from_fork+0x10 At the time of crash I see that __list_lru_walk_one() shows number of entries isolated as 1774475 with nr_items still pending as 130748. On my system, I see that for dentries of 100000, it takes around 75ms for __list_lru_walk_one() to complete. So for a total of 1900000 dentries as in issue scenario, it will take upto 1425ms, which explains why the spin lockup condition got hit on the other CPU. It looks like __list_lru_walk_one() is expected to take more time if there are more number of dentries present. Any suggestion on how to optimize the__list_lru_walk_one() path to avoid the above spin lockup condition? Thanks, Sahitya. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.