Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5151B2F2A for ; Mon, 26 May 2025 06:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748242580; cv=none; b=LZ2sE8g7jljYTckemZYI+oHlu8Cx5nebNxOSbtT1u7X3GrR8RXyCaVwLtiMiHr7fSb1glzQz3d8ZTE/EYGJu5AykNneR7Hy/zsez7GUFPYkMThfN1HDsTVblZ6x+edpfEfAGeInA54OzHxMAKmkGUDA1nazR8fAnhi6HWKWVA64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748242580; c=relaxed/simple; bh=PTH5QNxhKrBnm5aRUBjk8so8Y1RGPW8qVY4roUoOllw=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ngVtOPs4v+b9SxOu2NP6TKyk1YdMOJfXVWLRTha8Rfd3KO42/5mDKYrofv0iTkuIE2RidjGvRRDphq8zqsPOzku9q8TMUNKFLOZhZFfLtZ3Yhsaqv46zOKqgL4W+fcVhgRSJgAEb9GXgLNQsv4l3azbIRHejFERiArWMQ1EwvTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=c9s14lAh; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="c9s14lAh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748242574; x=1779778574; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=PTH5QNxhKrBnm5aRUBjk8so8Y1RGPW8qVY4roUoOllw=; b=c9s14lAhwV3wy03GCvGLrp+sVL98a1p73l41z6GU3CuEYSmwOQf8OchK jEbopDt40dam0E2xCNydVz6/PB7g3UZqOeYXcyaz+hR60yrTLVSNNi/pP d7g40Xb9WDpEFVC/Mli+blz2hEgr/6H7stO9hghCbuU7d1owSO+MKTRfh GJi8/sqxamkhEXP8+bUQp0PG9+ZUh/upZ9aXcbDw1/k9AiN506oVbbJJZ 6tuddx15PlK1EoxtrymioPLZWHReFc10q9+wq9qoZxV73N01B3eRHFRGM 8X7kAuR4/leYtQQ03PzgdUkDyH7Ypjc10RRV5gy/HvFPFfD5+sp9nuL7t w==; X-CSE-ConnectionGUID: 1QymjwVETHe3Z6DWn5JZKg== X-CSE-MsgGUID: hZIuBelhQ+eYt15hEdfX6w== X-IronPort-AV: E=McAfee;i="6700,10204,11444"; a="61562283" X-IronPort-AV: E=Sophos;i="6.15,315,1739865600"; d="scan'208";a="61562283" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 23:56:11 -0700 X-CSE-ConnectionGUID: XAEKBPUyQXaJzmebIjr8RA== X-CSE-MsgGUID: ZaxXIgN5TPWTWBthc+U+2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,315,1739865600"; d="scan'208";a="173148951" Received: from ipu5-build.bj.intel.com (HELO [10.238.232.136]) ([10.238.232.136]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 23:56:07 -0700 Subject: Re: [PATCH 6/8] media: staging/ipu7: add IPU7 input system device driver To: Sakari Ailus , bingbu.cao@intel.com Cc: linux-media@vger.kernel.org, stanislaw.gruszka@linux.intel.com, laurent.pinchart@ideasonboard.com, phasta@mailbox.org, helgaas@kernel.org, jerry.w.hu@intel.com, hao.yao@intel.com, tian.shu.qiu@intel.com References: <20250429032841.115107-1-bingbu.cao@intel.com> <20250429032841.115107-7-bingbu.cao@intel.com> From: Bingbu Cao Message-ID: <27231061-82f8-35c2-1f60-8b2fa1aa298c@linux.intel.com> Date: Mon, 26 May 2025 14:52:09 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sakari, Thanks for your review. On 4/29/25 4:24 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Apr 29, 2025 at 11:28:39AM +0800, bingbu.cao@intel.com wrote: >> From: Bingbu Cao >> >> The main input system driver mainly cover the basic hardware setup, v4l2 >> devices registration, firmware stream interfaces and interrupt handling. >> >> Input system CSI2 receiver is exposed as a v4l2 sub-device. Each CSI2 >> sub-device represent one single CSI2 hardware port which be linked with >> external sub-device such camera sensor by linked with ISYS CSI2's sink >> pad. The CSI2 source pad is linked to the sink pad of video capture device. >> >> Register V4L2 video device and setup the VB2 queues to support video >> capture. Video streaming callback will trigger the input system driver to >> construct a input system stream configuration for firmware based on data >> type and stream ID and then queue buffers to firmware to do capture. >> >> IPU7 CSI-2 D-PHY hardware is a Synopsys DWC MIPI CSI2 Rx IP, the driver >> program the DPHY to receive MIPI data from camera sensors. >> >> Signed-off-by: Bingbu Cao >> --- >> drivers/staging/media/ipu7/TODO | 13 + >> drivers/staging/media/ipu7/ipu7-fw-isys.c | 301 +++++ >> drivers/staging/media/ipu7/ipu7-fw-isys.h | 39 + >> .../staging/media/ipu7/ipu7-isys-csi-phy.c | 1028 ++++++++++++++ >> .../staging/media/ipu7/ipu7-isys-csi-phy.h | 16 + >> .../staging/media/ipu7/ipu7-isys-csi2-regs.h | 1197 +++++++++++++++++ >> drivers/staging/media/ipu7/ipu7-isys-csi2.c | 542 ++++++++ >> drivers/staging/media/ipu7/ipu7-isys-csi2.h | 73 + >> drivers/staging/media/ipu7/ipu7-isys-queue.c | 838 ++++++++++++ >> drivers/staging/media/ipu7/ipu7-isys-queue.h | 72 + >> drivers/staging/media/ipu7/ipu7-isys-subdev.c | 381 ++++++ >> drivers/staging/media/ipu7/ipu7-isys-subdev.h | 55 + >> drivers/staging/media/ipu7/ipu7-isys-video.c | 1127 ++++++++++++++++ >> drivers/staging/media/ipu7/ipu7-isys-video.h | 117 ++ >> drivers/staging/media/ipu7/ipu7-isys.c | 1170 ++++++++++++++++ >> drivers/staging/media/ipu7/ipu7-isys.h | 142 ++ >> 16 files changed, 7111 insertions(+) >> create mode 100644 drivers/staging/media/ipu7/TODO >> create mode 100644 drivers/staging/media/ipu7/ipu7-fw-isys.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-fw-isys.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-csi-phy.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-csi-phy.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-csi2-regs.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-csi2.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-csi2.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-queue.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-queue.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-subdev.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-subdev.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-video.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys-video.h >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys.c >> create mode 100644 drivers/staging/media/ipu7/ipu7-isys.h >> >> diff --git a/drivers/staging/media/ipu7/TODO b/drivers/staging/media/ipu7/TODO >> new file mode 100644 >> index 000000000000..fcdf95c696fb >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/TODO >> @@ -0,0 +1,12 @@ > > I'd move this change to the patch with the Makefile / Kconfig files. > >> +This is a list of things that need to be done to get this driver out of the >> +staging directory. >> + >> +- Add metadata capture support >> + The IPU7 hardware should support metadata capture, but it is not >> + fully verified with IPU7 firmware ABI so far, need to add the metadata >> + capture support. >> + >> +- Work with the common IPU ISYS module >> + Sakari commented much of the driver code is the same than the IPU6 driver. >> + IPU7 ISYS driver is expected to work with the common IPU ISYS module in future. > > The same goes for the main IPU driver, there will be a similar common > module of that comparable to the ISYS common module. > >> + >> diff --git a/drivers/staging/media/ipu7/ipu7-fw-isys.c b/drivers/staging/media/ipu7/ipu7-fw-isys.c >> new file mode 100644 >> index 000000000000..e4b9c364572b >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-fw-isys.c >> @@ -0,0 +1,301 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "abi/ipu7_fw_insys_config_abi.h" >> +#include "abi/ipu7_fw_isys_abi.h" >> + >> +#include "ipu7.h" >> +#include "ipu7-boot.h" >> +#include "ipu7-bus.h" >> +#include "ipu7-dma.h" >> +#include "ipu7-fw-isys.h" >> +#include "ipu7-isys.h" >> +#include "ipu7-platform-regs.h" >> +#include "ipu7-syscom.h" >> + >> +static const char * const send_msg_types[N_IPU_INSYS_SEND_TYPE] = { >> + "STREAM_OPEN", >> + "STREAM_START_AND_CAPTURE", >> + "STREAM_CAPTURE", >> + "STREAM_ABORT", >> + "STREAM_FLUSH", >> + "STREAM_CLOSE" >> +}; >> + >> +int ipu7_fw_isys_complex_cmd(struct ipu7_isys *isys, >> + const unsigned int stream_handle, >> + void *cpu_mapped_buf, >> + dma_addr_t dma_mapped_buf, >> + size_t size, u16 send_type) >> +{ >> + struct ipu7_syscom_context *ctx = isys->adev->syscom; >> + struct device *dev = &isys->adev->auxdev.dev; >> + struct ipu7_insys_send_queue_token *token; >> + >> + if (send_type >= N_IPU_INSYS_SEND_TYPE) >> + return -EINVAL; >> + >> + dev_dbg(dev, "send_token: %s\n", send_msg_types[send_type]); >> + >> + /* >> + * Time to flush cache in case we have some payload. Not all messages >> + * have that >> + */ >> + if (cpu_mapped_buf) >> + clflush_cache_range(cpu_mapped_buf, size); >> + >> + token = ipu7_syscom_get_token(ctx, stream_handle + >> + IPU_INSYS_INPUT_MSG_QUEUE); >> + if (!token) >> + return -EBUSY; >> + >> + token->addr = dma_mapped_buf; >> + token->buf_handle = (unsigned long)cpu_mapped_buf; >> + token->send_type = send_type; >> + token->stream_id = stream_handle; >> + token->flag = IPU_INSYS_SEND_QUEUE_TOKEN_FLAG_NONE; >> + >> + ipu7_syscom_put_token(ctx, stream_handle + IPU_INSYS_INPUT_MSG_QUEUE); >> + /* now wakeup FW */ >> + ipu_buttress_wakeup_is_uc(isys->adev->isp); >> + >> + return 0; >> +} >> + >> +int ipu7_fw_isys_simple_cmd(struct ipu7_isys *isys, >> + const unsigned int stream_handle, u16 send_type) >> +{ >> + return ipu7_fw_isys_complex_cmd(isys, stream_handle, NULL, 0, 0, >> + send_type); >> +} >> + >> +int ipu7_fw_isys_init(struct ipu7_isys *isys) >> +{ >> + struct syscom_queue_config *queue_configs; >> + struct ipu7_bus_device *adev = isys->adev; >> + struct device *dev = &adev->auxdev.dev; >> + struct ipu7_insys_config *isys_config; >> + struct ipu7_syscom_context *syscom; >> + dma_addr_t isys_config_dma_addr; >> + unsigned int i, num_queues; >> + u32 freq; >> + u8 major; >> + int ret; >> + >> + /* Allocate and init syscom context. */ >> + syscom = devm_kzalloc(dev, sizeof(struct ipu7_syscom_context), >> + GFP_KERNEL); >> + if (!syscom) >> + return -ENOMEM; >> + >> + adev->syscom = syscom; >> + syscom->num_input_queues = IPU_INSYS_MAX_INPUT_QUEUES; >> + syscom->num_output_queues = IPU_INSYS_MAX_OUTPUT_QUEUES; >> + num_queues = syscom->num_input_queues + syscom->num_output_queues; >> + queue_configs = devm_kzalloc(dev, FW_QUEUE_CONFIG_SIZE(num_queues), >> + GFP_KERNEL); >> + if (!queue_configs) { >> + ipu7_fw_isys_release(isys); >> + return -ENOMEM; >> + } >> + syscom->queue_configs = queue_configs; >> + queue_configs[IPU_INSYS_OUTPUT_MSG_QUEUE].max_capacity = >> + IPU_ISYS_SIZE_RECV_QUEUE; >> + queue_configs[IPU_INSYS_OUTPUT_MSG_QUEUE].token_size_in_bytes = >> + sizeof(struct ipu7_insys_resp); >> + queue_configs[IPU_INSYS_OUTPUT_LOG_QUEUE].max_capacity = >> + IPU_ISYS_SIZE_LOG_QUEUE; >> + queue_configs[IPU_INSYS_OUTPUT_LOG_QUEUE].token_size_in_bytes = >> + sizeof(struct ipu7_insys_resp); >> + queue_configs[IPU_INSYS_OUTPUT_RESERVED_QUEUE].max_capacity = 0; >> + queue_configs[IPU_INSYS_OUTPUT_RESERVED_QUEUE].token_size_in_bytes = 0; >> + >> + queue_configs[IPU_INSYS_INPUT_DEV_QUEUE].max_capacity = >> + IPU_ISYS_MAX_STREAMS; >> + queue_configs[IPU_INSYS_INPUT_DEV_QUEUE].token_size_in_bytes = >> + sizeof(struct ipu7_insys_send_queue_token); >> + >> + for (i = IPU_INSYS_INPUT_MSG_QUEUE; i < num_queues; i++) { >> + queue_configs[i].max_capacity = IPU_ISYS_SIZE_SEND_QUEUE; >> + queue_configs[i].token_size_in_bytes = >> + sizeof(struct ipu7_insys_send_queue_token); >> + } >> + >> + /* Allocate ISYS subsys config. */ >> + isys_config = ipu7_dma_alloc(adev, sizeof(struct ipu7_insys_config), >> + &isys_config_dma_addr, GFP_KERNEL, 0); >> + if (!isys_config) { >> + dev_err(dev, "Failed to allocate isys subsys config.\n"); >> + ipu7_fw_isys_release(isys); >> + return -ENOMEM; >> + } >> + isys->subsys_config = isys_config; >> + isys->subsys_config_dma_addr = isys_config_dma_addr; >> + memset(isys_config, 0, sizeof(struct ipu7_insys_config)); >> + isys_config->logger_config.use_source_severity = 0; >> + isys_config->logger_config.use_channels_enable_bitmask = 1; >> + isys_config->logger_config.channels_enable_bitmask = >> + LOGGER_CONFIG_CHANNEL_ENABLE_SYSCOM_BITMASK; >> + isys_config->logger_config.hw_printf_buffer_base_addr = 0U; >> + isys_config->logger_config.hw_printf_buffer_size_bytes = 0U; >> + isys_config->wdt_config.wdt_timer1_us = 0; >> + isys_config->wdt_config.wdt_timer2_us = 0; >> + ret = ipu_buttress_get_isys_freq(adev->isp, &freq); >> + if (ret) { >> + dev_err(dev, "Failed to get ISYS frequency.\n"); >> + ipu7_fw_isys_release(isys); >> + return ret; >> + } >> + >> + ipu7_dma_sync_single(adev, isys_config_dma_addr, >> + sizeof(struct ipu7_insys_config)); >> + >> + major = is_ipu8(adev->isp->hw_ver) ? 2U : 1U; >> + ret = ipu7_boot_init_boot_config(adev, queue_configs, num_queues, >> + freq, isys_config_dma_addr, major); >> + if (ret) >> + ipu7_fw_isys_release(isys); >> + >> + return ret; >> +} >> + >> +void ipu7_fw_isys_release(struct ipu7_isys *isys) >> +{ >> + struct ipu7_bus_device *adev = isys->adev; >> + >> + ipu7_boot_release_boot_config(adev); >> + if (isys->subsys_config) { >> + ipu7_dma_free(adev, >> + sizeof(struct ipu7_insys_config), >> + isys->subsys_config, >> + isys->subsys_config_dma_addr, 0); >> + isys->subsys_config = NULL; >> + isys->subsys_config_dma_addr = 0; >> + } >> +} >> + >> +int ipu7_fw_isys_open(struct ipu7_isys *isys) >> +{ >> + return ipu7_boot_start_fw(isys->adev); >> +} >> + >> +int ipu7_fw_isys_close(struct ipu7_isys *isys) >> +{ >> + return ipu7_boot_stop_fw(isys->adev); >> +} >> + >> +struct ipu7_insys_resp *ipu7_fw_isys_get_resp(struct ipu7_isys *isys) >> +{ >> + return (struct ipu7_insys_resp *) >> + ipu7_syscom_get_token(isys->adev->syscom, >> + IPU_INSYS_OUTPUT_MSG_QUEUE); >> +} >> + >> +void ipu7_fw_isys_put_resp(struct ipu7_isys *isys) >> +{ >> + ipu7_syscom_put_token(isys->adev->syscom, IPU_INSYS_OUTPUT_MSG_QUEUE); >> +} >> + >> +void ipu7_fw_isys_dump_stream_cfg(struct device *dev, >> + struct ipu7_insys_stream_cfg *cfg) >> +{ >> + unsigned int i; >> + >> + dev_dbg(dev, "---------------------------\n"); >> + dev_dbg(dev, "IPU_FW_ISYS_STREAM_CFG_DATA\n"); >> + >> + dev_dbg(dev, ".port id %d\n", cfg->port_id); >> + dev_dbg(dev, ".vc %d\n", cfg->vc); >> + dev_dbg(dev, ".nof_input_pins = %d\n", cfg->nof_input_pins); >> + dev_dbg(dev, ".nof_output_pins = %d\n", cfg->nof_output_pins); >> + dev_dbg(dev, ".stream_msg_map = 0x%x\n", cfg->stream_msg_map); >> + >> + for (i = 0; i < cfg->nof_input_pins; i++) { >> + dev_dbg(dev, ".input_pin[%d]:\n", i); >> + dev_dbg(dev, "\t.dt = 0x%0x\n", >> + cfg->input_pins[i].dt); >> + dev_dbg(dev, "\t.disable_mipi_unpacking = %d\n", >> + cfg->input_pins[i].disable_mipi_unpacking); >> + dev_dbg(dev, "\t.dt_rename_mode = %d\n", >> + cfg->input_pins[i].dt_rename_mode); >> + dev_dbg(dev, "\t.mapped_dt = 0x%0x\n", >> + cfg->input_pins[i].mapped_dt); >> + dev_dbg(dev, "\t.input_res = %d x %d\n", >> + cfg->input_pins[i].input_res.width, >> + cfg->input_pins[i].input_res.height); >> + dev_dbg(dev, "\t.sync_msg_map = 0x%x\n", >> + cfg->input_pins[i].sync_msg_map); >> + } >> + >> + for (i = 0; i < cfg->nof_output_pins; i++) { >> + dev_dbg(dev, ".output_pin[%d]:\n", i); >> + dev_dbg(dev, "\t.input_pin_id = %d\n", >> + cfg->output_pins[i].input_pin_id); >> + dev_dbg(dev, "\t.stride = %d\n", cfg->output_pins[i].stride); >> + dev_dbg(dev, "\t.send_irq = %d\n", >> + cfg->output_pins[i].send_irq); >> + dev_dbg(dev, "\t.ft = %d\n", cfg->output_pins[i].ft); >> + >> + dev_dbg(dev, "\t.link.buffer_lines = %d\n", >> + cfg->output_pins[i].link.buffer_lines); >> + dev_dbg(dev, "\t.link.foreign_key = %d\n", >> + cfg->output_pins[i].link.foreign_key); >> + dev_dbg(dev, "\t.link.granularity_pointer_update = %d\n", >> + cfg->output_pins[i].link.granularity_pointer_update); >> + dev_dbg(dev, "\t.link.msg_link_streaming_mode = %d\n", >> + cfg->output_pins[i].link.msg_link_streaming_mode); >> + dev_dbg(dev, "\t.link.pbk_id = %d\n", >> + cfg->output_pins[i].link.pbk_id); >> + dev_dbg(dev, "\t.link.pbk_slot_id = %d\n", >> + cfg->output_pins[i].link.pbk_slot_id); >> + dev_dbg(dev, "\t.link.dest = %d\n", >> + cfg->output_pins[i].link.dest); >> + dev_dbg(dev, "\t.link.use_sw_managed = %d\n", >> + cfg->output_pins[i].link.use_sw_managed); >> + dev_dbg(dev, "\t.link.is_snoop = %d\n", >> + cfg->output_pins[i].link.is_snoop); >> + >> + dev_dbg(dev, "\t.crop.line_top = %d\n", >> + cfg->output_pins[i].crop.line_top); >> + dev_dbg(dev, "\t.crop.line_bottom = %d\n", >> + cfg->output_pins[i].crop.line_bottom); >> + >> + dev_dbg(dev, "\t.dpcm_enable = %d\n", >> + cfg->output_pins[i].dpcm.enable); >> + dev_dbg(dev, "\t.dpcm.type = %d\n", >> + cfg->output_pins[i].dpcm.type); >> + dev_dbg(dev, "\t.dpcm.predictor = %d\n", >> + cfg->output_pins[i].dpcm.predictor); >> + } >> + dev_dbg(dev, "---------------------------\n"); >> +} >> + >> +void ipu7_fw_isys_dump_frame_buff_set(struct device *dev, >> + struct ipu7_insys_buffset *buf, >> + unsigned int outputs) >> +{ >> + unsigned int i; >> + >> + dev_dbg(dev, "--------------------------\n"); >> + dev_dbg(dev, "IPU_ISYS_BUFF_SET\n"); >> + dev_dbg(dev, ".capture_msg_map = %d\n", buf->capture_msg_map); >> + dev_dbg(dev, ".frame_id = %d\n", buf->frame_id); >> + dev_dbg(dev, ".skip_frame = %d\n", buf->skip_frame); >> + >> + for (i = 0; i < outputs; i++) { >> + dev_dbg(dev, ".output_pin[%d]:\n", i); >> + dev_dbg(dev, "\t.user_token = %llx\n", >> + buf->output_pins[i].user_token); >> + dev_dbg(dev, "\t.addr = 0x%x\n", buf->output_pins[i].addr); >> + } >> + dev_dbg(dev, "---------------------------\n"); >> +} >> diff --git a/drivers/staging/media/ipu7/ipu7-fw-isys.h b/drivers/staging/media/ipu7/ipu7-fw-isys.h >> new file mode 100644 >> index 000000000000..b556feda6b08 >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-fw-isys.h >> @@ -0,0 +1,39 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#ifndef IPU7_FW_ISYS_H >> +#define IPU7_FW_ISYS_H >> + >> +#include >> + >> +#include "abi/ipu7_fw_isys_abi.h" >> + >> +struct device; >> +struct ipu7_insys_buffset; >> +struct ipu7_insys_stream_cfg; >> +struct ipu7_isys; >> + >> +/* From here on type defines not coming from the ISYSAPI interface */ >> + >> +int ipu7_fw_isys_init(struct ipu7_isys *isys); >> +void ipu7_fw_isys_release(struct ipu7_isys *isys); >> +int ipu7_fw_isys_open(struct ipu7_isys *isys); >> +int ipu7_fw_isys_close(struct ipu7_isys *isys); >> + >> +void ipu7_fw_isys_dump_stream_cfg(struct device *dev, >> + struct ipu7_insys_stream_cfg *cfg); >> +void ipu7_fw_isys_dump_frame_buff_set(struct device *dev, >> + struct ipu7_insys_buffset *buf, >> + unsigned int outputs); >> +int ipu7_fw_isys_simple_cmd(struct ipu7_isys *isys, >> + const unsigned int stream_handle, u16 send_type); >> +int ipu7_fw_isys_complex_cmd(struct ipu7_isys *isys, >> + const unsigned int stream_handle, >> + void *cpu_mapped_buf, >> + dma_addr_t dma_mapped_buf, >> + size_t size, u16 send_type); >> +struct ipu7_insys_resp *ipu7_fw_isys_get_resp(struct ipu7_isys *isys); >> +void ipu7_fw_isys_put_resp(struct ipu7_isys *isys); >> +#endif >> diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c >> new file mode 100644 >> index 000000000000..e275ed393e7d >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c >> @@ -0,0 +1,1028 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + >> +#include "ipu7.h" >> +#include "ipu7-bus.h" >> +#include "ipu7-buttress.h" >> +#include "ipu7-isys.h" >> +#include "ipu7-isys-csi2.h" >> +#include "ipu7-isys-csi2-regs.h" >> +#include "ipu7-platform-regs.h" >> +#include "ipu7-isys-csi-phy.h" >> + >> +#define PORT_A 0U >> +#define PORT_B 1U >> +#define PORT_C 2U >> +#define PORT_D 3U >> + >> +struct ddlcal_counter_ref_s { >> + u16 min_mbps; >> + u16 max_mbps; >> + >> + u16 ddlcal_counter_ref; >> +}; >> + >> +struct ddlcal_params { >> + u16 min_mbps; >> + u16 max_mbps; >> + u16 oa_lanex_hsrx_cdphy_sel_fast; >> + u16 ddlcal_max_phase; >> + u16 phase_bound; >> + u16 ddlcal_dll_fbk; >> + u16 ddlcal_ddl_coarse_bank; >> + u16 fjump_deskew; >> + u16 min_eye_opening_deskew; >> +}; >> + >> +struct i_thssettle_params { >> + u16 min_mbps; >> + u16 max_mbps; >> + u16 i_thssettle; >> +}; >> + >> + /* lane2 for 4l3t, lane1 for 2l2t */ >> +struct oa_lane_clk_div_params { >> + u16 min_mbps; >> + u16 max_mbps; >> + u16 oa_lane_hsrx_hs_clk_div; >> +}; >> + >> +struct cdr_fbk_cap_prog_params { >> + u16 min_mbps; >> + u16 max_mbps; >> + u16 val; >> +}; >> + >> +static const struct ddlcal_counter_ref_s table0[] = { >> + {1500, 1999, 118}, >> + {2000, 2499, 157}, >> + {2500, 3499, 196}, >> + {3500, 4499, 274}, >> + {4500, 4500, 352}, > > Spaces inside braces, please. Will fix in v2. > >> + {} >> +}; >> + >> +static const struct ddlcal_params table1[] = { >> + {1500, 1587, 0, 143, 167, 17, 3, 4, 29}, >> + {1588, 1687, 0, 135, 167, 15, 3, 4, 27}, >> + {1688, 1799, 0, 127, 135, 15, 2, 4, 26}, >> + {1800, 1928, 0, 119, 135, 13, 2, 3, 24}, >> + {1929, 2076, 0, 111, 135, 13, 2, 3, 23}, >> + {2077, 2249, 0, 103, 135, 11, 2, 3, 21}, >> + {2250, 2454, 0, 95, 103, 11, 1, 3, 19}, >> + {2455, 2699, 0, 87, 103, 9, 1, 3, 18}, >> + {2700, 2999, 0, 79, 103, 9, 1, 2, 16}, >> + {3000, 3229, 0, 71, 71, 7, 1, 2, 15}, >> + {3230, 3599, 1, 87, 103, 9, 1, 3, 18}, >> + {3600, 3999, 1, 79, 103, 9, 1, 2, 16}, >> + {4000, 4499, 1, 71, 103, 7, 1, 2, 15}, >> + {4500, 4500, 1, 63, 71, 7, 0, 2, 13}, >> + {} >> +}; >> + >> +static const struct i_thssettle_params table2[] = { >> + {80, 124, 24}, >> + {125, 249, 20}, >> + {250, 499, 16}, >> + {500, 749, 14}, >> + {750, 1499, 13}, >> + {1500, 4500, 12}, >> + {} >> +}; >> + >> +static const struct oa_lane_clk_div_params table6[] = { >> + {80, 159, 0x1}, >> + {160, 319, 0x2}, >> + {320, 639, 0x3}, >> + {640, 1279, 0x4}, >> + {1280, 2560, 0x5}, >> + {2561, 4500, 0x6}, >> + {} >> +}; >> + >> +static const struct cdr_fbk_cap_prog_params table7[] = { >> + {80, 919, 0}, >> + {920, 1029, 1}, >> + {1030, 1169, 2}, >> + {1170, 1349, 3}, >> + {1350, 1589, 4}, >> + {1590, 1949, 5}, >> + {1950, 2499, 6}, >> + {} >> +}; >> + >> +static void dwc_phy_write(struct ipu7_isys *isys, u32 id, u32 addr, u16 data) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + void __iomem *base = isys_base + IS_IO_CDPHY_BASE(id); >> + >> + dev_dbg(&isys->adev->auxdev.dev, "phy write: reg 0x%zx = data 0x%04x", >> + base + addr - isys_base, data); >> + writew(data, base + addr); >> +} >> + >> +static u16 dwc_phy_read(struct ipu7_isys *isys, u32 id, u32 addr) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + void __iomem *base = isys_base + IS_IO_CDPHY_BASE(id); >> + u16 data; >> + >> + data = readw(base + addr); >> + dev_dbg(&isys->adev->auxdev.dev, "phy read: reg 0x%zx = data 0x%04x", >> + base + addr - isys_base, data); >> + >> + return data; >> +} >> + >> +static void dwc_csi_write(struct ipu7_isys *isys, u32 id, u32 addr, u32 data) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + void __iomem *base = isys_base + IS_IO_CSI2_HOST_BASE(id); >> + struct device *dev = &isys->adev->auxdev.dev; >> + >> + dev_dbg(dev, "csi write: reg 0x%zx = data 0x%08x", >> + base + addr - isys_base, data); >> + writel(data, base + addr); >> + dev_dbg(dev, "csi read: reg 0x%zx = data 0x%08x", >> + base + addr - isys_base, readl(base + addr)); >> +} >> + >> +static void gpreg_write(struct ipu7_isys *isys, u32 id, u32 addr, u32 data) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + u32 gpreg = isys->pdata->ipdata->csi2.gpreg; >> + void __iomem *base = isys_base + gpreg + 0x1000 * id; >> + struct device *dev = &isys->adev->auxdev.dev; >> + >> + dev_dbg(dev, "gpreg write: reg 0x%zx = data 0x%08x", >> + base + addr - isys_base, data); >> + writel(data, base + addr); >> + dev_dbg(dev, "gpreg read: reg 0x%zx = data 0x%08x", >> + base + addr - isys_base, readl(base + addr)); >> +} >> + >> +static u32 dwc_csi_read(struct ipu7_isys *isys, u32 id, u32 addr) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + void __iomem *base = isys_base + IS_IO_CSI2_HOST_BASE(id); >> + u32 data; >> + >> + data = readl(base + addr); >> + dev_dbg(&isys->adev->auxdev.dev, "csi read: reg 0x%zx = data 0x%x", >> + base + addr - isys_base, data); >> + >> + return data; >> +} >> + >> +static void dwc_phy_write_mask(struct ipu7_isys *isys, u32 id, u32 addr, >> + u16 val, u8 lo, u8 hi) >> +{ >> + u32 temp, mask; >> + >> + WARN_ON(lo > hi); >> + WARN_ON(hi > 15); >> + >> + mask = ((~0U - (1U << lo) + 1U)) & (~0U >> (31 - hi)); >> + temp = dwc_phy_read(isys, id, addr); >> + temp &= ~mask; >> + temp |= (val << lo) & mask; >> + dwc_phy_write(isys, id, addr, temp); >> +} >> + >> +static void dwc_csi_write_mask(struct ipu7_isys *isys, u32 id, u32 addr, >> + u32 val, u8 hi, u8 lo) >> +{ >> + u32 temp, mask; >> + >> + WARN_ON(lo > hi); >> + >> + mask = ((~0U - (1U << lo) + 1U)) & (~0U >> (31 - hi)); >> + temp = dwc_csi_read(isys, id, addr); >> + temp &= ~mask; >> + temp |= (val << lo) & mask; >> + dwc_csi_write(isys, id, addr, temp); >> +} >> + >> +static void ipu7_isys_csi_ctrl_cfg(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + struct device *dev = &isys->adev->auxdev.dev; >> + u32 id, lanes, phy_mode; >> + u32 val; >> + >> + id = csi2->port; >> + lanes = csi2->nlanes; >> + phy_mode = csi2->phy_mode; >> + dev_dbg(dev, "csi-%d controller init with %u lanes, phy mode %u", >> + id, lanes, phy_mode); >> + >> + val = dwc_csi_read(isys, id, VERSION); >> + dev_dbg(dev, "csi-%d controller version = 0x%x", id, val); >> + >> + /* num of active data lanes */ >> + dwc_csi_write(isys, id, N_LANES, lanes - 1); >> + dwc_csi_write(isys, id, CDPHY_MODE, phy_mode); >> + dwc_csi_write(isys, id, VC_EXTENSION, 0); >> + >> + /* only mask PHY_FATAL and PKT_FATAL interrupts */ >> + dwc_csi_write(isys, id, INT_MSK_PHY_FATAL, 0xff); >> + dwc_csi_write(isys, id, INT_MSK_PKT_FATAL, 0x3); >> + dwc_csi_write(isys, id, INT_MSK_PHY, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_LINE, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_BNDRY_FRAME_FATAL, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_SEQ_FRAME_FATAL, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_CRC_FRAME_FATAL, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_PLD_CRC_FATAL, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_DATA_ID, 0x0); >> + dwc_csi_write(isys, id, INT_MSK_ECC_CORRECTED, 0x0); >> +} >> + >> +static void ipu7_isys_csi_phy_reset(struct ipu7_isys *isys, u32 id) >> +{ >> + dwc_csi_write(isys, id, PHY_SHUTDOWNZ, 0); >> + dwc_csi_write(isys, id, DPHY_RSTZ, 0); >> + dwc_csi_write(isys, id, CSI2_RESETN, 0); >> + gpreg_write(isys, id, PHY_RESET, 0); >> + gpreg_write(isys, id, PHY_SHUTDOWN, 0); >> +} >> + >> +#define N_DATA_IDS 8 >> +static DECLARE_BITMAP(data_ids, N_DATA_IDS); > > Please move to device context struct. > >> +/* 8 Data ID monitors, each Data ID is composed by pair of VC and data type */ >> +static int __dids_config(struct ipu7_isys_csi2 *csi2, u32 id, u8 vc, u8 dt) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + u32 reg, n; >> + u8 lo, hi; >> + int ret; >> + >> + dev_dbg(&isys->adev->auxdev.dev, "config CSI-%u with vc:%u dt:0x%02x\n", >> + id, vc, dt); >> + >> + dwc_csi_write(isys, id, VC_EXTENSION, 0x0); >> + n = find_first_zero_bit(data_ids, N_DATA_IDS); >> + if (n == N_DATA_IDS) >> + return -ENOSPC; >> + >> + ret = test_and_set_bit(n, data_ids); >> + if (ret) >> + return -EBUSY; >> + >> + reg = n < 4 ? DATA_IDS_VC_1 : DATA_IDS_VC_2; >> + lo = (n % 4) * 8; >> + hi = lo + 4; >> + dwc_csi_write_mask(isys, id, reg, vc & GENMASK(4, 0), hi, lo); >> + >> + reg = n < 4 ? DATA_IDS_1 : DATA_IDS_2; >> + lo = (n % 4) * 8; >> + hi = lo + 5; >> + dwc_csi_write_mask(isys, id, reg, dt & GENMASK(5, 0), hi, lo); >> + >> + return 0; >> +} >> + >> +static int ipu7_isys_csi_ctrl_dids_config(struct ipu7_isys_csi2 *csi2, u32 id) >> +{ >> + struct v4l2_mbus_frame_desc_entry *desc_entry = NULL; >> + struct device *dev = &csi2->isys->adev->auxdev.dev; >> + struct v4l2_mbus_frame_desc desc; >> + struct v4l2_subdev *ext_sd; >> + struct media_pad *pad; >> + unsigned int i; >> + int ret; >> + >> + pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); >> + if (IS_ERR(pad)) { >> + dev_warn(dev, "can't get remote source pad of %s (%ld)\n", >> + csi2->asd.sd.name, PTR_ERR(pad)); >> + return PTR_ERR(pad); >> + } >> + >> + ext_sd = media_entity_to_v4l2_subdev(pad->entity); >> + if (WARN(!ext_sd, "Failed to get subdev for entity %s\n", >> + pad->entity->name)) >> + return -ENODEV; >> + >> + ret = v4l2_subdev_call(ext_sd, pad, get_frame_desc, pad->index, &desc); > > Note that not all sensor drivers support get_frame_desc. Your driver should > also work with those. The caller ignore the returned errors now. > >> + if (ret) >> + return ret; >> + >> + if (desc.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2) { >> + dev_warn(dev, "Unsupported frame descriptor type\n"); >> + return -EINVAL; >> + } >> + >> + for (i = 0; i < desc.num_entries; i++) { >> + desc_entry = &desc.entry[i]; >> + if (desc_entry->bus.csi2.vc < NR_OF_CSI2_VC) { >> + ret = __dids_config(csi2, id, desc_entry->bus.csi2.vc, >> + desc_entry->bus.csi2.dt); >> + if (ret) >> + return ret; >> + } >> + } >> + >> + return 0; >> +} >> + >> +#define CDPHY_TIMEOUT (5000000) > > No need for parenthesis. > >> +static int ipu7_isys_phy_ready(struct ipu7_isys *isys, u32 id) >> +{ >> + void __iomem *isys_base = isys->pdata->base; >> + u32 gpreg_offset = isys->pdata->ipdata->csi2.gpreg; >> + void __iomem *gpreg = isys_base + gpreg_offset + 0x1000 * id; >> + struct device *dev = &isys->adev->auxdev.dev; >> + unsigned int i; >> + u32 phy_ready; >> + u32 reg, rext; >> + int ret; >> + >> + dev_dbg(dev, "waiting phy ready...\n"); >> + ret = readl_poll_timeout(gpreg + PHY_READY, phy_ready, >> + phy_ready & BIT(0) && phy_ready != ~0U, >> + 100, CDPHY_TIMEOUT); >> + dev_dbg(dev, "phy %u ready = 0x%08x\n", id, readl(gpreg + PHY_READY)); >> + dev_dbg(dev, "csi %u PHY_RX = 0x%08x\n", id, >> + dwc_csi_read(isys, id, PHY_RX)); >> + dev_dbg(dev, "csi %u PHY_STOPSTATE = 0x%08x\n", id, >> + dwc_csi_read(isys, id, PHY_STOPSTATE)); >> + dev_dbg(dev, "csi %u PHY_CAL = 0x%08x\n", id, >> + dwc_csi_read(isys, id, PHY_CAL)); >> + for (i = 0; i < 4U; i++) { >> + reg = CORE_DIG_DLANE_0_R_HS_RX_0 + (i * 0x400U); >> + dev_dbg(dev, "phy %u DLANE%u skewcal = 0x%04x\n", >> + id, i, dwc_phy_read(isys, id, reg)); >> + } >> + dev_dbg(dev, "phy %u DDLCAL = 0x%04x\n", id, >> + dwc_phy_read(isys, id, PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_5)); >> + dev_dbg(dev, "phy %u TERMCAL = 0x%04x\n", id, >> + dwc_phy_read(isys, id, PPI_R_TERMCAL_DEBUG_0)); >> + dev_dbg(dev, "phy %u LPDCOCAL = 0x%04x\n", id, >> + dwc_phy_read(isys, id, PPI_R_LPDCOCAL_DEBUG_RB)); >> + dev_dbg(dev, "phy %u HSDCOCAL = 0x%04x\n", id, >> + dwc_phy_read(isys, id, PPI_R_HSDCOCAL_DEBUG_RB)); >> + dev_dbg(dev, "phy %u LPDCOCAL_VT = 0x%04x\n", id, >> + dwc_phy_read(isys, id, PPI_R_LPDCOCAL_DEBUG_VT)); >> + >> + if (!ret) { >> + if (id) { >> + dev_dbg(dev, "ignore phy %u rext\n", id); >> + return 0; >> + } >> + >> + rext = dwc_phy_read(isys, id, >> + CORE_DIG_IOCTRL_R_AFE_CB_CTRL_2_15) & 0xfU; >> + dev_dbg(dev, "phy %u rext value = %u\n", id, rext); >> + isys->phy_rext_cal = (rext ? rext : 5); >> + >> + return 0; >> + } >> + >> + dev_err(dev, "wait phy ready timeout!\n"); >> + >> + return ret; >> +} >> + >> +static int lookup_table1(u16 mbps) >> +{ >> + int i; > > unsigned int, please. Same elsewhere. > >> + >> + for (i = 0; i < ARRAY_SIZE(table1); i++) { >> + if (mbps >= table1[i].min_mbps && mbps <= table1[i].max_mbps) >> + return i; >> + } >> + >> + return -ENXIO; >> +} >> + >> +static const u16 deskew_fine_mem[] = { >> + 0x0404, 0x040c, 0x0414, 0x041c, >> + 0x0423, 0x0429, 0x0430, 0x043a, >> + 0x0445, 0x044a, 0x0450, 0x045a, >> + 0x0465, 0x0469, 0x0472, 0x047a, >> + 0x0485, 0x0489, 0x0490, 0x049a, >> + 0x04a4, 0x04ac, 0x04b4, 0x04bc, >> + 0x04c4, 0x04cc, 0x04d4, 0x04dc, >> + 0x04e4, 0x04ec, 0x04f4, 0x04fc, >> + 0x0504, 0x050c, 0x0514, 0x051c, >> + 0x0523, 0x0529, 0x0530, 0x053a, >> + 0x0545, 0x054a, 0x0550, 0x055a, >> + 0x0565, 0x0569, 0x0572, 0x057a, >> + 0x0585, 0x0589, 0x0590, 0x059a, >> + 0x05a4, 0x05ac, 0x05b4, 0x05bc, >> + 0x05c4, 0x05cc, 0x05d4, 0x05dc, >> + 0x05e4, 0x05ec, 0x05f4, 0x05fc, >> + 0x0604, 0x060c, 0x0614, 0x061c, >> + 0x0623, 0x0629, 0x0632, 0x063a, >> + 0x0645, 0x064a, 0x0650, 0x065a, >> + 0x0665, 0x0669, 0x0672, 0x067a, >> + 0x0685, 0x0689, 0x0690, 0x069a, >> + 0x06a4, 0x06ac, 0x06b4, 0x06bc, >> + 0x06c4, 0x06cc, 0x06d4, 0x06dc, >> + 0x06e4, 0x06ec, 0x06f4, 0x06fc, >> + 0x0704, 0x070c, 0x0714, 0x071c, >> + 0x0723, 0x072a, 0x0730, 0x073a, >> + 0x0745, 0x074a, 0x0750, 0x075a, >> + 0x0765, 0x0769, 0x0772, 0x077a, >> + 0x0785, 0x0789, 0x0790, 0x079a, >> + 0x07a4, 0x07ac, 0x07b4, 0x07bc, >> + 0x07c4, 0x07cc, 0x07d4, 0x07dc, >> + 0x07e4, 0x07ec, 0x07f4, 0x07fc, >> +}; >> + >> +static void ipu7_isys_dphy_config(struct ipu7_isys *isys, u8 id, u8 lanes, >> + bool aggregation, u64 mbps) >> +{ >> + u16 hsrxval0 = 0; >> + u16 hsrxval1 = 0; >> + u16 hsrxval2 = 0; >> + int index; >> + u16 reg; >> + u16 val; >> + u32 i; >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_RW_COMMON_7, 0, 0, 9); >> + if (mbps > 1500) >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_7, >> + 40, 0, 7); >> + else >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_7, >> + 104, 0, 7); >> + >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_8, 80, 0, 7); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_0, 191, 0, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_7, 34, 7, 12); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_1, 38, 8, 15); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_2, 4, 12, 15); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_2, 2, 10, 11); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_2, 1, 8, 8); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_2, 38, 0, 7); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_2, 1, 9, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_4, 10, 0, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_6, 20, 0, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_7, 19, 0, 6); >> + >> + for (i = 0; i < ARRAY_SIZE(table0); i++) { >> + if (mbps >= table0[i].min_mbps && mbps <= table0[i].max_mbps) { >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_3, >> + table0[i].ddlcal_counter_ref, >> + 0, 9); >> + break; >> + } >> + } >> + >> + index = lookup_table1(mbps); >> + if (index >= 0) { >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_1, >> + table1[index].phase_bound, 0, 7); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_5, >> + table1[index].ddlcal_dll_fbk, 4, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_DDLCAL_CFG_5, >> + table1[index].ddlcal_ddl_coarse_bank, 0, 3); >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_8; >> + val = table1[index].oa_lanex_hsrx_cdphy_sel_fast; >> + for (i = 0; i < lanes + 1; i++) >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, >> + 12, 12); >> + } >> + >> + reg = CORE_DIG_DLANE_0_RW_LP_0; >> + for (i = 0; i < lanes; i++) >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 6, 8, 11); >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_2, >> + 0, 0, 0); >> + if (!is_ipu7(isys->adev->isp->hw_ver) || >> + id == PORT_B || id == PORT_C) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_2, >> + 1, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_2, >> + 0, 0, 0); >> + } else { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_2, >> + 0, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_2, >> + 1, 0, 0); >> + } >> + >> + if (lanes == 4 && is_ipu7(isys->adev->isp->hw_ver)) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_2, >> + 0, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_2, >> + 0, 0, 0); >> + } >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_RW_COMMON_6, 1, 0, 2); >> + dwc_phy_write_mask(isys, id, CORE_DIG_RW_COMMON_6, 1, 3, 5); >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_12; >> + val = (mbps > 1500) ? 0 : 1; >> + for (i = 0; i < lanes + 1; i++) { >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, 1, 1); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), !val, 3, 3); >> + } >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_13; >> + val = (mbps > 1500) ? 0 : 1; >> + for (i = 0; i < lanes + 1; i++) { >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, 1, 1); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, 3, 3); >> + } >> + >> + if (!is_ipu7(isys->adev->isp->hw_ver) || id == PORT_B || id == PORT_C) >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_9; >> + else >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_9; >> + >> + for (i = 0; i < ARRAY_SIZE(table6); i++) { >> + if (mbps >= table6[i].min_mbps && mbps <= table6[i].max_mbps) { >> + dwc_phy_write_mask(isys, id, reg, >> + table6[i].oa_lane_hsrx_hs_clk_div, >> + 5, 7); >> + break; >> + } >> + } >> + >> + if (aggregation) { >> + dwc_phy_write_mask(isys, id, CORE_DIG_RW_COMMON_0, 1, >> + 1, 1); >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_15; >> + dwc_phy_write_mask(isys, id, reg, 3, 3, 4); >> + >> + val = (id == PORT_A) ? 3 : 0; >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_15; >> + dwc_phy_write_mask(isys, id, reg, val, 3, 4); >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_15; >> + dwc_phy_write_mask(isys, id, reg, 3, 3, 4); >> + } >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_DLANE_CLK_RW_HS_RX_0, 28, 0, 7); >> + dwc_phy_write_mask(isys, id, CORE_DIG_DLANE_CLK_RW_HS_RX_7, 6, 0, 7); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_0; >> + for (i = 0; i < ARRAY_SIZE(table2); i++) { >> + if (mbps >= table2[i].min_mbps && mbps <= table2[i].max_mbps) { >> + u8 j; >> + >> + for (j = 0; j < lanes; j++) >> + dwc_phy_write_mask(isys, id, reg + (j * 0x400), >> + table2[i].i_thssettle, >> + 8, 15); >> + break; >> + } >> + } >> + >> + /* deskew */ >> + for (i = 0; i < lanes; i++) { >> + reg = CORE_DIG_DLANE_0_RW_CFG_1; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), >> + ((mbps > 1500) ? 0x1 : 0x2), 2, 3); > > You can remove three pairs of parentheses above. Same below. This also just to satisfy the MISRA (FUSA) rule :(. > >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_2; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), >> + ((mbps > 2500) ? 0 : 1), 15, 15); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 1, 13, 13); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 7, 9, 12); >> + >> + reg = CORE_DIG_DLANE_0_RW_LP_0; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 1, 12, 15); >> + >> + reg = CORE_DIG_DLANE_0_RW_LP_2; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 0, 0, 0); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_1; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 16, 0, 7); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_3; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 2, 0, 2); >> + index = lookup_table1(mbps); >> + if (index >= 0) { >> + val = table1[index].fjump_deskew; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, >> + 3, 8); >> + } >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_4; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 150, 0, 15); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_5; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 0, 0, 7); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 1, 8, 15); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_6; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 2, 0, 7); >> + index = lookup_table1(mbps); >> + if (index >= 0) { >> + val = table1[index].min_eye_opening_deskew; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, >> + 8, 15); >> + } >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_7; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 0, 13, 13); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 0, 15, 15); >> + >> + reg = CORE_DIG_DLANE_0_RW_HS_RX_9; >> + index = lookup_table1(mbps); >> + if (index >= 0) { >> + val = table1[index].ddlcal_max_phase; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), >> + val, 0, 7); >> + } >> + } >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_DLANE_CLK_RW_LP_0, 1, 12, 15); >> + dwc_phy_write_mask(isys, id, CORE_DIG_DLANE_CLK_RW_LP_2, 0, 0, 0); >> + >> + for (i = 0; i < ARRAY_SIZE(deskew_fine_mem); i++) >> + dwc_phy_write_mask(isys, id, CORE_DIG_COMMON_RW_DESKEW_FINE_MEM, >> + deskew_fine_mem[i], 0, 15); >> + >> + if (mbps > 1500) { >> + hsrxval0 = 4; >> + hsrxval2 = 3; >> + } >> + >> + if (mbps > 2500) >> + hsrxval1 = 2; >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_9, >> + hsrxval0, 0, 2); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_9, >> + hsrxval0, 0, 2); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_9, >> + hsrxval0, 0, 2); >> + if (lanes == 4 && is_ipu7(isys->adev->isp->hw_ver)) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_9, >> + hsrxval0, 0, 2); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_9, >> + hsrxval0, 0, 2); >> + } >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_9, >> + hsrxval1, 3, 4); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_9, >> + hsrxval1, 3, 4); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_9, >> + hsrxval1, 3, 4); >> + if (lanes == 4 && is_ipu7(isys->adev->isp->hw_ver)) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_9, >> + hsrxval1, 3, 4); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_9, >> + hsrxval1, 3, 4); >> + } >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_15, >> + hsrxval2, 0, 2); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_15, >> + hsrxval2, 0, 2); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_15, >> + hsrxval2, 0, 2); >> + if (lanes == 4 && is_ipu7(isys->adev->isp->hw_ver)) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_15, >> + hsrxval2, 0, 2); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_15, >> + hsrxval2, 0, 2); >> + } >> + >> + /* force and override rext */ >> + if (isys->phy_rext_cal && id) { >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_8, >> + isys->phy_rext_cal, 0, 3); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_7, >> + 1, 11, 11); >> + } >> +} >> + >> +static void ipu7_isys_cphy_config(struct ipu7_isys *isys, u8 id, u8 lanes, >> + bool aggregation, u64 mbps) >> +{ >> + u8 trios = 2; >> + u16 coarse_target; >> + u16 deass_thresh; >> + u16 delay_thresh; >> + u16 reset_thresh; >> + u16 cap_prog = 6U; >> + u16 reg; >> + u16 val; >> + u32 i; >> + u32 r; >> + >> + if (is_ipu7p5(isys->adev->isp->hw_ver)) >> + val = 0x15; >> + else >> + val = 0x155; >> + >> + if (is_ipu7(isys->adev->isp->hw_ver)) >> + trios = 3; > > It'd be good to have hardware version specific struct where you'd have such > values in a single location. > It could be done, but there are many variants and a new IPU7 platform is coming, I think I can do this in future. >> + >> + dwc_phy_write_mask(isys, id, CORE_DIG_RW_COMMON_7, val, 0, 9); >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_7, 104, 0, 7); >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_8, 16, 0, 7); >> + >> + reg = CORE_DIG_CLANE_0_RW_LP_0; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 6, 8, 11); >> + >> + val = (mbps > 900U) ? 1U : 0U; >> + for (i = 0; i < trios; i++) { >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_0; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 1, 0, 0); >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), val, 1, 1); >> + >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_1; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 38, 0, 15); >> + >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_5; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 38, 0, 15); >> + >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_6; >> + dwc_phy_write_mask(isys, id, reg + (i * 0x400), 10, 0, 15); >> + } > > Too many magic numbers. :-( Please come up with human-readable names for > these, including 0x400. > > Simiarly below and probably elsewhere, too. No need to apply to individual > tables entries though, but they need to be separate from the code. I don't think it is doable now, these are from PHY manual, I don't know the actual meaning of these magic registers. > >> + >> + /* >> + * Below 900Msps, always use the same value. >> + * The formula is suitable for data rate 80-3500Msps. >> + * Timebase (us) = 1, DIV = 32, TDDL (UI) = 0.5 >> + */ >> + if (mbps >= 80U) { >> + coarse_target = (u16)div_u64_rem(mbps, 16, &r); > > No need to cast. > >> + if (!r) >> + coarse_target--; >> + } else { >> + coarse_target = 56; >> + } >> + >> + for (i = 0; i < trios; i++) { >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_2 + i * 0x400; >> + dwc_phy_write_mask(isys, id, reg, coarse_target, 0, 15); >> + } >> + >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_2, 1, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_2, 0, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_2, 1, 0, 0); >> + >> + if (!is_ipu7p5(isys->adev->isp->hw_ver) && lanes == 4) { >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_2, >> + 1, 0, 0); >> + dwc_phy_write_mask(isys, id, >> + CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_2, >> + 0, 0, 0); >> + } >> + >> + for (i = 0; i < trios; i++) { >> + reg = CORE_DIG_RW_TRIO0_0 + i * 0x400; >> + dwc_phy_write_mask(isys, id, reg, 1, 6, 8); >> + dwc_phy_write_mask(isys, id, reg, 1, 3, 5); >> + dwc_phy_write_mask(isys, id, reg, 2, 0, 2); >> + } >> + >> + deass_thresh = (u16)div_u64_rem(7 * 1000 * 6, mbps * 5U, &r) + 1; >> + if (r != 0) >> + deass_thresh++; >> + >> + reg = CORE_DIG_RW_TRIO0_2; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, >> + deass_thresh, 0, 7); >> + >> + delay_thresh = >> + ((224U - (9U * 7U)) * 1000U) / (5U * mbps) - 7U; >> + >> + if (delay_thresh < 1) >> + delay_thresh = 1; >> + >> + reg = CORE_DIG_RW_TRIO0_1; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, >> + delay_thresh, 0, 15); >> + >> + reset_thresh = (u16)div_u64_rem(2U * 5U * mbps, 7U * 1000U, &r); >> + if (!r) >> + reset_thresh--; >> + >> + if (reset_thresh < 1) >> + reset_thresh = 1; >> + >> + reg = CORE_DIG_RW_TRIO0_0; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, >> + reset_thresh, 9, 11); >> + >> + reg = CORE_DIG_CLANE_0_RW_LP_0; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, 1, 12, 15); >> + >> + reg = CORE_DIG_CLANE_0_RW_LP_2; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, 0, 0, 0); >> + >> + reg = CORE_DIG_CLANE_0_RW_HS_RX_0; >> + for (i = 0; i < trios; i++) >> + dwc_phy_write_mask(isys, id, reg + 0x400 * i, 12, 2, 6); >> + >> + for (i = 0; i < ARRAY_SIZE(table7); i++) { >> + if (mbps >= table7[i].min_mbps && mbps <= table7[i].max_mbps) { >> + cap_prog = table7[i].val; >> + break; >> + } >> + } >> + >> + for (i = 0; i < (lanes + 1); i++) { >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_9 + 0x400 * i; >> + dwc_phy_write_mask(isys, id, reg, 4U, 0, 2); >> + dwc_phy_write_mask(isys, id, reg, 0U, 3, 4); >> + >> + reg = CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_7 + 0x400 * i; >> + dwc_phy_write_mask(isys, id, reg, cap_prog, 10, 12); >> + } >> +} >> + >> +static void ipu7_isys_phy_config(struct ipu7_isys *isys, u8 id, u8 lanes, >> + bool aggregation) >> +{ >> + struct device *dev = &isys->adev->auxdev.dev; >> + u32 phy_mode; >> + s64 link_freq; >> + u64 mbps; >> + >> + if (aggregation) >> + link_freq = ipu7_isys_csi2_get_link_freq(&isys->csi2[0]); >> + else >> + link_freq = ipu7_isys_csi2_get_link_freq(&isys->csi2[id]); >> + >> + if (link_freq < 0) { >> + dev_warn(dev, "get link freq failed, use default mbps\n"); >> + link_freq = 560000000; >> + } >> + >> + mbps = div_u64(link_freq, 500000); >> + dev_dbg(dev, "config phy %u with lanes %u aggregation %d mbps %lld\n", >> + id, lanes, aggregation, mbps); >> + >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_10, 48, 0, 7); >> + dwc_phy_write_mask(isys, id, CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_2, >> + 1, 12, 13); >> + dwc_phy_write_mask(isys, id, CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_0, >> + 63, 2, 7); >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_STARTUP_1_1, >> + 563, 0, 11); >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_2, 5, 0, 7); >> + /* bypass the RCAL state (bit6) */ >> + if (aggregation && id != PORT_A) >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_2, 0x45, >> + 0, 7); >> + >> + dwc_phy_write_mask(isys, id, PPI_STARTUP_RW_COMMON_DPHY_6, 39, 0, 7); >> + dwc_phy_write_mask(isys, id, PPI_CALIBCTRL_RW_COMMON_BG_0, 500, 0, 8); >> + dwc_phy_write_mask(isys, id, PPI_RW_TERMCAL_CFG_0, 38, 0, 6); >> + dwc_phy_write_mask(isys, id, PPI_RW_OFFSETCAL_CFG_0, 7, 0, 4); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_TIMEBASE, 153, 0, 9); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_NREF, 800, 0, 10); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_NREF_RANGE, 27, 0, 4); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_TWAIT_CONFIG, 47, 0, 8); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_TWAIT_CONFIG, 127, 9, 15); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_VT_CONFIG, 47, 7, 15); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_VT_CONFIG, 27, 2, 6); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_VT_CONFIG, 3, 0, 1); >> + dwc_phy_write_mask(isys, id, PPI_RW_LPDCOCAL_COARSE_CFG, 1, 0, 1); >> + dwc_phy_write_mask(isys, id, PPI_RW_COMMON_CFG, 3, 0, 1); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_0, >> + 0, 10, 10); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_1, >> + 1, 10, 10); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_1, >> + 0, 15, 15); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_3, >> + 3, 8, 9); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_0, >> + 0, 15, 15); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_6, >> + 7, 12, 14); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_7, >> + 0, 8, 10); >> + dwc_phy_write_mask(isys, id, CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_5, >> + 0, 8, 8); >> + >> + if (aggregation) >> + phy_mode = isys->csi2[0].phy_mode; >> + else >> + phy_mode = isys->csi2[id].phy_mode; >> + >> + if (phy_mode == PHY_MODE_DPHY) { >> + ipu7_isys_dphy_config(isys, id, lanes, aggregation, mbps); >> + } else if (phy_mode == PHY_MODE_CPHY) { >> + ipu7_isys_cphy_config(isys, id, lanes, aggregation, mbps); >> + } else { >> + dev_err(dev, "unsupported phy mode %d!\n", >> + isys->csi2[id].phy_mode); >> + } >> +} >> + >> +int ipu7_isys_csi_phy_powerup(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + u32 lanes = csi2->nlanes; >> + bool aggregation = false; >> + u32 id = csi2->port; >> + int ret; >> + >> + /* lanes remapping for aggregation (port AB) mode */ >> + if (!is_ipu7(isys->adev->isp->hw_ver) && lanes > 2 && id == PORT_A) { >> + aggregation = true; >> + lanes = 2; >> + } >> + >> + ipu7_isys_csi_phy_reset(isys, id); >> + gpreg_write(isys, id, PHY_CLK_LANE_CONTROL, 0x1); >> + gpreg_write(isys, id, PHY_CLK_LANE_FORCE_CONTROL, 0x2); >> + gpreg_write(isys, id, PHY_LANE_CONTROL_EN, (1U << lanes) - 1U); >> + gpreg_write(isys, id, PHY_LANE_FORCE_CONTROL, 0xf); >> + gpreg_write(isys, id, PHY_MODE, csi2->phy_mode); >> + >> + /* config PORT_B if aggregation mode */ >> + if (aggregation) { >> + ipu7_isys_csi_phy_reset(isys, PORT_B); >> + gpreg_write(isys, PORT_B, PHY_CLK_LANE_CONTROL, 0x0); >> + gpreg_write(isys, PORT_B, PHY_LANE_CONTROL_EN, 0x3); >> + gpreg_write(isys, PORT_B, PHY_CLK_LANE_FORCE_CONTROL, 0x2); >> + gpreg_write(isys, PORT_B, PHY_LANE_FORCE_CONTROL, 0xf); >> + gpreg_write(isys, PORT_B, PHY_MODE, csi2->phy_mode); >> + } >> + >> + ipu7_isys_csi_ctrl_cfg(csi2); >> + ipu7_isys_csi_ctrl_dids_config(csi2, id); >> + >> + ipu7_isys_phy_config(isys, id, lanes, aggregation); >> + gpreg_write(isys, id, PHY_RESET, 1); >> + gpreg_write(isys, id, PHY_SHUTDOWN, 1); >> + dwc_csi_write(isys, id, DPHY_RSTZ, 1); >> + dwc_csi_write(isys, id, PHY_SHUTDOWNZ, 1); >> + dwc_csi_write(isys, id, CSI2_RESETN, 1); >> + >> + ret = ipu7_isys_phy_ready(isys, id); >> + if (ret < 0) >> + return ret; >> + >> + gpreg_write(isys, id, PHY_LANE_FORCE_CONTROL, 0); >> + gpreg_write(isys, id, PHY_CLK_LANE_FORCE_CONTROL, 0); >> + >> + /* config PORT_B if aggregation mode */ >> + if (aggregation) { >> + ipu7_isys_phy_config(isys, PORT_B, 2, aggregation); >> + gpreg_write(isys, PORT_B, PHY_RESET, 1); >> + gpreg_write(isys, PORT_B, PHY_SHUTDOWN, 1); >> + dwc_csi_write(isys, PORT_B, DPHY_RSTZ, 1); >> + dwc_csi_write(isys, PORT_B, PHY_SHUTDOWNZ, 1); >> + dwc_csi_write(isys, PORT_B, CSI2_RESETN, 1); >> + ret = ipu7_isys_phy_ready(isys, PORT_B); >> + if (ret < 0) >> + return ret; >> + >> + gpreg_write(isys, PORT_B, PHY_LANE_FORCE_CONTROL, 0); >> + gpreg_write(isys, PORT_B, PHY_CLK_LANE_FORCE_CONTROL, 0); >> + } >> + >> + return 0; >> +} >> + >> +void ipu7_isys_csi_phy_powerdown(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + >> + ipu7_isys_csi_phy_reset(isys, csi2->port); >> + if (!is_ipu7(isys->adev->isp->hw_ver) && >> + csi2->nlanes > 2U && csi2->port == PORT_A) >> + ipu7_isys_csi_phy_reset(isys, PORT_B); >> +} >> diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.h b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.h >> new file mode 100644 >> index 000000000000..dfdcb61540c4 >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.h >> @@ -0,0 +1,16 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#ifndef IPU7_ISYS_CSI_PHY_H >> +#define IPU7_ISYS_CSI_PHY_H >> + >> +struct ipu7_isys; >> + >> +#define PHY_MODE_DPHY 0U >> +#define PHY_MODE_CPHY 1U >> + >> +int ipu7_isys_csi_phy_powerup(struct ipu7_isys_csi2 *csi2); >> +void ipu7_isys_csi_phy_powerdown(struct ipu7_isys_csi2 *csi2); >> +#endif >> diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2-regs.h b/drivers/staging/media/ipu7/ipu7-isys-csi2-regs.h >> new file mode 100644 >> index 000000000000..32704ca21341 >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-isys-csi2-regs.h >> @@ -0,0 +1,1197 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2020 - 2025 Intel Corporation >> + */ >> + >> +#ifndef IPU7_ISYS_CSI2_REG_H >> +#define IPU7_ISYS_CSI2_REG_H >> + >> +/* IS main regs base */ >> +#define IS_MAIN_BASE (0x240000U) > > Please drop U specifier from hexadecimal values. > We changed these for fixing the FUSA(MISRA C) problems, is it not liked by kernel coding rule? >> +#define IS_MAIN_S2B_BASE (IS_MAIN_BASE + 0x22000U) >> +#define IS_MAIN_B2O_BASE (IS_MAIN_BASE + 0x26000U) >> +#define IS_MAIN_ISD_M0_BASE (IS_MAIN_BASE + 0x2b000U) >> +#define IS_MAIN_ISD_M1_BASE (IS_MAIN_BASE + 0x2b100U) >> +#define IS_MAIN_ISD_INT_BASE (IS_MAIN_BASE + 0x2b200U) >> +#define IS_MAIN_GDA_BASE (IS_MAIN_BASE + 0x32000U) >> +#define IS_MAIN_GPREGS_MAIN_BASE (IS_MAIN_BASE + 0x32500U) >> +#define IS_MAIN_IRQ_CTRL_BASE (IS_MAIN_BASE + 0x32700U) >> +#define IS_MAIN_PWM_CTRL_BASE (IS_MAIN_BASE + 0x32b00U) >> + >> +#define S2B_IRQ_COMMON_0_CTL_STATUS (IS_MAIN_S2B_BASE + 0x1cU) >> +#define S2B_IRQ_COMMON_0_CTL_CLEAR (IS_MAIN_S2B_BASE + 0x20U) >> +#define S2B_IRQ_COMMON_0_CTL_ENABLE (IS_MAIN_S2B_BASE + 0x24U) >> +#define S2B_IID_IRQ_CTL_STATUS(iid) (IS_MAIN_S2B_BASE + 0x94U + \ >> + 0x100U * (iid)) >> + >> +#define B2O_IRQ_COMMON_0_CTL_STATUS (IS_MAIN_B2O_BASE + 0x30U) >> +#define B2O_IRQ_COMMON_0_CTL_CLEAR (IS_MAIN_B2O_BASE + 0x34U) >> +#define B2O_IRQ_COMMON_0_CTL_ENABLE (IS_MAIN_B2O_BASE + 0x38U) >> +#define B2O_IID_IRQ_CTL_STATUS(oid) (IS_MAIN_B2O_BASE + 0x3dcU + \ >> + 0x200U * (oid)) >> + >> +#define ISD_M0_IRQ_CTL_STATUS (IS_MAIN_ISD_M0_BASE + 0x1cU) >> +#define ISD_M0_IRQ_CTL_CLEAR (IS_MAIN_ISD_M0_BASE + 0x20U) >> +#define ISD_M0_IRQ_CTL_ENABLE (IS_MAIN_ISD_M0_BASE + 0x24U) >> + >> +#define ISD_M1_IRQ_CTL_STATUS (IS_MAIN_ISD_M1_BASE + 0x1cU) >> +#define ISD_M1_IRQ_CTL_CLEAR (IS_MAIN_ISD_M1_BASE + 0x20U) >> +#define ISD_M1_IRQ_CTL_ENABLE (IS_MAIN_ISD_M1_BASE + 0x24U) >> + >> +#define ISD_INT_IRQ_CTL_STATUS (IS_MAIN_ISD_INT_BASE + 0x1cU) >> +#define ISD_INT_IRQ_CTL_CLEAR (IS_MAIN_ISD_INT_BASE + 0x20U) >> +#define ISD_INT_IRQ_CTL_ENABLE (IS_MAIN_ISD_INT_BASE + 0x24U) >> + >> +#define GDA_IRQ_CTL_STATUS (IS_MAIN_GDA_BASE + 0x1cU) >> +#define GDA_IRQ_CTL_CLEAR (IS_MAIN_GDA_BASE + 0x20U) >> +#define GDA_IRQ_CTL_ENABLE (IS_MAIN_GDA_BASE + 0x24U) >> + >> +#define IS_MAIN_IRQ_CTL_EDGE IS_MAIN_IRQ_CTRL_BASE >> +#define IS_MAIN_IRQ_CTL_MASK (IS_MAIN_IRQ_CTRL_BASE + 0x4U) >> +#define IS_MAIN_IRQ_CTL_STATUS (IS_MAIN_IRQ_CTRL_BASE + 0x8U) >> +#define IS_MAIN_IRQ_CTL_CLEAR (IS_MAIN_IRQ_CTRL_BASE + 0xcU) >> +#define IS_MAIN_IRQ_CTL_ENABLE (IS_MAIN_IRQ_CTRL_BASE + 0x10U) >> +#define IS_MAIN_IRQ_CTL_LEVEL_NOT_PULSE (IS_MAIN_IRQ_CTRL_BASE + 0x14U) >> + >> +/* IS IO regs base */ >> +#define IS_PHY_NUM (4U) >> +#define IS_IO_BASE (0x280000U) >> + >> +/* dwc csi cdphy registers */ >> +#define IS_IO_CDPHY_BASE(i) (IS_IO_BASE + 0x10000U * (i)) >> +#define PPI_STARTUP_RW_COMMON_DPHY_0 0x1800U >> +#define PPI_STARTUP_RW_COMMON_DPHY_1 0x1802U >> +#define PPI_STARTUP_RW_COMMON_DPHY_2 0x1804U >> +#define PPI_STARTUP_RW_COMMON_DPHY_3 0x1806U >> +#define PPI_STARTUP_RW_COMMON_DPHY_4 0x1808U >> +#define PPI_STARTUP_RW_COMMON_DPHY_5 0x180aU >> +#define PPI_STARTUP_RW_COMMON_DPHY_6 0x180cU >> +#define PPI_STARTUP_RW_COMMON_DPHY_7 0x180eU >> +#define PPI_STARTUP_RW_COMMON_DPHY_8 0x1810U >> +#define PPI_STARTUP_RW_COMMON_DPHY_9 0x1812U >> +#define PPI_STARTUP_RW_COMMON_DPHY_A 0x1814U >> +#define PPI_STARTUP_RW_COMMON_DPHY_10 0x1820U >> +#define PPI_STARTUP_RW_COMMON_STARTUP_1_1 0x1822U >> +#define PPI_STARTUP_RW_COMMON_STARTUP_1_2 0x1824U >> +#define PPI_CALIBCTRL_RW_COMMON_CALIBCTRL_2_0 0x1840U >> +#define PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_1 0x1842U >> +#define PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_2 0x1844U >> +#define PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_3 0x1846U >> +#define PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_4 0x1848U >> +#define PPI_CALIBCTRL_R_COMMON_CALIBCTRL_2_5 0x184aU >> +#define PPI_CALIBCTRL_RW_COMMON_BG_0 0x184cU >> +#define PPI_CALIBCTRL_RW_COMMON_CALIBCTRL_2_7 0x184eU >> +#define PPI_CALIBCTRL_RW_ADC_CFG_0 0x1850U >> +#define PPI_CALIBCTRL_RW_ADC_CFG_1 0x1852U >> +#define PPI_CALIBCTRL_R_ADC_DEBUG 0x1854U >> +#define PPI_RW_LPDCOCAL_TOP_OVERRIDE 0x1c00U >> +#define PPI_RW_LPDCOCAL_TIMEBASE 0x1c02U >> +#define PPI_RW_LPDCOCAL_NREF 0x1c04U >> +#define PPI_RW_LPDCOCAL_NREF_RANGE 0x1c06U >> +#define PPI_RW_LPDCOCAL_NREF_TRIGGER_MAN 0x1c08U >> +#define PPI_RW_LPDCOCAL_TWAIT_CONFIG 0x1c0aU >> +#define PPI_RW_LPDCOCAL_VT_CONFIG 0x1c0cU >> +#define PPI_R_LPDCOCAL_DEBUG_RB 0x1c0eU >> +#define PPI_RW_LPDCOCAL_COARSE_CFG 0x1c10U >> +#define PPI_R_LPDCOCAL_DEBUG_COARSE_RB 0x1c12U >> +#define PPI_R_LPDCOCAL_DEBUG_COARSE_MEAS_0_RB 0x1c14U >> +#define PPI_R_LPDCOCAL_DEBUG_COARSE_MEAS_1_RB 0x1c16U >> +#define PPI_R_LPDCOCAL_DEBUG_COARSE_FWORD_RB 0x1c18U >> +#define PPI_R_LPDCOCAL_DEBUG_MEASURE_CURR_ERROR 0x1c1aU >> +#define PPI_R_LPDCOCAL_DEBUG_MEASURE_LAST_ERROR 0x1c1cU >> +#define PPI_R_LPDCOCAL_DEBUG_VT 0x1c1eU >> +#define PPI_RW_LB_TIMEBASE_CONFIG 0x1c20U >> +#define PPI_RW_LB_STARTCMU_CONFIG 0x1c22U >> +#define PPI_R_LBPULSE_COUNTER_RB 0x1c24U >> +#define PPI_R_LB_START_CMU_RB 0x1c26U >> +#define PPI_RW_LB_DPHY_BURST_START 0x1c28U >> +#define PPI_RW_LB_CPHY_BURST_START 0x1c2aU >> +#define PPI_RW_DDLCAL_CFG_0 0x1c40U >> +#define PPI_RW_DDLCAL_CFG_1 0x1c42U >> +#define PPI_RW_DDLCAL_CFG_2 0x1c44U >> +#define PPI_RW_DDLCAL_CFG_3 0x1c46U >> +#define PPI_RW_DDLCAL_CFG_4 0x1c48U >> +#define PPI_RW_DDLCAL_CFG_5 0x1c4aU >> +#define PPI_RW_DDLCAL_CFG_6 0x1c4cU >> +#define PPI_RW_DDLCAL_CFG_7 0x1c4eU >> +#define PPI_R_DDLCAL_DEBUG_0 0x1c50U >> +#define PPI_R_DDLCAL_DEBUG_1 0x1c52U >> +#define PPI_RW_PARITY_TEST 0x1c60U >> +#define PPI_RW_STARTUP_OVR_0 0x1c62U >> +#define PPI_RW_STARTUP_STATE_OVR_1 0x1c64U >> +#define PPI_RW_DTB_SELECTOR 0x1c66U >> +#define PPI_RW_DPHY_CLK_SPARE 0x1c6aU >> +#define PPI_RW_COMMON_CFG 0x1c6cU >> +#define PPI_RW_TERMCAL_CFG_0 0x1c80U >> +#define PPI_R_TERMCAL_DEBUG_0 0x1c82U >> +#define PPI_RW_TERMCAL_CTRL_0 0x1c84U >> +#define PPI_RW_OFFSETCAL_CFG_0 0x1ca0U >> +#define PPI_R_OFFSETCAL_DEBUG_LANE0 0x1ca2U >> +#define PPI_R_OFFSETCAL_DEBUG_LANE1 0x1ca4U >> +#define PPI_R_OFFSETCAL_DEBUG_LANE2 0x1ca6U >> +#define PPI_R_OFFSETCAL_DEBUG_LANE3 0x1ca8U >> +#define PPI_R_OFFSETCAL_DEBUG_LANE4 0x1caaU >> +#define PPI_RW_HSDCOCAL_CFG_O 0x1d00U >> +#define PPI_RW_HSDCOCAL_CFG_1 0x1d02U >> +#define PPI_RW_HSDCOCAL_CFG_2 0x1d04U >> +#define PPI_RW_HSDCOCAL_CFG_3 0x1d06U >> +#define PPI_RW_HSDCOCAL_CFG_4 0x1d08U >> +#define PPI_RW_HSDCOCAL_CFG_5 0x1d0aU >> +#define PPI_RW_HSDCOCAL_CFG_6 0x1d0cU >> +#define PPI_RW_HSDCOCAL_CFG_7 0x1d0eU >> +#define PPI_RW_HSDCOCAL_CFG_8 0x1d10U >> +#define PPI_R_HSDCOCAL_DEBUG_RB 0x1d12U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_0 0x2000U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_1 0x2002U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_2 0x2004U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_3 0x2006U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_4 0x2008U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_5 0x200aU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_6 0x200cU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_7 0x200eU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE0_OVR_0_8 0x2010U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_9 0x2012U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_10 0x2014U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_11 0x2016U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_12 0x2018U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_13 0x201aU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_14 0x201cU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE0_OVR_0_15 0x201eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_0 0x2020U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_1 0x2022U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_2 0x2024U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_3 0x2026U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_4 0x2028U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_5 0x202aU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_6 0x202cU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_7 0x202eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_8 0x2030U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_1_9 0x2032U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_10 0x2034U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_11 0x2036U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_12 0x2038U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_13 0x203aU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_14 0x203cU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_1_15 0x203eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_0 0x2040U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_1 0x2042U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_2 0x2044U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_3 0x2046U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_4 0x2048U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_5 0x204aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_6 0x204cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_7 0x204eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_8 0x2050U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_9 0x2052U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_10 0x2054U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_11 0x2056U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_12 0x2058U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_13 0x205aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_14 0x205cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_2_15 0x205eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_0 0x2060U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_1 0x2062U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_2 0x2064U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_3 0x2066U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_4 0x2068U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_5 0x206aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_6 0x206cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE0_CTRL_3_7 0x206eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_8 0x2070U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_9 0x2072U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_10 0x2074U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_11 0x2076U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_12 0x2078U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_13 0x207aU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_14 0x207cU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_3_15 0x207eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_4_0 0x2080U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_4_1 0x2082U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_4_2 0x2084U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_4_3 0x2086U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE0_CTRL_4_4 0x2088U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_5_0 0x20a0U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_5_1 0x20a2U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_5_2 0x20a4U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE0_OVR_5_3 0x20a6U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE0_OVR_5_4 0x20a8U >> +#define CORE_DIG_RW_TRIO0_0 0x2100U >> +#define CORE_DIG_RW_TRIO0_1 0x2102U >> +#define CORE_DIG_RW_TRIO0_2 0x2104U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_0 0x2400U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_1 0x2402U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_2 0x2404U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_3 0x2406U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_4 0x2408U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_5 0x240aU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_6 0x240cU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_7 0x240eU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE1_OVR_0_8 0x2410U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_9 0x2412U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_10 0x2414U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_11 0x2416U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_12 0x2418U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_13 0x241aU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_14 0x241cU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE1_OVR_0_15 0x241eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_0 0x2420U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_1 0x2422U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_2 0x2424U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_3 0x2426U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_4 0x2428U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_5 0x242aU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_6 0x242cU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_7 0x242eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_8 0x2430U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_1_9 0x2432U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_10 0x2434U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_11 0x2436U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_12 0x2438U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_13 0x243aU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_14 0x243cU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_1_15 0x243eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_0 0x2440U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_1 0x2442U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_2 0x2444U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_3 0x2446U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_4 0x2448U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_5 0x244aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_6 0x244cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_7 0x244eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_8 0x2450U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_9 0x2452U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_10 0x2454U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_11 0x2456U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_12 0x2458U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_13 0x245aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_14 0x245cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_2_15 0x245eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_0 0x2460U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_1 0x2462U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_2 0x2464U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_3 0x2466U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_4 0x2468U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_5 0x246aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_6 0x246cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE1_CTRL_3_7 0x246eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_8 0x2470U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_9 0x2472U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_10 0x2474U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_11 0x2476U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_12 0x2478U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_13 0x247aU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_14 0x247cU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_3_15 0x247eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_4_0 0x2480U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_4_1 0x2482U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_4_2 0x2484U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_4_3 0x2486U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE1_CTRL_4_4 0x2488U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_5_0 0x24a0U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_5_1 0x24a2U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_5_2 0x24a4U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE1_OVR_5_3 0x24a6U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE1_OVR_5_4 0x24a8U >> +#define CORE_DIG_RW_TRIO1_0 0x2500U >> +#define CORE_DIG_RW_TRIO1_1 0x2502U >> +#define CORE_DIG_RW_TRIO1_2 0x2504U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_0 0x2800U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_1 0x2802U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_2 0x2804U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_3 0x2806U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_4 0x2808U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_5 0x280aU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_6 0x280cU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_7 0x280eU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE2_OVR_0_8 0x2810U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_9 0x2812U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_10 0x2814U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_11 0x2816U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_12 0x2818U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_13 0x281aU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_14 0x281cU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE2_OVR_0_15 0x281eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_0 0x2820U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_1 0x2822U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_2 0x2824U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_3 0x2826U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_4 0x2828U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_5 0x282aU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_6 0x282cU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_7 0x282eU >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_8 0x2830U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_1_9 0x2832U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_10 0x2834U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_11 0x2836U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_12 0x2838U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_13 0x283aU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_14 0x283cU >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_1_15 0x283eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_0 0x2840U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_1 0x2842U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_2 0x2844U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_3 0x2846U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_4 0x2848U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_5 0x284aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_6 0x284cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_7 0x284eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_8 0x2850U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_9 0x2852U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_10 0x2854U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_11 0x2856U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_12 0x2858U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_13 0x285aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_14 0x285cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_2_15 0x285eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_0 0x2860U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_1 0x2862U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_2 0x2864U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_3 0x2866U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_4 0x2868U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_5 0x286aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_6 0x286cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE2_CTRL_3_7 0x286eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_8 0x2870U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_9 0x2872U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_10 0x2874U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_11 0x2876U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_12 0x2878U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_13 0x287aU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_14 0x287cU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_3_15 0x287eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_4_0 0x2880U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_4_1 0x2882U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_4_2 0x2884U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_4_3 0x2886U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE2_CTRL_4_4 0x2888U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_5_0 0x28a0U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_5_1 0x28a2U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_5_2 0x28a4U >> +#define CORE_DIG_IOCTRL_RW_CPHY_PPI_LANE2_OVR_5_3 0x28a6U >> +#define CORE_DIG_IOCTRL_R_CPHY_PPI_LANE2_OVR_5_4 0x28a8U >> +#define CORE_DIG_RW_TRIO2_0 0x2900U >> +#define CORE_DIG_RW_TRIO2_1 0x2902U >> +#define CORE_DIG_RW_TRIO2_2 0x2904U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_0 0x2c00U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_1 0x2c02U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_2 0x2c04U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_3 0x2c06U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_4 0x2c08U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_5 0x2c0aU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_6 0x2c0cU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_7 0x2c0eU >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_LANE3_OVR_0_8 0x2c10U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_9 0x2c12U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_10 0x2c14U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_11 0x2c16U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_12 0x2c18U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_13 0x2c1aU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_14 0x2c1cU >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_LANE3_OVR_0_15 0x2c1eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_0 0x2c40U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_1 0x2c42U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_2 0x2c44U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_3 0x2c46U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_4 0x2c48U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_5 0x2c4aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_6 0x2c4cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_7 0x2c4eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_8 0x2c50U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_9 0x2c52U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_10 0x2c54U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_11 0x2c56U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_12 0x2c58U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_13 0x2c5aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_14 0x2c5cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_2_15 0x2c5eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_0 0x2c60U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_1 0x2c62U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_2 0x2c64U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_3 0x2c66U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_4 0x2c68U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_5 0x2c6aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_6 0x2c6cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE3_CTRL_3_7 0x2c6eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_8 0x2c70U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_9 0x2c72U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_10 0x2c74U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_11 0x2c76U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_12 0x2c78U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_13 0x2c7aU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_14 0x2c7cU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_3_15 0x2c7eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_4_0 0x2c80U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_4_1 0x2c82U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_4_2 0x2c84U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_4_3 0x2c86U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE3_CTRL_4_4 0x2c88U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_0 0x3040U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_1 0x3042U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_2 0x3044U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_3 0x3046U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_4 0x3048U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_5 0x304aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_6 0x304cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_7 0x304eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_8 0x3050U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_9 0x3052U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_10 0x3054U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_11 0x3056U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_12 0x3058U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_13 0x305aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_14 0x305cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_2_15 0x305eU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_0 0x3060U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_1 0x3062U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_2 0x3064U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_3 0x3066U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_4 0x3068U >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_5 0x306aU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_6 0x306cU >> +#define CORE_DIG_IOCTRL_RW_AFE_LANE4_CTRL_3_7 0x306eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_8 0x3070U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_9 0x3072U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_10 0x3074U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_11 0x3076U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_12 0x3078U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_13 0x307aU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_14 0x307cU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_3_15 0x307eU >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_4_0 0x3080U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_4_1 0x3082U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_4_2 0x3084U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_4_3 0x3086U >> +#define CORE_DIG_IOCTRL_R_AFE_LANE4_CTRL_4_4 0x3088U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_CLK_OVR_0_0 0x3400U >> +#define CORE_DIG_IOCTRL_RW_DPHY_PPI_CLK_OVR_0_1 0x3402U >> +#define CORE_DIG_IOCTRL_R_DPHY_PPI_CLK_OVR_0_2 0x3404U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_0 0x3800U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_1 0x3802U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_2 0x3804U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_3 0x3806U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_4 0x3808U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_5 0x380aU >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_6 0x380cU >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_7 0x380eU >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_8 0x3810U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_9 0x3812U >> +#define CORE_DIG_IOCTRL_RW_COMMON_PPI_OVR_0_10 0x3814U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_0_11 0x3816U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_0_12 0x3818U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_0_13 0x381aU >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_0_14 0x381cU >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_0_15 0x381eU >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_1_0 0x3820U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_1_1 0x3822U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_1_2 0x3824U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_1_3 0x3826U >> +#define CORE_DIG_IOCTRL_R_COMMON_PPI_OVR_1_4 0x3828U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_0 0x3840U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_1 0x3842U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_2 0x3844U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_3 0x3846U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_4 0x3848U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_5 0x384aU >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_6 0x384cU >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_7 0x384eU >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_8 0x3850U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_9 0x3852U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_10 0x3854U >> +#define CORE_DIG_IOCTRL_RW_AFE_CB_CTRL_2_11 0x3856U >> +#define CORE_DIG_IOCTRL_R_AFE_CB_CTRL_2_12 0x3858U >> +#define CORE_DIG_IOCTRL_R_AFE_CB_CTRL_2_13 0x385aU >> +#define CORE_DIG_IOCTRL_R_AFE_CB_CTRL_2_14 0x385cU >> +#define CORE_DIG_IOCTRL_R_AFE_CB_CTRL_2_15 0x385eU >> +#define CORE_DIG_IOCTRL_R_AFE_CB_CTRL_3_0 0x3860U >> +#define CORE_DIG_RW_COMMON_0 0x3880U >> +#define CORE_DIG_RW_COMMON_1 0x3882U >> +#define CORE_DIG_RW_COMMON_2 0x3884U >> +#define CORE_DIG_RW_COMMON_3 0x3886U >> +#define CORE_DIG_RW_COMMON_4 0x3888U >> +#define CORE_DIG_RW_COMMON_5 0x388aU >> +#define CORE_DIG_RW_COMMON_6 0x388cU >> +#define CORE_DIG_RW_COMMON_7 0x388eU >> +#define CORE_DIG_RW_COMMON_8 0x3890U >> +#define CORE_DIG_RW_COMMON_9 0x3892U >> +#define CORE_DIG_RW_COMMON_10 0x3894U >> +#define CORE_DIG_RW_COMMON_11 0x3896U >> +#define CORE_DIG_RW_COMMON_12 0x3898U >> +#define CORE_DIG_RW_COMMON_13 0x389aU >> +#define CORE_DIG_RW_COMMON_14 0x389cU >> +#define CORE_DIG_RW_COMMON_15 0x389eU >> +#define CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_0 0x39e0U >> +#define CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_1 0x39e2U >> +#define CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_2 0x39e4U >> +#define CORE_DIG_ANACTRL_RW_COMMON_ANACTRL_3 0x39e6U >> +#define CORE_DIG_COMMON_RW_DESKEW_FINE_MEM 0x3fe0U >> +#define CORE_DIG_COMMON_R_DESKEW_FINE_MEM 0x3fe2U >> +#define PPI_RW_DPHY_LANE0_LBERT_0 0x4000U >> +#define PPI_RW_DPHY_LANE0_LBERT_1 0x4002U >> +#define PPI_R_DPHY_LANE0_LBERT_0 0x4004U >> +#define PPI_R_DPHY_LANE0_LBERT_1 0x4006U >> +#define PPI_RW_DPHY_LANE0_SPARE 0x4008U >> +#define PPI_RW_DPHY_LANE1_LBERT_0 0x4400U >> +#define PPI_RW_DPHY_LANE1_LBERT_1 0x4402U >> +#define PPI_R_DPHY_LANE1_LBERT_0 0x4404U >> +#define PPI_R_DPHY_LANE1_LBERT_1 0x4406U >> +#define PPI_RW_DPHY_LANE1_SPARE 0x4408U >> +#define PPI_RW_DPHY_LANE2_LBERT_0 0x4800U >> +#define PPI_RW_DPHY_LANE2_LBERT_1 0x4802U >> +#define PPI_R_DPHY_LANE2_LBERT_0 0x4804U >> +#define PPI_R_DPHY_LANE2_LBERT_1 0x4806U >> +#define PPI_RW_DPHY_LANE2_SPARE 0x4808U >> +#define PPI_RW_DPHY_LANE3_LBERT_0 0x4c00U >> +#define PPI_RW_DPHY_LANE3_LBERT_1 0x4c02U >> +#define PPI_R_DPHY_LANE3_LBERT_0 0x4c04U >> +#define PPI_R_DPHY_LANE3_LBERT_1 0x4c06U >> +#define PPI_RW_DPHY_LANE3_SPARE 0x4c08U > > How about using base address for lanes and then using offsets? I presume > all lanes use same offset? > > Same for CLANE definitions below. > I copied these defines directly from the SNPS spec register list, it is useful to query and compare with the spec. >> +#define CORE_DIG_DLANE_0_RW_CFG_0 0x6000U >> +#define CORE_DIG_DLANE_0_RW_CFG_1 0x6002U >> +#define CORE_DIG_DLANE_0_RW_CFG_2 0x6004U >> +#define CORE_DIG_DLANE_0_RW_LP_0 0x6080U >> +#define CORE_DIG_DLANE_0_RW_LP_1 0x6082U >> +#define CORE_DIG_DLANE_0_RW_LP_2 0x6084U >> +#define CORE_DIG_DLANE_0_R_LP_0 0x60a0U >> +#define CORE_DIG_DLANE_0_R_LP_1 0x60a2U >> +#define CORE_DIG_DLANE_0_R_HS_TX_0 0x60e0U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_0 0x6100U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_1 0x6102U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_2 0x6104U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_3 0x6106U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_4 0x6108U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_5 0x610aU >> +#define CORE_DIG_DLANE_0_RW_HS_RX_6 0x610cU >> +#define CORE_DIG_DLANE_0_RW_HS_RX_7 0x610eU >> +#define CORE_DIG_DLANE_0_RW_HS_RX_8 0x6110U >> +#define CORE_DIG_DLANE_0_RW_HS_RX_9 0x6112U >> +#define CORE_DIG_DLANE_0_R_HS_RX_0 0x6120U >> +#define CORE_DIG_DLANE_0_R_HS_RX_1 0x6122U >> +#define CORE_DIG_DLANE_0_R_HS_RX_2 0x6124U >> +#define CORE_DIG_DLANE_0_R_HS_RX_3 0x6126U >> +#define CORE_DIG_DLANE_0_R_HS_RX_4 0x6128U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_0 0x6200U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_1 0x6202U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_2 0x6204U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_3 0x6206U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_4 0x6208U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_5 0x620aU >> +#define CORE_DIG_DLANE_0_RW_HS_TX_6 0x620cU >> +#define CORE_DIG_DLANE_0_RW_HS_TX_7 0x620eU >> +#define CORE_DIG_DLANE_0_RW_HS_TX_8 0x6210U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_9 0x6212U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_10 0x6214U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_11 0x6216U >> +#define CORE_DIG_DLANE_0_RW_HS_TX_12 0x6218U >> +#define CORE_DIG_DLANE_1_RW_CFG_0 0x6400U >> +#define CORE_DIG_DLANE_1_RW_CFG_1 0x6402U >> +#define CORE_DIG_DLANE_1_RW_CFG_2 0x6404U >> +#define CORE_DIG_DLANE_1_RW_LP_0 0x6480U >> +#define CORE_DIG_DLANE_1_RW_LP_1 0x6482U >> +#define CORE_DIG_DLANE_1_RW_LP_2 0x6484U >> +#define CORE_DIG_DLANE_1_R_LP_0 0x64a0U >> +#define CORE_DIG_DLANE_1_R_LP_1 0x64a2U >> +#define CORE_DIG_DLANE_1_R_HS_TX_0 0x64e0U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_0 0x6500U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_1 0x6502U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_2 0x6504U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_3 0x6506U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_4 0x6508U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_5 0x650aU >> +#define CORE_DIG_DLANE_1_RW_HS_RX_6 0x650cU >> +#define CORE_DIG_DLANE_1_RW_HS_RX_7 0x650eU >> +#define CORE_DIG_DLANE_1_RW_HS_RX_8 0x6510U >> +#define CORE_DIG_DLANE_1_RW_HS_RX_9 0x6512U >> +#define CORE_DIG_DLANE_1_R_HS_RX_0 0x6520U >> +#define CORE_DIG_DLANE_1_R_HS_RX_1 0x6522U >> +#define CORE_DIG_DLANE_1_R_HS_RX_2 0x6524U >> +#define CORE_DIG_DLANE_1_R_HS_RX_3 0x6526U >> +#define CORE_DIG_DLANE_1_R_HS_RX_4 0x6528U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_0 0x6600U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_1 0x6602U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_2 0x6604U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_3 0x6606U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_4 0x6608U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_5 0x660aU >> +#define CORE_DIG_DLANE_1_RW_HS_TX_6 0x660cU >> +#define CORE_DIG_DLANE_1_RW_HS_TX_7 0x660eU >> +#define CORE_DIG_DLANE_1_RW_HS_TX_8 0x6610U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_9 0x6612U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_10 0x6614U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_11 0x6616U >> +#define CORE_DIG_DLANE_1_RW_HS_TX_12 0x6618U >> +#define CORE_DIG_DLANE_2_RW_CFG_0 0x6800U >> +#define CORE_DIG_DLANE_2_RW_CFG_1 0x6802U >> +#define CORE_DIG_DLANE_2_RW_CFG_2 0x6804U >> +#define CORE_DIG_DLANE_2_RW_LP_0 0x6880U >> +#define CORE_DIG_DLANE_2_RW_LP_1 0x6882U >> +#define CORE_DIG_DLANE_2_RW_LP_2 0x6884U >> +#define CORE_DIG_DLANE_2_R_LP_0 0x68a0U >> +#define CORE_DIG_DLANE_2_R_LP_1 0x68a2U >> +#define CORE_DIG_DLANE_2_R_HS_TX_0 0x68e0U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_0 0x6900U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_1 0x6902U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_2 0x6904U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_3 0x6906U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_4 0x6908U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_5 0x690aU >> +#define CORE_DIG_DLANE_2_RW_HS_RX_6 0x690cU >> +#define CORE_DIG_DLANE_2_RW_HS_RX_7 0x690eU >> +#define CORE_DIG_DLANE_2_RW_HS_RX_8 0x6910U >> +#define CORE_DIG_DLANE_2_RW_HS_RX_9 0x6912U >> +#define CORE_DIG_DLANE_2_R_HS_RX_0 0x6920U >> +#define CORE_DIG_DLANE_2_R_HS_RX_1 0x6922U >> +#define CORE_DIG_DLANE_2_R_HS_RX_2 0x6924U >> +#define CORE_DIG_DLANE_2_R_HS_RX_3 0x6926U >> +#define CORE_DIG_DLANE_2_R_HS_RX_4 0x6928U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_0 0x6a00U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_1 0x6a02U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_2 0x6a04U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_3 0x6a06U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_4 0x6a08U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_5 0x6a0aU >> +#define CORE_DIG_DLANE_2_RW_HS_TX_6 0x6a0cU >> +#define CORE_DIG_DLANE_2_RW_HS_TX_7 0x6a0eU >> +#define CORE_DIG_DLANE_2_RW_HS_TX_8 0x6a10U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_9 0x6a12U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_10 0x6a14U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_11 0x6a16U >> +#define CORE_DIG_DLANE_2_RW_HS_TX_12 0x6a18U >> +#define CORE_DIG_DLANE_3_RW_CFG_0 0x6c00U >> +#define CORE_DIG_DLANE_3_RW_CFG_1 0x6c02U >> +#define CORE_DIG_DLANE_3_RW_CFG_2 0x6c04U >> +#define CORE_DIG_DLANE_3_RW_LP_0 0x6c80U >> +#define CORE_DIG_DLANE_3_RW_LP_1 0x6c82U >> +#define CORE_DIG_DLANE_3_RW_LP_2 0x6c84U >> +#define CORE_DIG_DLANE_3_R_LP_0 0x6ca0U >> +#define CORE_DIG_DLANE_3_R_LP_1 0x6ca2U >> +#define CORE_DIG_DLANE_3_R_HS_TX_0 0x6ce0U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_0 0x6d00U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_1 0x6d02U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_2 0x6d04U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_3 0x6d06U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_4 0x6d08U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_5 0x6d0aU >> +#define CORE_DIG_DLANE_3_RW_HS_RX_6 0x6d0cU >> +#define CORE_DIG_DLANE_3_RW_HS_RX_7 0x6d0eU >> +#define CORE_DIG_DLANE_3_RW_HS_RX_8 0x6d10U >> +#define CORE_DIG_DLANE_3_RW_HS_RX_9 0x6d12U >> +#define CORE_DIG_DLANE_3_R_HS_RX_0 0x6d20U >> +#define CORE_DIG_DLANE_3_R_HS_RX_1 0x6d22U >> +#define CORE_DIG_DLANE_3_R_HS_RX_2 0x6d24U >> +#define CORE_DIG_DLANE_3_R_HS_RX_3 0x6d26U >> +#define CORE_DIG_DLANE_3_R_HS_RX_4 0x6d28U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_0 0x6e00U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_1 0x6e02U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_2 0x6e04U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_3 0x6e06U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_4 0x6e08U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_5 0x6e0aU >> +#define CORE_DIG_DLANE_3_RW_HS_TX_6 0x6e0cU >> +#define CORE_DIG_DLANE_3_RW_HS_TX_7 0x6e0eU >> +#define CORE_DIG_DLANE_3_RW_HS_TX_8 0x6e10U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_9 0x6e12U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_10 0x6e14U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_11 0x6e16U >> +#define CORE_DIG_DLANE_3_RW_HS_TX_12 0x6e18U >> +#define CORE_DIG_DLANE_CLK_RW_CFG_0 0x7000U >> +#define CORE_DIG_DLANE_CLK_RW_CFG_1 0x7002U >> +#define CORE_DIG_DLANE_CLK_RW_CFG_2 0x7004U >> +#define CORE_DIG_DLANE_CLK_RW_LP_0 0x7080U >> +#define CORE_DIG_DLANE_CLK_RW_LP_1 0x7082U >> +#define CORE_DIG_DLANE_CLK_RW_LP_2 0x7084U >> +#define CORE_DIG_DLANE_CLK_R_LP_0 0x70a0U >> +#define CORE_DIG_DLANE_CLK_R_LP_1 0x70a2U >> +#define CORE_DIG_DLANE_CLK_R_HS_TX_0 0x70e0U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_0 0x7100U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_1 0x7102U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_2 0x7104U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_3 0x7106U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_4 0x7108U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_5 0x710aU >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_6 0x710cU >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_7 0x710eU >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_8 0x7110U >> +#define CORE_DIG_DLANE_CLK_RW_HS_RX_9 0x7112U >> +#define CORE_DIG_DLANE_CLK_R_HS_RX_0 0x7120U >> +#define CORE_DIG_DLANE_CLK_R_HS_RX_1 0x7122U >> +#define CORE_DIG_DLANE_CLK_R_HS_RX_2 0x7124U >> +#define CORE_DIG_DLANE_CLK_R_HS_RX_3 0x7126U >> +#define CORE_DIG_DLANE_CLK_R_HS_RX_4 0x7128U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_0 0x7200U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_1 0x7202U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_2 0x7204U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_3 0x7206U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_4 0x7208U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_5 0x720aU >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_6 0x720cU >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_7 0x720eU >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_8 0x7210U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_9 0x7212U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_10 0x7214U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_11 0x7216U >> +#define CORE_DIG_DLANE_CLK_RW_HS_TX_12 0x7218U >> +#define PPI_RW_CPHY_TRIO0_LBERT_0 0x8000U >> +#define PPI_RW_CPHY_TRIO0_LBERT_1 0x8002U >> +#define PPI_R_CPHY_TRIO0_LBERT_0 0x8004U >> +#define PPI_R_CPHY_TRIO0_LBERT_1 0x8006U >> +#define PPI_RW_CPHY_TRIO0_SPARE 0x8008U >> +#define PPI_RW_CPHY_TRIO1_LBERT_0 0x8400U >> +#define PPI_RW_CPHY_TRIO1_LBERT_1 0x8402U >> +#define PPI_R_CPHY_TRIO1_LBERT_0 0x8404U >> +#define PPI_R_CPHY_TRIO1_LBERT_1 0x8406U >> +#define PPI_RW_CPHY_TRIO1_SPARE 0x8408U >> +#define PPI_RW_CPHY_TRIO2_LBERT_0 0x8800U >> +#define PPI_RW_CPHY_TRIO2_LBERT_1 0x8802U >> +#define PPI_R_CPHY_TRIO2_LBERT_0 0x8804U >> +#define PPI_R_CPHY_TRIO2_LBERT_1 0x8806U >> +#define PPI_RW_CPHY_TRIO2_SPARE 0x8808U >> +#define CORE_DIG_CLANE_0_RW_CFG_0 0xa000U >> +#define CORE_DIG_CLANE_0_RW_CFG_2 0xa004U >> +#define CORE_DIG_CLANE_0_RW_LP_0 0xa080U >> +#define CORE_DIG_CLANE_0_RW_LP_1 0xa082U >> +#define CORE_DIG_CLANE_0_RW_LP_2 0xa084U >> +#define CORE_DIG_CLANE_0_R_LP_0 0xa0a0U >> +#define CORE_DIG_CLANE_0_R_LP_1 0xa0a2U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_0 0xa100U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_1 0xa102U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_2 0xa104U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_3 0xa106U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_4 0xa108U >> +#define CORE_DIG_CLANE_0_RW_HS_RX_5 0xa10aU >> +#define CORE_DIG_CLANE_0_RW_HS_RX_6 0xa10cU >> +#define CORE_DIG_CLANE_0_R_RX_0 0xa120U >> +#define CORE_DIG_CLANE_0_R_RX_1 0xa122U >> +#define CORE_DIG_CLANE_0_R_TX_0 0xa124U >> +#define CORE_DIG_CLANE_0_R_RX_2 0xa126U >> +#define CORE_DIG_CLANE_0_R_RX_3 0xa128U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_0 0xa200U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_1 0xa202U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_2 0xa204U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_3 0xa206U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_4 0xa208U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_5 0xa20aU >> +#define CORE_DIG_CLANE_0_RW_HS_TX_6 0xa20cU >> +#define CORE_DIG_CLANE_0_RW_HS_TX_7 0xa20eU >> +#define CORE_DIG_CLANE_0_RW_HS_TX_8 0xa210U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_9 0xa212U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_10 0xa214U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_11 0xa216U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_12 0xa218U >> +#define CORE_DIG_CLANE_0_RW_HS_TX_13 0xa21aU >> +#define CORE_DIG_CLANE_1_RW_CFG_0 0xa400U >> +#define CORE_DIG_CLANE_1_RW_CFG_2 0xa404U >> +#define CORE_DIG_CLANE_1_RW_LP_0 0xa480U >> +#define CORE_DIG_CLANE_1_RW_LP_1 0xa482U >> +#define CORE_DIG_CLANE_1_RW_LP_2 0xa484U >> +#define CORE_DIG_CLANE_1_R_LP_0 0xa4a0U >> +#define CORE_DIG_CLANE_1_R_LP_1 0xa4a2U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_0 0xa500U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_1 0xa502U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_2 0xa504U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_3 0xa506U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_4 0xa508U >> +#define CORE_DIG_CLANE_1_RW_HS_RX_5 0xa50aU >> +#define CORE_DIG_CLANE_1_RW_HS_RX_6 0xa50cU >> +#define CORE_DIG_CLANE_1_R_RX_0 0xa520U >> +#define CORE_DIG_CLANE_1_R_RX_1 0xa522U >> +#define CORE_DIG_CLANE_1_R_TX_0 0xa524U >> +#define CORE_DIG_CLANE_1_R_RX_2 0xa526U >> +#define CORE_DIG_CLANE_1_R_RX_3 0xa528U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_0 0xa600U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_1 0xa602U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_2 0xa604U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_3 0xa606U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_4 0xa608U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_5 0xa60aU >> +#define CORE_DIG_CLANE_1_RW_HS_TX_6 0xa60cU >> +#define CORE_DIG_CLANE_1_RW_HS_TX_7 0xa60eU >> +#define CORE_DIG_CLANE_1_RW_HS_TX_8 0xa610U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_9 0xa612U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_10 0xa614U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_11 0xa616U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_12 0xa618U >> +#define CORE_DIG_CLANE_1_RW_HS_TX_13 0xa61aU >> +#define CORE_DIG_CLANE_2_RW_CFG_0 0xa800U >> +#define CORE_DIG_CLANE_2_RW_CFG_2 0xa804U >> +#define CORE_DIG_CLANE_2_RW_LP_0 0xa880U >> +#define CORE_DIG_CLANE_2_RW_LP_1 0xa882U >> +#define CORE_DIG_CLANE_2_RW_LP_2 0xa884U >> +#define CORE_DIG_CLANE_2_R_LP_0 0xa8a0U >> +#define CORE_DIG_CLANE_2_R_LP_1 0xa8a2U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_0 0xa900U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_1 0xa902U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_2 0xa904U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_3 0xa906U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_4 0xa908U >> +#define CORE_DIG_CLANE_2_RW_HS_RX_5 0xa90aU >> +#define CORE_DIG_CLANE_2_RW_HS_RX_6 0xa90cU >> +#define CORE_DIG_CLANE_2_R_RX_0 0xa920U >> +#define CORE_DIG_CLANE_2_R_RX_1 0xa922U >> +#define CORE_DIG_CLANE_2_R_TX_0 0xa924U >> +#define CORE_DIG_CLANE_2_R_RX_2 0xa926U >> +#define CORE_DIG_CLANE_2_R_RX_3 0xa928U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_0 0xaa00U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_1 0xaa02U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_2 0xaa04U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_3 0xaa06U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_4 0xaa08U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_5 0xaa0aU >> +#define CORE_DIG_CLANE_2_RW_HS_TX_6 0xaa0cU >> +#define CORE_DIG_CLANE_2_RW_HS_TX_7 0xaa0eU >> +#define CORE_DIG_CLANE_2_RW_HS_TX_8 0xaa10U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_9 0xaa12U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_10 0xaa14U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_11 0xaa16U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_12 0xaa18U >> +#define CORE_DIG_CLANE_2_RW_HS_TX_13 0xaa1aU >> + >> +/* dwc csi host controller registers */ >> +#define IS_IO_CSI2_HOST_BASE(i) (IS_IO_BASE + 0x40000U + \ >> + 0x2000U * (i)) >> +#define VERSION 0 > > I wonder if this HCI has a version? Perhaps a driver on its own would be > nice, but that consideration can be left for later I think. > >> +#define N_LANES 0x4U >> +#define CSI2_RESETN 0x8U >> +#define INT_ST_MAIN 0xcU >> +#define DATA_IDS_1 0x10U >> +#define DATA_IDS_2 0x14U >> +#define CDPHY_MODE 0x1cU >> +#define DATA_IDS_VC_1 0x30U >> +#define DATA_IDS_VC_2 0x34U >> +#define PHY_SHUTDOWNZ 0x40U >> +#define DPHY_RSTZ 0x44U >> +#define PHY_RX 0x48U >> +#define PHY_STOPSTATE 0x4cU >> +#define PHY_TEST_CTRL0 0x50U >> +#define PHY_TEST_CTRL1 0x54U >> +#define PPI_PG_PATTERN_VRES 0x60U >> +#define PPI_PG_PATTERN_HRES 0x64U >> +#define PPI_PG_CONFIG 0x68U >> +#define PPI_PG_ENABLE 0x6cU >> +#define PPI_PG_STATUS 0x70U >> +#define VC_EXTENSION 0xc8U >> +#define PHY_CAL 0xccU >> +#define INT_ST_PHY_FATAL 0xe0U >> +#define INT_MSK_PHY_FATAL 0xe4U >> +#define INT_FORCE_PHY_FATAL 0xe8U >> +#define INT_ST_PKT_FATAL 0xf0U >> +#define INT_MSK_PKT_FATAL 0xf4U >> +#define INT_FORCE_PKT_FATAL 0xf8U >> +#define INT_ST_PHY 0x110U >> +#define INT_MSK_PHY 0x114U >> +#define INT_FORCE_PHY 0x118U >> +#define INT_ST_LINE 0x130U >> +#define INT_MSK_LINE 0x134U >> +#define INT_FORCE_LINE 0x138U >> +#define INT_ST_BNDRY_FRAME_FATAL 0x280U >> +#define INT_MSK_BNDRY_FRAME_FATAL 0x284U >> +#define INT_FORCE_BNDRY_FRAME_FATAL 0x288U >> +#define INT_ST_SEQ_FRAME_FATAL 0x290U >> +#define INT_MSK_SEQ_FRAME_FATAL 0x294U >> +#define INT_FORCE_SEQ_FRAME_FATAL 0x298U >> +#define INT_ST_CRC_FRAME_FATAL 0x2a0U >> +#define INT_MSK_CRC_FRAME_FATAL 0x2a4U >> +#define INT_FORCE_CRC_FRAME_FATAL 0x2a8U >> +#define INT_ST_PLD_CRC_FATAL 0x2b0U >> +#define INT_MSK_PLD_CRC_FATAL 0x2b4U >> +#define INT_FORCE_PLD_CRC_FATAL 0x2b8U >> +#define INT_ST_DATA_ID 0x2c0U >> +#define INT_MSK_DATA_ID 0x2c4U >> +#define INT_FORCE_DATA_ID 0x2c8U >> +#define INT_ST_ECC_CORRECTED 0x2d0U >> +#define INT_MSK_ECC_CORRECTED 0x2d4U >> +#define INT_FORCE_ECC_CORRECTED 0x2d8U >> +#define SCRAMBLING 0x300U >> +#define SCRAMBLING_SEED1 0x304U >> +#define SCRAMBLING_SEED2 0x308U >> +#define SCRAMBLING_SEED3 0x30cU >> +#define SCRAMBLING_SEED4 0x310U >> +#define SCRAMBLING 0x300U >> + >> +#define IS_IO_CSI2_ADPL_PORT_BASE(i) (IS_IO_BASE + 0x40800U + \ >> + 0x2000U * (i)) >> +#define CSI2_ADPL_INPUT_MODE 0 >> +#define CSI2_ADPL_CSI_RX_ERR_IRQ_CLEAR_EN 0x4U >> +#define CSI2_ADPL_CSI_RX_ERR_IRQ_CLEAR_ADDR 0x8U >> +#define CSI2_ADPL_CSI_RX_ERR_IRQ_STATUS 0xcU >> +#define CSI2_ADPL_IRQ_CTL_COMMON_STATUS 0xa4U >> +#define CSI2_ADPL_IRQ_CTL_COMMON_CLEAR 0xa8U >> +#define CSI2_ADPL_IRQ_CTL_COMMON_ENABLE 0xacU >> +#define CSI2_ADPL_IRQ_CTL_FS_STATUS 0xbcU >> +#define CSI2_ADPL_IRQ_CTL_FS_CLEAR 0xc0U >> +#define CSI2_ADPL_IRQ_CTL_FS_ENABLE 0xc4U >> +#define CSI2_ADPL_IRQ_CTL_FE_STATUS 0xc8U >> +#define CSI2_ADPL_IRQ_CTL_FE_CLEAR 0xccU >> +#define CSI2_ADPL_IRQ_CTL_FE_ENABLE 0xd0U >> + >> +/* software control the legacy csi irq */ >> +#define IS_IO_CSI2_ERR_LEGACY_IRQ_CTL_BASE(i) (IS_IO_BASE + 0x40c00U + \ >> + 0x2000U * (i)) >> +#define IS_IO_CSI2_SYNC_LEGACY_IRQ_CTL_BASE(i) (IS_IO_BASE + 0x40d00U + \ >> + 0x2000U * (i)) >> +#define IS_IO_CSI2_LEGACY_IRQ_CTRL_BASE (IS_IO_BASE + 0x49000U) >> +#define IS_IO_CSI2_IRQ_CTRL_BASE (IS_IO_BASE + 0x4e100) >> + >> +#define IRQ_CTL_EDGE 0 >> +#define IRQ_CTL_MASK 0x4U >> +#define IRQ_CTL_STATUS 0x8U >> +#define IRQ_CTL_CLEAR 0xcU >> +#define IRQ_CTL_ENABLE 0x10U >> +/* FE irq for PTL */ >> +#define IRQ1_CTL_MASK 0x14U >> +#define IRQ1_CTL_STATUS 0x18U >> +#define IRQ1_CTL_CLEAR 0x1cU >> +#define IRQ1_CTL_ENABLE 0x20U >> + >> +/* software to set the clock gate to use the port or mgc */ >> +#define IS_IO_GPREGS_BASE (IS_IO_BASE + 0x49200U) >> +#define SRST_PORT_ARB 0 >> +#define SRST_MGC 0x4U >> +#define SRST_WIDTH_CONV 0x8U >> +#define SRST_CSI_IRQ 0xcU >> +#define SRST_CSI_LEGACY_IRQ 0x10U >> +#define CLK_EN_TXCLKESC 0x14U >> +#define CLK_DIV_FACTOR_IS_CLK 0x18U >> +#define CLK_DIV_FACTOR_APB_CLK 0x1cU >> +#define CSI_PORT_CLK_GATE 0x20U >> +#define CSI_PORTAB_AGGREGATION 0x24U >> +#define MGC_CLK_GATE 0x2cU >> +#define CG_CTRL_BITS 0x3cU >> +#define SPARE_RW 0xf8U >> +#define SPARE_RO 0xfcU >> + >> +#define IS_IO_CSI2_MPF_PORT_BASE(i) (IS_IO_BASE + 0x53000U + \ >> + 0x1000U * (i)) >> +#define MPF_16_IRQ_CNTRL_STATUS 0x238U >> +#define MPF_16_IRQ_CNTRL_CLEAR 0x23cU >> +#define MPF_16_IRQ_CNTRL_ENABLE 0x240U >> + >> +/* software config the phy */ >> +#define IS_IO_CSI2_GPREGS_BASE (IS_IO_BASE + 0x53400U) >> +#define IPU8_IS_IO_CSI2_GPREGS_BASE (IS_IO_BASE + 0x40e00U) >> +#define CSI_ADAPT_LAYER_SRST 0 >> +#define MPF_SRST_RST 0x4U >> +#define CSI_ERR_IRQ_CTRL_SRST 0x8U >> +#define CSI_SYNC_RC_SRST 0xcU >> +#define CSI_CG_CTRL_BITS 0x10U >> +#define SOC_CSI2HOST_SELECT 0x14U >> +#define PHY_RESET 0x18U >> +#define PHY_SHUTDOWN 0x1cU >> +#define PHY_MODE 0x20U >> +#define PHY_READY 0x24U >> +#define PHY_CLK_LANE_FORCE_CONTROL 0x28U >> +#define PHY_CLK_LANE_CONTROL 0x2cU >> +#define PHY_CLK_LANE_STATUS 0x30U >> +#define PHY_LANE_RX_ESC_REQ 0x34U >> +#define PHY_LANE_RX_ESC_DATA 0x38U >> +#define PHY_LANE_TURNDISABLE 0x3cU >> +#define PHY_LANE_DIRECTION 0x40U >> +#define PHY_LANE_FORCE_CONTROL 0x44U >> +#define PHY_LANE_CONTROL_EN 0x48U >> +#define PHY_LANE_CONTROL_DATAWIDTH 0x4cU >> +#define PHY_LANE_STATUS 0x50U >> +#define PHY_LANE_ERR 0x54U >> +#define PHY_LANE_RXALP 0x58U >> +#define PHY_LANE_RXALP_NIBBLE 0x5cU >> +#define PHY_PARITY_ERROR 0x60U >> +#define PHY_DEBUG_REGS_CLK_GATE_EN 0x64U >> +#define SPARE_RW 0xf8U >> +#define SPARE_RO 0xfcU >> + >> +/* software not touch */ >> +#define PORT_ARB_BASE (IS_IO_BASE + 0x4e000) >> +#define PORT_ARB_IRQ_CTL_STATUS 0x4U >> +#define PORT_ARB_IRQ_CTL_CLEAR 0x8U >> +#define PORT_ARB_IRQ_CTL_ENABLE 0xcU >> + >> +#define MGC_PPC 4U >> +#define MGC_DTYPE_RAW(i) (((i) - 8) / 2) >> +#define IS_IO_MGC_BASE (IS_IO_BASE + 0x48000U) >> +#define MGC_KICK 0 >> +#define MGC_ASYNC_STOP 0x4U >> +#define MGC_PORT_OFFSET 0x100U >> +#define MGC_CSI_PORT_MAP(i) (0x8 + (i) * 0x4) >> +#define MGC_MG_PORT(i) (IS_IO_MGC_BASE + \ >> + (i) * MGC_PORT_OFFSET) >> +/* per mgc instance */ >> +#define MGC_MG_CSI_ADAPT_LAYER_TYPE 0x28U >> +#define MGC_MG_MODE 0x2cU >> +#define MGC_MG_INIT_COUNTER 0x30U >> +#define MGC_MG_MIPI_VC 0x34U >> +#define MGC_MG_MIPI_DTYPES 0x38U >> +#define MGC_MG_MULTI_DTYPES_MODE 0x3cU >> +#define MGC_MG_NOF_FRAMES 0x40U >> +#define MGC_MG_FRAME_DIM 0x44U >> +#define MGC_MG_HBLANK 0x48U >> +#define MGC_MG_VBLANK 0x4cU >> +#define MGC_MG_TPG_MODE 0x50U >> +#define MGC_MG_TPG_R0 0x54U >> +#define MGC_MG_TPG_G0 0x58U >> +#define MGC_MG_TPG_B0 0x5cU >> +#define MGC_MG_TPG_R1 0x60U >> +#define MGC_MG_TPG_G1 0x64U >> +#define MGC_MG_TPG_B1 0x68U >> +#define MGC_MG_TPG_FACTORS 0x6cU >> +#define MGC_MG_TPG_MASKS 0x70U >> +#define MGC_MG_TPG_XY_MASK 0x74U >> +#define MGC_MG_TPG_TILE_DIM 0x78U >> +#define MGC_MG_PRBS_LFSR_INIT_0 0x7cU >> +#define MGC_MG_PRBS_LFSR_INIT_1 0x80U >> +#define MGC_MG_SYNC_STOP_POINT 0x84U >> +#define MGC_MG_SYNC_STOP_POINT_LOC 0x88U >> +#define MGC_MG_ERR_INJECT 0x8cU >> +#define MGC_MG_ERR_LOCATION 0x90U >> +#define MGC_MG_DTO_SPEED_CTRL_EN 0x94U >> +#define MGC_MG_DTO_SPEED_CTRL_INCR_VAL 0x98U >> +#define MGC_MG_HOR_LOC_STTS 0x9cU >> +#define MGC_MG_VER_LOC_STTS 0xa0U >> +#define MGC_MG_FRAME_NUM_STTS 0xa4U >> +#define MGC_MG_BUSY_STTS 0xa8U >> +#define MGC_MG_STOPPED_STTS 0xacU >> +/* tile width and height in pixels for Chess board and Color palette */ >> +#define MGC_TPG_TILE_WIDTH 64U >> +#define MGC_TPG_TILE_HEIGHT 64U >> + >> +#define IPU_CSI_PORT_A_ADDR_OFFSET 0 >> +#define IPU_CSI_PORT_B_ADDR_OFFSET 0 >> +#define IPU_CSI_PORT_C_ADDR_OFFSET 0 >> +#define IPU_CSI_PORT_D_ADDR_OFFSET 0 > > All 0? Yes, the register offset here is actually useless. As the IPU7 ISYS registers are grouped by component instead of port number. offset = IS_IO_CSI2_ERR_LEGACY_IRQ_CTL_BASE(csi2->port); mask = IPU7_CSI_RX_ERROR_IRQ_MASK; writel(mask, csi2->base + offset + IRQ_CTL_CLEAR); But we still keep the defines to be compatible with IPU6. > >> + >> +/* >> + * 0 - CSI RX Port 0 interrupt; >> + * 1 - MPF Port 0 interrupt; >> + * 2 - CSI RX Port 1 interrupt; >> + * 3 - MPF Port 1 interrupt; >> + * 4 - CSI RX Port 2 interrupt; >> + * 5 - MPF Port 2 interrupt; >> + * 6 - CSI RX Port 3 interrupt; >> + * 7 - MPF Port 3 interrupt; >> + * 8 - Port ARB FIFO 0 overflow; >> + * 9 - Port ARB FIFO 1 overflow; >> + * 10 - Port ARB FIFO 2 overflow; >> + * 11 - Port ARB FIFO 3 overflow; >> + * 12 - isys_cfgnoc_err_probe_intl; >> + * 13-15 - reserved >> + */ >> +#define IPU7_CSI_IS_IO_IRQ_MASK 0xffffU >> + >> +/* Adapter layer irq */ >> +#define IPU7_CSI_ADPL_IRQ_MASK 0xffffU >> + >> +/* sw irq from legacy irq control > > /* > * > >> + * legacy irq status >> + * IPU7 >> + * 0 - CSI Port 0 error interrupt >> + * 1 - CSI Port 0 sync interrupt >> + * 2 - CSI Port 1 error interrupt >> + * 3 - CSI Port 1 sync interrupt >> + * 4 - CSI Port 2 error interrupt >> + * 5 - CSI Port 2 sync interrupt >> + * 6 - CSI Port 3 error interrupt >> + * 7 - CSI Port 3 sync interrupt >> + * IPU7P5 >> + * 0 - CSI Port 0 error interrupt >> + * 1 - CSI Port 0 fs interrupt >> + * 2 - CSI Port 0 fe interrupt >> + * 3 - CSI Port 1 error interrupt >> + * 4 - CSI Port 1 fs interrupt >> + * 5 - CSI Port 1 fe interrupt >> + * 6 - CSI Port 2 error interrupt >> + * 7 - CSI Port 2 fs interrupt >> + * 8 - CSI Port 2 fe interrupt >> + */ >> +#define IPU7_CSI_RX_LEGACY_IRQ_MASK 0x1ffU >> + >> +/* legacy error status per port >> + * 0 - Error handler FIFO full; >> + * 1 - Reserved Short Packet encoding detected; >> + * 2 - Reserved Long Packet encoding detected; >> + * 3 - Received packet is too short (fewer data words than specified in header); >> + * 4 - Received packet is too long (more data words than specified in header); >> + * 5 - Short packet discarded due to errors; >> + * 6 - Long packet discarded due to errors; >> + * 7 - CSI Combo Rx interrupt; >> + * 8 - IDI CDC FIFO overflow; remaining bits are reserved and tied to 0; >> + */ >> +#define IPU7_CSI_RX_ERROR_IRQ_MASK 0xfffU >> + >> +/* >> + * 0 - VC0 frame start received >> + * 1 - VC0 frame end received >> + * 2 - VC1 frame start received >> + * 3 - VC1 frame end received >> + * 4 - VC2 frame start received >> + * 5 - VC2 frame end received >> + * 6 - VC3 frame start received >> + * 7 - VC3 frame end received >> + * 8 - VC4 frame start received >> + * 9 - VC4 frame end received >> + * 10 - VC5 frame start received >> + * 11 - VC5 frame end received >> + * 12 - VC6 frame start received >> + * 13 - VC6 frame end received >> + * 14 - VC7 frame start received >> + * 15 - VC7 frame end received >> + * 16 - VC8 frame start received >> + * 17 - VC8 frame end received >> + * 18 - VC9 frame start received >> + * 19 - VC9 frame end received >> + * 20 - VC10 frame start received >> + * 21 - VC10 frame end received >> + * 22 - VC11 frame start received >> + * 23 - VC11 frame end received >> + * 24 - VC12 frame start received >> + * 25 - VC12 frame end received >> + * 26 - VC13 frame start received >> + * 27 - VC13 frame end received >> + * 28 - VC14 frame start received >> + * 29 - VC14 frame end received >> + * 30 - VC15 frame start received >> + * 31 - VC15 frame end received >> + */ >> + >> +#define IPU7_CSI_RX_SYNC_IRQ_MASK 0 /* 0xffffffff */ >> +#define IPU7P5_CSI_RX_SYNC_FE_IRQ_MASK 0 /* 0xffffffff */ >> + >> +#define CSI_RX_NUM_ERRORS_IN_IRQ 12U >> +#define CSI_RX_NUM_SYNC_IN_IRQ 32U >> + >> +enum CSI_FE_MODE_TYPE { >> + CSI_FE_DPHY_MODE = 0, >> + CSI_FE_CPHY_MODE = 1, >> +}; >> + >> +enum CSI_FE_INPUT_MODE { >> + CSI_SENSOR_INPUT = 0, >> + CSI_MIPIGEN_INPUT = 1, >> +}; >> + >> +enum MGC_CSI_ADPL_TYPE { >> + MGC_MAPPED_2_LANES = 0, >> + MGC_MAPPED_4_LANES = 1, >> +}; >> + >> +enum CSI2HOST_SELECTION { >> + CSI2HOST_SEL_SOC = 0, >> + CSI2HOST_SEL_CSI2HOST = 1, >> +}; >> + >> +#define IPU7_ISYS_LEGACY_IRQ_CSI2(port) (0x3U << (port)) >> +#define IPU7P5_ISYS_LEGACY_IRQ_CSI2(port) (0x7U << (port)) >> + >> +/* ---------------------------------------------------------------- */ >> +#define CSI_REG_BASE 0x220000U >> +#define CSI_REG_BASE_PORT(id) ((id) * 0x1000) >> + >> +/* CSI Port General Purpose Registers */ >> +#define CSI_REG_PORT_GPREG_SRST 0 >> +#define CSI_REG_PORT_GPREG_CSI2_SLV_REG_SRST 0x4U >> +#define CSI_REG_PORT_GPREG_CSI2_PORT_CONTROL 0x8U >> + >> +#define CSI_RX_NUM_IRQ 32U >> + >> +#define IPU7_CSI_RX_SYNC_FS_VC 0x55555555U >> +#define IPU7_CSI_RX_SYNC_FE_VC 0xaaaaaaaaU >> +#define IPU7P5_CSI_RX_SYNC_FS_VC 0xffffU >> +#define IPU7P5_CSI_RX_SYNC_FE_VC 0xffffU >> + >> +#endif /* IPU7_ISYS_CSI2_REG_H */ >> diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.c b/drivers/staging/media/ipu7/ipu7-isys-csi2.c >> new file mode 100644 >> index 000000000000..ae504fb41464 >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.c >> @@ -0,0 +1,542 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "ipu7.h" >> +#include "ipu7-bus.h" >> +#include "ipu7-isys.h" >> +#include "ipu7-isys-csi2.h" >> +#include "ipu7-isys-csi2-regs.h" >> +#include "ipu7-isys-csi-phy.h" >> + >> +static const u32 csi2_supported_codes[] = { >> + MEDIA_BUS_FMT_Y10_1X10, >> + MEDIA_BUS_FMT_RGB565_1X16, >> + MEDIA_BUS_FMT_RGB888_1X24, >> + MEDIA_BUS_FMT_UYVY8_1X16, >> + MEDIA_BUS_FMT_YUYV8_1X16, >> + MEDIA_BUS_FMT_YUYV10_1X20, >> + MEDIA_BUS_FMT_SBGGR10_1X10, >> + MEDIA_BUS_FMT_SGBRG10_1X10, >> + MEDIA_BUS_FMT_SGRBG10_1X10, >> + MEDIA_BUS_FMT_SRGGB10_1X10, >> + MEDIA_BUS_FMT_SBGGR12_1X12, >> + MEDIA_BUS_FMT_SGBRG12_1X12, >> + MEDIA_BUS_FMT_SGRBG12_1X12, >> + MEDIA_BUS_FMT_SRGGB12_1X12, >> + MEDIA_BUS_FMT_SBGGR8_1X8, >> + MEDIA_BUS_FMT_SGBRG8_1X8, >> + MEDIA_BUS_FMT_SGRBG8_1X8, >> + MEDIA_BUS_FMT_SRGGB8_1X8, >> + 0, >> +}; >> + >> +s64 ipu7_isys_csi2_get_link_freq(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct media_pad *src_pad; >> + >> + if (!csi2) > > Can this be NULL? This could be NULL if the caller call wrong CSI2 number(likely coding problem), but the check is harmless as it can be used to avoid crash later. > >> + return -EINVAL; >> + >> + src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity); >> + if (IS_ERR(src_pad)) { >> + dev_err(&csi2->isys->adev->auxdev.dev, >> + "can't get source pad of %s (%ld)\n", >> + csi2->asd.sd.name, PTR_ERR(src_pad)); >> + return PTR_ERR(src_pad); >> + } >> + >> + return v4l2_get_link_freq(src_pad, 0, 0); >> +} >> + >> +static int csi2_subscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh, >> + struct v4l2_event_subscription *sub) >> +{ >> + struct ipu7_isys_subdev *asd = to_ipu7_isys_subdev(sd); >> + struct ipu7_isys_csi2 *csi2 = to_ipu7_isys_csi2(asd); >> + struct device *dev = &csi2->isys->adev->auxdev.dev; >> + >> + dev_dbg(dev, "csi2 subscribe event(type %u id %u)\n", >> + sub->type, sub->id); >> + >> + switch (sub->type) { >> + case V4L2_EVENT_FRAME_SYNC: >> + return v4l2_event_subscribe(fh, sub, 10, NULL); >> + case V4L2_EVENT_CTRL: >> + return v4l2_ctrl_subscribe_event(fh, sub); >> + default: >> + return -EINVAL; >> + } >> +} >> + >> +static const struct v4l2_subdev_core_ops csi2_sd_core_ops = { >> + .subscribe_event = csi2_subscribe_event, >> + .unsubscribe_event = v4l2_event_subdev_unsubscribe, >> +}; >> + >> +static void csi2_irq_en(struct ipu7_isys_csi2 *csi2, bool enable) >> +{ >> + struct ipu7_device *isp = csi2->isys->adev->isp; >> + unsigned int offset, mask; >> + >> + if (!enable) { >> + /* disable CSI2 legacy error irq */ >> + offset = IS_IO_CSI2_ERR_LEGACY_IRQ_CTL_BASE(csi2->port); >> + mask = IPU7_CSI_RX_ERROR_IRQ_MASK; >> + writel(mask, csi2->base + offset + IRQ_CTL_CLEAR); >> + writel(0, csi2->base + offset + IRQ_CTL_MASK); >> + writel(0, csi2->base + offset + IRQ_CTL_ENABLE); >> + >> + /* disable CSI2 legacy sync irq */ >> + offset = IS_IO_CSI2_SYNC_LEGACY_IRQ_CTL_BASE(csi2->port); >> + mask = IPU7_CSI_RX_SYNC_IRQ_MASK; >> + writel(mask, csi2->base + offset + IRQ_CTL_CLEAR); >> + writel(0, csi2->base + offset + IRQ_CTL_MASK); >> + writel(0, csi2->base + offset + IRQ_CTL_ENABLE); >> + >> + if (!is_ipu7(isp->hw_ver)) { >> + writel(mask, csi2->base + offset + IRQ1_CTL_CLEAR); >> + writel(0, csi2->base + offset + IRQ1_CTL_MASK); >> + writel(0, csi2->base + offset + IRQ1_CTL_ENABLE); >> + } >> + >> + return; >> + } >> + >> + /* enable CSI2 legacy error irq */ >> + offset = IS_IO_CSI2_ERR_LEGACY_IRQ_CTL_BASE(csi2->port); >> + mask = IPU7_CSI_RX_ERROR_IRQ_MASK; >> + writel(mask, csi2->base + offset + IRQ_CTL_CLEAR); >> + writel(mask, csi2->base + offset + IRQ_CTL_MASK); >> + writel(mask, csi2->base + offset + IRQ_CTL_ENABLE); >> + >> + /* enable CSI2 legacy sync irq */ >> + offset = IS_IO_CSI2_SYNC_LEGACY_IRQ_CTL_BASE(csi2->port); >> + mask = IPU7_CSI_RX_SYNC_IRQ_MASK; >> + writel(mask, csi2->base + offset + IRQ_CTL_CLEAR); >> + writel(mask, csi2->base + offset + IRQ_CTL_MASK); >> + writel(mask, csi2->base + offset + IRQ_CTL_ENABLE); >> + >> + mask = IPU7P5_CSI_RX_SYNC_FE_IRQ_MASK; >> + if (!is_ipu7(isp->hw_ver)) { >> + writel(mask, csi2->base + offset + IRQ1_CTL_CLEAR); >> + writel(mask, csi2->base + offset + IRQ1_CTL_MASK); >> + writel(mask, csi2->base + offset + IRQ1_CTL_ENABLE); >> + } >> +} >> + >> +static void ipu7_isys_csi2_disable_stream(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + void __iomem *isys_base = isys->pdata->base; >> + >> + ipu7_isys_csi_phy_powerdown(csi2); >> + >> + writel(0x4, isys_base + IS_IO_GPREGS_BASE + CLK_DIV_FACTOR_APB_CLK); >> + csi2_irq_en(csi2, 0); >> +} >> + >> +static int ipu7_isys_csi2_enable_stream(struct ipu7_isys_csi2 *csi2) >> +{ >> + struct ipu7_isys *isys = csi2->isys; >> + struct device *dev = &isys->adev->auxdev.dev; >> + void __iomem *isys_base = isys->pdata->base; >> + unsigned int port, nlanes, offset; >> + int ret; >> + >> + port = csi2->port; >> + nlanes = csi2->nlanes; >> + >> + offset = IS_IO_GPREGS_BASE; >> + writel(0x2, isys_base + offset + CLK_DIV_FACTOR_APB_CLK); >> + dev_dbg(dev, "port %u CLK_GATE = 0x%04x DIV_FACTOR_APB_CLK=0x%04x\n", >> + port, readl(isys_base + offset + CSI_PORT_CLK_GATE), >> + readl(isys_base + offset + CLK_DIV_FACTOR_APB_CLK)); >> + if (port == 0U && nlanes == 4U && !is_ipu7(isys->adev->isp->hw_ver)) { >> + dev_dbg(dev, "CSI port %u in aggregation mode\n", port); >> + writel(0x1, isys_base + offset + CSI_PORTAB_AGGREGATION); >> + } >> + >> + /* input is coming from CSI receiver (sensor) */ >> + offset = IS_IO_CSI2_ADPL_PORT_BASE(port); >> + writel(CSI_SENSOR_INPUT, isys_base + offset + CSI2_ADPL_INPUT_MODE); >> + writel(1, isys_base + offset + CSI2_ADPL_CSI_RX_ERR_IRQ_CLEAR_EN); >> + >> + ret = ipu7_isys_csi_phy_powerup(csi2); >> + if (ret) { >> + dev_err(dev, "CSI-%d PHY power up failed %d\n", port, ret); >> + return ret; >> + } >> + csi2_irq_en(csi2, 1); >> + >> + return 0; >> +} >> + >> +static int ipu7_isys_csi2_set_sel(struct v4l2_subdev *sd, >> + struct v4l2_subdev_state *state, >> + struct v4l2_subdev_selection *sel) >> +{ >> + struct ipu7_isys_subdev *asd = to_ipu7_isys_subdev(sd); >> + struct device *dev = &asd->isys->adev->auxdev.dev; >> + struct v4l2_mbus_framefmt *sink_ffmt; >> + struct v4l2_mbus_framefmt *src_ffmt; >> + struct v4l2_rect *crop; >> + >> + if (sel->pad == CSI2_PAD_SINK || sel->target != V4L2_SEL_TGT_CROP) >> + return -EINVAL; >> + >> + sink_ffmt = v4l2_subdev_state_get_opposite_stream_format(state, >> + sel->pad, >> + sel->stream); >> + if (!sink_ffmt) >> + return -EINVAL; >> + >> + src_ffmt = v4l2_subdev_state_get_format(state, sel->pad, sel->stream); >> + if (!src_ffmt) >> + return -EINVAL; >> + >> + crop = v4l2_subdev_state_get_crop(state, sel->pad, sel->stream); >> + if (!crop) >> + return -EINVAL; >> + >> + /* Only vertical cropping is supported */ >> + sel->r.left = 0; >> + sel->r.width = sink_ffmt->width; >> + /* Non-bayer formats can't be single line cropped */ >> + if (!ipu7_isys_is_bayer_format(sink_ffmt->code)) >> + sel->r.top &= ~1U; >> + sel->r.height = clamp(sel->r.height & ~1U, IPU_ISYS_MIN_HEIGHT, >> + sink_ffmt->height - sel->r.top); >> + *crop = sel->r; >> + >> + /* update source pad format */ >> + src_ffmt->width = sel->r.width; >> + src_ffmt->height = sel->r.height; >> + if (ipu7_isys_is_bayer_format(sink_ffmt->code)) >> + src_ffmt->code = ipu7_isys_convert_bayer_order(sink_ffmt->code, >> + sel->r.left, >> + sel->r.top); >> + dev_dbg(dev, "set crop for %s sel: %d,%d,%d,%d code: 0x%x\n", >> + sd->name, sel->r.left, sel->r.top, sel->r.width, sel->r.height, >> + src_ffmt->code); >> + >> + return 0; >> +} >> + >> +static int ipu7_isys_csi2_get_sel(struct v4l2_subdev *sd, >> + struct v4l2_subdev_state *state, >> + struct v4l2_subdev_selection *sel) >> +{ >> + struct v4l2_mbus_framefmt *sink_ffmt; >> + struct v4l2_rect *crop; >> + int ret = 0; >> + >> + if (sd->entity.pads[sel->pad].flags & MEDIA_PAD_FL_SINK) >> + return -EINVAL; >> + >> + sink_ffmt = v4l2_subdev_state_get_opposite_stream_format(state, >> + sel->pad, >> + sel->stream); >> + if (!sink_ffmt) >> + return -EINVAL; >> + >> + crop = v4l2_subdev_state_get_crop(state, sel->pad, sel->stream); >> + if (!crop) >> + return -EINVAL; >> + >> + switch (sel->target) { >> + case V4L2_SEL_TGT_CROP_DEFAULT: >> + case V4L2_SEL_TGT_CROP_BOUNDS: >> + sel->r.left = 0; >> + sel->r.top = 0; >> + sel->r.width = sink_ffmt->width; >> + sel->r.height = sink_ffmt->height; >> + break; >> + case V4L2_SEL_TGT_CROP: >> + sel->r = *crop; >> + break; >> + default: >> + ret = -EINVAL; >> + } >> + >> + return ret; >> +} >> + >> +/* >> + * Maximum stream ID is 63 for now, as we use u64 bitmask to represent a set >> + * of streams. >> + */ >> +#define CSI2_SUBDEV_MAX_STREAM_ID 63 >> + >> +static int ipu7_isys_csi2_enable_streams(struct v4l2_subdev *sd, >> + struct v4l2_subdev_state *state, >> + u32 pad, u64 streams_mask) >> +{ >> + struct ipu7_isys_subdev *asd = to_ipu7_isys_subdev(sd); >> + struct ipu7_isys_csi2 *csi2 = to_ipu7_isys_csi2(asd); >> + struct v4l2_subdev *r_sd; >> + struct media_pad *r_pad; >> + u32 sink_pad, sink_stream; >> + int ret, i; >> + >> + if (!csi2->stream_count) { >> + dev_dbg(&csi2->isys->adev->auxdev.dev, >> + "stream on CSI2-%u with %u lanes\n", csi2->port, >> + csi2->nlanes); >> + ret = ipu7_isys_csi2_enable_stream(csi2); >> + if (ret) >> + return ret; >> + } >> + >> + for (i = 0; i <= CSI2_SUBDEV_MAX_STREAM_ID; i++) { >> + if (streams_mask & BIT_ULL(i)) >> + break; >> + } >> + >> + ret = v4l2_subdev_routing_find_opposite_end(&state->routing, pad, i, >> + &sink_pad, &sink_stream); >> + if (ret) >> + return ret; >> + >> + r_pad = media_pad_remote_pad_first(&sd->entity.pads[CSI2_PAD_SINK]); >> + r_sd = media_entity_to_v4l2_subdev(r_pad->entity); >> + >> + ret = v4l2_subdev_enable_streams(r_sd, r_pad->index, >> + BIT_ULL(sink_stream)); >> + if (!ret) { >> + csi2->stream_count++; >> + return 0; >> + } >> + >> + if (!csi2->stream_count) >> + ipu7_isys_csi2_disable_stream(csi2); >> + >> + return ret; >> +} >> + >> +static int ipu7_isys_csi2_disable_streams(struct v4l2_subdev *sd, >> + struct v4l2_subdev_state *state, >> + u32 pad, u64 streams_mask) >> +{ >> + struct ipu7_isys_subdev *asd = to_ipu7_isys_subdev(sd); >> + struct ipu7_isys_csi2 *csi2 = to_ipu7_isys_csi2(asd); >> + struct v4l2_subdev *r_sd; >> + struct media_pad *r_pad; >> + u32 sink_pad, sink_stream; >> + int ret, i; >> + >> + for (i = 0; i <= CSI2_SUBDEV_MAX_STREAM_ID; i++) { >> + if (streams_mask & BIT_ULL(i)) >> + break; >> + } >> + >> + ret = v4l2_subdev_routing_find_opposite_end(&state->routing, pad, i, >> + &sink_pad, &sink_stream); >> + if (ret) >> + return ret; >> + >> + r_pad = media_pad_remote_pad_first(&sd->entity.pads[CSI2_PAD_SINK]); >> + r_sd = media_entity_to_v4l2_subdev(r_pad->entity); >> + >> + v4l2_subdev_disable_streams(r_sd, r_pad->index, BIT_ULL(sink_stream)); >> + >> + if (--csi2->stream_count) >> + return 0; >> + >> + dev_dbg(&csi2->isys->adev->auxdev.dev, >> + "stream off CSI2-%u with %u lanes\n", csi2->port, csi2->nlanes); >> + >> + ipu7_isys_csi2_disable_stream(csi2); >> + >> + return 0; >> +} >> + >> +static const struct v4l2_subdev_pad_ops csi2_sd_pad_ops = { >> + .get_fmt = v4l2_subdev_get_fmt, >> + .set_fmt = ipu7_isys_subdev_set_fmt, >> + .get_selection = ipu7_isys_csi2_get_sel, >> + .set_selection = ipu7_isys_csi2_set_sel, >> + .enum_mbus_code = ipu7_isys_subdev_enum_mbus_code, >> + .enable_streams = ipu7_isys_csi2_enable_streams, >> + .disable_streams = ipu7_isys_csi2_disable_streams, >> + .set_routing = ipu7_isys_subdev_set_routing, >> +}; >> + >> +static const struct v4l2_subdev_ops csi2_sd_ops = { >> + .core = &csi2_sd_core_ops, >> + .pad = &csi2_sd_pad_ops, >> +}; >> + >> +static const struct media_entity_operations csi2_entity_ops = { >> + .link_validate = v4l2_subdev_link_validate, >> + .has_pad_interdep = v4l2_subdev_has_pad_interdep, >> +}; >> + >> +void ipu7_isys_csi2_cleanup(struct ipu7_isys_csi2 *csi2) >> +{ >> + if (!csi2->isys) >> + return; >> + >> + v4l2_device_unregister_subdev(&csi2->asd.sd); >> + v4l2_subdev_cleanup(&csi2->asd.sd); >> + ipu7_isys_subdev_cleanup(&csi2->asd); >> + csi2->isys = NULL; >> +} >> + >> +int ipu7_isys_csi2_init(struct ipu7_isys_csi2 *csi2, >> + struct ipu7_isys *isys, >> + void __iomem *base, unsigned int index) >> +{ >> + struct device *dev = &isys->adev->auxdev.dev; >> + int ret; >> + >> + csi2->isys = isys; >> + csi2->base = base; >> + csi2->port = index; >> + >> + if (!is_ipu7(isys->adev->isp->hw_ver)) >> + csi2->legacy_irq_mask = 0x7U << (index * 3U); >> + else >> + csi2->legacy_irq_mask = 0x3U << (index * 2U); >> + >> + dev_dbg(dev, "csi-%d legacy irq mask = 0x%x\n", index, >> + csi2->legacy_irq_mask); >> + >> + csi2->asd.sd.entity.ops = &csi2_entity_ops; >> + csi2->asd.isys = isys; >> + >> + ret = ipu7_isys_subdev_init(&csi2->asd, &csi2_sd_ops, 0, >> + NR_OF_CSI2_SINK_PADS, NR_OF_CSI2_SRC_PADS); >> + if (ret) >> + return ret; >> + >> + csi2->asd.source = (int)index; >> + csi2->asd.supported_codes = csi2_supported_codes; >> + snprintf(csi2->asd.sd.name, sizeof(csi2->asd.sd.name), >> + IPU_ISYS_ENTITY_PREFIX " CSI2 %u", index); >> + v4l2_set_subdevdata(&csi2->asd.sd, &csi2->asd); >> + >> + ret = v4l2_subdev_init_finalize(&csi2->asd.sd); >> + if (ret) { >> + dev_err(dev, "failed to init v4l2 subdev (%d)\n", ret); >> + goto isys_subdev_cleanup; >> + } >> + >> + ret = v4l2_device_register_subdev(&isys->v4l2_dev, &csi2->asd.sd); >> + if (ret) { >> + dev_err(dev, "failed to register v4l2 subdev (%d)\n", ret); >> + goto v4l2_subdev_cleanup; >> + } >> + >> + return 0; >> + >> +v4l2_subdev_cleanup: >> + v4l2_subdev_cleanup(&csi2->asd.sd); >> +isys_subdev_cleanup: >> + ipu7_isys_subdev_cleanup(&csi2->asd); >> + >> + return ret; >> +} >> + >> +void ipu7_isys_csi2_sof_event_by_stream(struct ipu7_isys_stream *stream) >> +{ >> + struct ipu7_isys_csi2 *csi2 = ipu7_isys_subdev_to_csi2(stream->asd); >> + struct device *dev = &stream->isys->adev->auxdev.dev; >> + struct video_device *vdev = csi2->asd.sd.devnode; >> + struct v4l2_event ev = { >> + .type = V4L2_EVENT_FRAME_SYNC, >> + }; >> + >> + ev.id = stream->vc; >> + ev.u.frame_sync.frame_sequence = atomic_fetch_inc(&stream->sequence); >> + v4l2_event_queue(vdev, &ev); >> + >> + dev_dbg(dev, "sof_event::csi2-%i sequence: %i, vc: %d\n", >> + csi2->port, ev.u.frame_sync.frame_sequence, stream->vc); >> +} >> + >> +void ipu7_isys_csi2_eof_event_by_stream(struct ipu7_isys_stream *stream) >> +{ >> + struct ipu7_isys_csi2 *csi2 = ipu7_isys_subdev_to_csi2(stream->asd); >> + struct device *dev = &stream->isys->adev->auxdev.dev; >> + u32 frame_sequence = atomic_read(&stream->sequence); >> + >> + dev_dbg(dev, "eof_event::csi2-%i sequence: %i\n", >> + csi2->port, frame_sequence); >> +} >> + >> +int ipu7_isys_csi2_get_remote_desc(u32 source_stream, >> + struct ipu7_isys_csi2 *csi2, >> + struct media_entity *source_entity, >> + struct v4l2_mbus_frame_desc_entry *entry, >> + int *nr_queues) >> +{ >> + struct v4l2_mbus_frame_desc_entry *desc_entry = NULL; >> + struct device *dev = &csi2->isys->adev->auxdev.dev; >> + struct v4l2_mbus_frame_desc desc; >> + struct v4l2_subdev *source; >> + struct media_pad *pad; >> + unsigned int i; >> + int ret; >> + >> + source = media_entity_to_v4l2_subdev(source_entity); >> + if (!source) >> + return -EPIPE; >> + >> + pad = media_pad_remote_pad_first(&csi2->asd.pad[CSI2_PAD_SINK]); >> + if (!pad) >> + return -EPIPE; >> + >> + ret = v4l2_subdev_call(source, pad, get_frame_desc, pad->index, &desc); >> + if (ret) >> + return ret; >> + >> + if (desc.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2) { >> + dev_err(dev, "Unsupported frame descriptor type\n"); >> + return -EINVAL; >> + } >> + >> + for (i = 0; i < desc.num_entries; i++) { >> + if (source_stream == desc.entry[i].stream) { >> + desc_entry = &desc.entry[i]; >> + break; >> + } >> + } >> + >> + if (!desc_entry) { >> + dev_err(dev, "Failed to find stream %u from remote subdev\n", >> + source_stream); >> + return -EINVAL; >> + } >> + >> + if (desc_entry->bus.csi2.vc >= NR_OF_CSI2_VC) { >> + dev_err(dev, "invalid vc %d\n", desc_entry->bus.csi2.vc); >> + return -EINVAL; >> + } >> + >> + *entry = *desc_entry; >> + >> + for (i = 0; i < desc.num_entries; i++) { >> + if (desc_entry->bus.csi2.vc == desc.entry[i].bus.csi2.vc) >> + (*nr_queues)++; >> + } >> + >> + return 0; >> +} >> diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.h b/drivers/staging/media/ipu7/ipu7-isys-csi2.h >> new file mode 100644 >> index 000000000000..ea4e20525d16 >> --- /dev/null >> +++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.h >> @@ -0,0 +1,73 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (C) 2013 - 2025 Intel Corporation >> + */ >> + >> +#ifndef IPU7_ISYS_CSI2_H >> +#define IPU7_ISYS_CSI2_H >> + >> +#include >> +#include >> + >> +#include "ipu7-isys-subdev.h" >> +#include "ipu7-isys-video.h" >> + >> +struct ipu7_isys; >> +struct ipu7_isys_csi2_pdata; >> +struct ipu7_isys_stream; >> + >> +#define NR_OF_CSI2_VC 16U >> +#define INVALID_VC_ID -1 >> +#define NR_OF_CSI2_SINK_PADS 1U >> +#define CSI2_PAD_SINK 0U >> +#define NR_OF_CSI2_SRC_PADS 8U >> +#define CSI2_PAD_SRC 1U >> +#define NR_OF_CSI2_PADS (NR_OF_CSI2_SINK_PADS + NR_OF_CSI2_SRC_PADS) > > These seem to require IPU7 prefix, too. It'd be nice to move them into a > struct, specific to IPU version. > >> + >> +#define CSI2_CSI_RX_DLY_CNT_TERMEN_CLANE_A 0 >> +#define CSI2_CSI_RX_DLY_CNT_TERMEN_CLANE_B 0 >> +#define CSI2_CSI_RX_DLY_CNT_SETTLE_CLANE_A 95 >> +#define CSI2_CSI_RX_DLY_CNT_SETTLE_CLANE_B -8 >> + >> +#define CSI2_CSI_RX_DLY_CNT_TERMEN_DLANE_A 0 >> +#define CSI2_CSI_RX_DLY_CNT_TERMEN_DLANE_B 0 >> +#define CSI2_CSI_RX_DLY_CNT_SETTLE_DLANE_A 85 >> +#define CSI2_CSI_RX_DLY_CNT_SETTLE_DLANE_B -2 > > These are the same for IPU6, aren't they? Will remove them. > -- Best regards, Bingbu Cao