From: "flichtenheld (Code Review)" Date: Mon, 8 Jul 2024 16:32:44 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <2724e23a183254cfd96ab68845da9ff87536a66c-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="yrG54OHiPk0="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --yrG54OHiPk0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/672?usp=3Demail ) Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: I must say that I would feel better if we had a UT covering all this. Not s= ure how difficult that would be? File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/9a73fe6c_d79f0ee2 : PS2, Line 318: format_hex(BPTR(&buf), BLEN(&cmdbuf)= , 256, &gc)); While it is not actually wrong to use BPTR(&buf) here, I would recommend BP= TR(&cmdbuf). It should make no difference to the output and looks less like= an error. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 08 Jul 2024 16:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --yrG54OHiPk0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #2:

      I must say that I would feel better if we had= a UT covering all this. Not sure how difficult that would be?

    • File src/openvpn/forward.c:

      • Patch Set #2, Line 3= 18: = format_hex(BPTR(&buf), BLEN(&cmdbuf), 256, &gc));

        While it is no= t actually wrong to use BPTR(&buf) here, I would recommend BPTR(&cm= dbuf). It should make no difference to the output and looks less like an er= ror.

    To view, visit change 672. To unsubscribe, or for= help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f72= 0cf50dc1fbe3e
    Gerrit-Change-Number: 672
    Gerrit-PatchSet: 2
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Mon, 08 Jul 2024 16:32:44= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --yrG54OHiPk0=--