From: David Howells Subject: Re: [PATCH 7/5] Optimise d_find_alias() Date: Fri, 03 Mar 2006 13:00:10 +0000 Message-ID: <27600.1141390810@warthog.cambridge.redhat.com> References: <20060303034552.5fcedc49.akpm@osdl.org> <20060302213356.7282.26463.stgit@warthog.cambridge.redhat.com> <25676.1141385408@warthog.cambridge.redhat.com> Cc: David Howells , torvalds@osdl.org, steved@redhat.com, trond.myklebust@fys.uio.no, aviro@redhat.com, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <20060303034552.5fcedc49.akpm@osdl.org> To: Andrew Morton Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > How can we get away without a barrier? Is this what you're thinking of: struct dentry * d_find_alias(struct inode *inode) { struct dentry *de = NULL; smp_rb(); if (!list_empty(&inode->i_dentry)) { spin_lock(&dcache_lock); de = __d_find_alias(inode, 0); spin_unlock(&dcache_lock); } return de; } David