From: "cron2 (Code Review)" Date: Sun, 5 Apr 2026 14:32:55 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <278d3a45368528a89764b7ac6692ba9d838268bc-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="jOb1D9tF3b0="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: win: Fix nrpt_dnssec flag handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos , d12fk Cc: openvpn-devel --jOb1D9tF3b0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1606?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: win: Fix nrpt_dnssec flag handling ...................................................................... win: Fix nrpt_dnssec flag handling By default the first enum value is 0. But we check whether we set the flag by doing BOOL dnssec =3D (msg->flags & nrpt_dnssec) !=3D 0; This can't ever be true. Found by cppcheck. Change-Id: Iff5be978817bfc0cd4d78818e7be7b90bad71f3c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1606 Message-Id: <20260405102209.31528-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 487.html Signed-off-by: Gert Doering --- M include/openvpn-msg.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/06/1606/2 diff --git a/include/openvpn-msg.h b/include/openvpn-msg.h index bef20cf..ca3267e 100644 --- a/include/openvpn-msg.h +++ b/include/openvpn-msg.h @@ -110,7 +110,7 @@ typedef enum { - nrpt_dnssec + nrpt_dnssec =3D 1 << 0, } nrpt_flags_t; #define NRPT_ADDR_NUM 8 /* Max. number of addresses */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1606?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff5be978817bfc0cd4d78818e7be7b90bad71f3c Gerrit-Change-Number: 1606 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: d12fk Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --jOb1D9tF3b0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

win: Fix nrpt_dnssec flag handling<=
br>
By default the first enum value is 0.
But we check whether we set= the flag by doing
BOOL dnssec =3D (msg->flags & nrpt_dnssec) != =3D 0;
This can't ever be true.

Found by cppcheck.

Cha= nge-Id: Iff5be978817bfc0cd4d78818e7be7b90bad71f3c
Signed-off-by: Frank L= ichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1386...= 296...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1606
Me= ssage-Id: <20260405102209.31528-1-gert@...1296...>
URL: https://ww= w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36487.html
Sig= ned-off-by: Gert Doering <gert@...1296...>
---
M include/openvp= n-msg.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/06/16=
06/2
diff --git a/include/openvpn-msg.h b/include/openvpn-msg.h
index bef20cf..ca3267e 100644
--- a/include/op= envpn-msg.h
+++ b/include/openvpn-msg.h
@@ = -110,7 +110,7 @@

typedef enum
= {
- nrpt_dnss= ec
+ nrpt_dnssec = =3D 1 << 0,
} nrpt_flags_t;
=
#define NRPT_ADDR_NUM 8 /* Max. number of addresses */<= br>

To view, visit change 1606. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iff5be978817bfc0cd4d78818e7b= e7b90bad71f3c
Gerrit-Change-Number: 1606
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: d12fk <heiko@...515...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --jOb1D9tF3b0=--