From: David Howells Date: Mon, 17 Jun 2013 09:07:59 +0000 Subject: Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h Message-Id: <27908.1371460079@warthog.procyon.org.uk> List-Id: References: <1371413189-2568-3-git-send-email-ddaney.cavm@gmail.com> <1371413189-2568-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1371413189-2568-3-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ddaney.cavm@gmail.com Cc: dhowells@redhat.com, Linus Torvalds , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, Koichi Yasutake , linux-am33-list@redhat.com, david.s.daney@gmail.com, David Daney ddaney.cavm@gmail.com wrote: > #ifndef __ASSEMBLY__ > -#include > +/* linux/smp.h <- linux/irqflags.h needs asm/smp.h first */ > +#include > #endif If you make this change, is the #ifndef __ASSEMBLY__ still necessary, I wonder... David