From: "cron2 (Code Review)" Date: Wed, 23 Jul 2025 08:15:24 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., antonio@...2726... Message-ID: <27bc20dbd24f82f0eabc3b206e952e03a7b52c26-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ohwEpHuFitE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: fix case statement by using proper error value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --ohwEpHuFitE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/10= 95?usp=3Demail ) Change subject: dco_linux: fix case statement by using proper error value ...................................................................... dco_linux: fix case statement by using proper error value A M_ERR constant accidentally slipped in as possible netlink error value. Substitute it with the actual code matching the following error message. Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20250723062012.22781-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 269.html Signed-off-by: Gert Doering --- M src/openvpn/dco_linux.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index f04ebfe..0a73882 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -143,7 +143,7 @@ msg(M_ERR, "%s: netlink out of memory error", prefix); break; - case -M_ERR: + case -NLE_AGAIN: msg(M_WARN, "%s: netlink reports blocking read - aborting wait= ", prefix); break; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Gerrit-Change-Number: 1095 Gerrit-PatchSet: 3 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --ohwEpHuFitE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

dco_linux: fix case statement by using proper=
 error value

A M_ERR constant accidentally slipped in as possiblenetlink error value.

Substitute it with the actual code matching th= e following
error message.

Change-Id: I18df6ef659cab9525dd7847b7d= d3950fc1895dd5
Signed-off-by: Antonio Quartulli <antonio@...2726...&g= t;
Acked-by: Gert Doering <gert@...1296...>
Message-Id: <202= 50723062012.22781-1-gert@...1296...>
URL: https://www.mail-archive.co= m/openvpn-devel@lists.sourceforge.net/msg32269.html
Signed-off-by: Gert = Doering <gert@...1296...>
---
M src/openvpn/dco_linux.c
1 fi= le changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.cindex f04ebfe..0a73882 100644
--- a/src/openvpn/dco_= linux.c
+++ b/src/openvpn/dco_linux.c
@@ -1= 43,7 +143,7 @@
msg(M_ERR, "%s: netlink ou= t of memory error", prefix);
break;

- c= ase -M_ERR:
+ = case -NLE_AGAIN:
msg(M_WARN, "%s: netlink= reports blocking read - aborting wait", prefix);
= break;


To vi= ew, visit change 1095. To unsubscribe, or for help writing mail filters, visit = settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd= 3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 3
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--ohwEpHuFitE=--