From: "plaisthos (Code Review)"
Date: Fri, 5 Jan 2024 14:19:56 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <27d4d14af8e86dfd28735cd0b8424a2a013fbacd-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="bfvxCFS1gL0="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: increase
verbosity for make check
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: flichtenheld
Cc: openvpn-devel
--bfvxCFS1gL0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/485?usp=3Demail )
Change subject: GHA: increase verbosity for make check
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> Retracting my previous ACK. I mixed up cmake VERBOSE=3D1 with the V=3D1 o=
f make.
I had still a backout of the serial test in my branch, so I did had the gen=
erated code for this in my tree:
tests/unit_tests/openvpn/Makefile: test x"$$VERBOSE" =3D x || cat $(TEST_=
SUITE_LOG);
So it actually works.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--bfvxCFS1gL0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
Patch set 1:Code-Review +2=
Vi=
ew Change
1 comment:
Patchset:
Patch Set #1:
Retracting my prev=
ious ACK. I mixed up cmake VERBOSE=3D1 with the V=3D1 of make.
=
I had still =
a backout of the serial test in my branch, so I did had the generated code =
for this in my tree:
tests/unit_tests/openvpn/Makefile: test x"$$VERBOSE" =
=3D x || cat $(TEST_SUITE_LOG);
So it actually works.
To view,=
visit ch=
ange 485. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa=
5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:19:56=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--bfvxCFS1gL0=--