From: Brijesh Singh Subject: Re: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT_EXPORT ioctl command Date: Mon, 6 Nov 2017 10:16:53 -0600 Message-ID: <280a3443-3268-5c11-4e7d-0d7874060730@amd.com> References: <20171101211623.71496-1-brijesh.singh@amd.com> <20171101211623.71496-21-brijesh.singh@amd.com> <20171105113412.2xtuifkbmxwrf3ji@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org To: Borislav Petkov Return-path: In-Reply-To: <20171105113412.2xtuifkbmxwrf3ji@pd.tnic> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 11/05/2017 05:34 AM, Borislav Petkov wrote: ... > > Fixes ontop: > > * !input.cert_chain_address test was repeated. I saw that by aligning > them vertically, i.e., after making it more readable, the repetition > became obvious. > > * Do the lengths checks first and the access_ok after, in each PDH and > cert chain test. > > * Do the checks first and the allocations after, not interleaved. > > * Comments are sentences which should end with a '.' > > (hunk below contains also that &psp_master->cmd_buf change but you're going to > remove that arg anyway). > I am good with all your fixup, I will apply them in v8. -Brijesh