From: "flichtenheld (Code Review)" Date: Wed, 10 Jul 2024 14:05:11 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <28148c3d6bdea4f22510c8a7158361b22d348457-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="gXAwKxbkq2w="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: cron2 , openvpn-devel --gXAwKxbkq2w= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/672?usp=3Demail ) Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/48fff3e1_39fedac0 : PS2, Line 302: int buflen =3D (int)strlen(BSTR(&buf)) + 1; > While this is besser than the original, I find it still confusing to call= `strlen()` twice on the ve [=E2=80=A6] Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/562bef0c_87a4f24d : PS3, Line 295: struct buffer cmdbuf =3D extract_command_buffer(= buf, &gc); > &buf Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 10 Jul 2024 14:05:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --gXAwKxbkq2w= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

Patch set 4:Code-Review +2=

Vi= ew Change

2 comments: