Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by mx.groups.io with SMTP id smtpd.web11.8367.1623248303278236049 for ; Wed, 09 Jun 2021 07:18:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bootlin.com, ip: 217.70.183.194, mailfrom: michael.opdenacker@bootlin.com) Received: (Authenticated sender: michael.opdenacker@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2E1074000D; Wed, 9 Jun 2021 14:18:20 +0000 (UTC) Cc: docs@lists.yoctoproject.org Subject: Re: [docs] [PATCH v2] test-manual: add initial reproducible builds documentation To: Richard Purdie , Quentin Schulz References: <16868CB8BF8EEF84.10003@lists.yoctoproject.org> <20210608095853.48522-1-michael.opdenacker@bootlin.com> <20210609091143.vvykg2irov6wcbdu@qschulz> From: "Michael Opdenacker" Organization: Bootlin Message-ID: <28479020-8064-dd56-d73f-c8482e9f2b46@bootlin.com> Date: Wed, 9 Jun 2021 16:18:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Quentin, Richard, Thank you for your reviews and answers... On 6/9/21 11:23 AM, Richard Purdie wrote: > On Wed, 2021-06-09 at 11:11 +0200, Quentin Schulz wrote: >> Hi Michael, Richard, >> >> On Tue, Jun 08, 2021 at 11:58:53AM +0200, Michael Opdenacker wrote: >>> From: Richard Purdie >>> >>> +The Yocto Project defines reproducibility as where a given input build configuration will give the same binary output regardless of when it is built (now or in 5 years time), regardless of the path on the filesystem the build is run in, and regardless of the distro and tools on the underlying host system the build is running on. >>> + >>> +============== >>> +Why it matters >>> +============== >>> + >>> +The project aligns with the `Reproducible Builds project `_, which shares information about why reproducibility matters. The primary focus of the project is the ability to detect security issues being introduced. However, from a Yocto Project perspective, it is also hugely important that our builds are deterministic. When you build a given input set of metadata, we expect you to get consistent output. This has always been a key focus but is now true down to the binary level including timestamps. >>> + >> "now" is too abstract? Can we say at least since when (e.g. which release)? > As of dunfell we enabled reprodubile builds in poky by default. > > http://git.yoctoproject.org/cgit.cgi/poky/commit/meta-poky/conf/distro/poky.conf?id=25a17f0346ab05b3212bb280e4a8b622bcf99bce I agree wit Quentin, the documentation will live for years. I also replaced "at the time of writing" by a release name. I updated this part too. >>> +For example, at some point in the future life of a product, you find that you need to rebuild to add a security fix. If this happens, only the components that have been modified should change at the binary level. This would lead to much easier and clearer bounds on where validation is needed. >>> + >>> +This also gives an additional benefit to the project builds themselves, our hash equivalence for :ref:`Shared State ` object reuse works much more effectively when the binary output remains the same. >>> + >>> +=================== >>> +How we implement it >>> +=================== >>> + >>> +There are many different aspects to build reproducibility, but some particular things we do within the build system to ensure reproducibility include: >>> + >>> +* Adding mappings to the compiler options to ensure debug filepaths are mapped to consistent target compatible paths. This is done through the ``DEBUG_PREFIX_MAP`` variable which sets the ``-fmacro-prefix-map`` and ``-fdebug-prefix-map`` compiler options correctly to map to target paths. >> Would documenting DEBUG_PREFIX_MAP make sense? Is it supposed to be >> changed by users in some cases? >> for reference, where it's being defined: https://git.yoctoproject.org/cgit.cgi/poky/tree/meta/conf/bitbake.conf#n612 > Users shouldn't need to mess with it but it should be documented. Good. I'll keep track of this. > >>> +* Being explicit about recipe dependencies and their configuration (no floating configure options or host dependencies creeping in). In particular this means making sure :term:`PACKAGECONFIG` coverage covers configure options which may otherwise try and auto-detect host dependencies. >>> +* Using recipe specific sysroots to isolate recipes so they only see their dependencies. These are visible as ``recipe-sysroot`` and ``recipe-sysroot-native`` directories within the :term:`WORKDIR` of a given recipe and are populated only with the dependencies a recipe has. >> Can't we just reference RECIPE_SYSROOT and RECIPE_SYSROOT_NATIVE here? >> Aaaand I just discovered these aren't in the variable glossary but I >> find them very important? > I suspect unfortunately our recipe specific sysroots are basically notĀ  > documented at all :(. Again, probably needs fixing ultimately. Not completely true fortunately. At least you have the explanations on https://docs.yoctoproject.org/overview-manual/concepts.html#configuration-compilation-and-staging I'm keeping another note to keep track of this, and later we will create a bug when we have the new "Variable Glossary" category. > >> Can be done later on since they do not exist yet. >> >>> +* Build images from a reduced package set: only packages from recipes the image depends upon. >>> +* Filtering the tools available from the host's PATH to only a specific set of tools, set using the :term:`HOSTTOOLS` variable. >>> + >> ``PATH``? Right, fixed. >> >> Also, I think we use dashes more than asterisks for lists? Oops, the result seems to be the same, but yes, that's our standard. Fixed. Do you know why dashes where chosen over lists? I also forgot to pay attention to indenting. I've just fixed it too, to match the 80 columns format that we usually have. >> >> I think there's also an additional point: we check the sources we >> download. Therefore, if a commit disappears (force-pushed/removed >> branch/tag), the tarball disappears from upstream, or its checksum >> differs from what we expect, we don't build. >> >> Might be worth mentioning that we only download sources from the >> internet when we're missing them locally. So hosting a mirror for >> sources or making sure they are available locally is a need if you want >> to guarantee full reproducible builds. >> >> And this is especially important to mention since some projects are >> removing their master branches for example in favor of main, breaking >> older builds. Or some projects change hosting services and do not >> redirect, or just disappear from the Internet. > Yes, we should put something in about input validation - all inputs > to the build have some kind of validation, by checksum or sourceĀ  > control hash/revision. All right, I'll add something for you to review. > >>> +========================================= >>> +Can we prove the project is reproducible? >>> +========================================= >>> + >>> +Yes, we can prove it and we now regularly test this on the Autobuilder. At the time of writing (Hardknott 3.3), OE-Core is 100% reproducible for all its recipes (i.e. world builds) apart from the Go language and Ruby documentation packages. Unfortunately, the current implementation of the Go language has fundamental reproducibility problems as it always depends upon the paths it is build in. >>> + >> s/now// Fixed >> >> Please give a link to reproducibility test archives/categories on the >> Autobuilder if there's any available? > > Isn't that below with the current status? The autobuilder would be something like: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/reproducible > > but also > > https://autobuilder.yoctoproject.org/typhoon/#/builders/reproducible-centos > https://autobuilder.yoctoproject.org/typhoon/#/builders/reproducible-debian > https://autobuilder.yoctoproject.org/typhoon/#/builders/reproducible-fedora > https://autobuilder.yoctoproject.org/typhoon/#/builders/reproducible-ubuntu I didn't manage to find the links you referred to from https://www.yoctoproject.org/reproducible-build-results/ . I'm adding those too.k >> s/build/built/ Fixed. >> >> I would add a reference to OE-Core term :term:`OpenEmbedded-Core (OE-Core)` >> which explains what exactly it is. It is an important reference since we >> really mean to say that openembedded-core layer recipes (which is >> meta layer in poky) is 100% reproducible, nothing else. Basically, >> OE-Core + Bitbake is guaranteed to be reproducible, but the moment you >> add another layer, no guarantee (e.g. because of additional >> configuration files, bbappends, overridden classes, etc...) Done (adding the reference). I also liked your comment so I added that as a note. >> >>> +To run our automated selftest, as we use in our CI on the Autobuilder, you can run:: >>> + >>> + oe-selftest -r reproducible.ReproducibleTests.test_reproducible_builds >>> + >>> +This defaults to including a world build so, if other layers are added, it would also run the tests for recipes in the additional layers. The first build will be run using Shared State if available, the second build explicitly disables Shared State and builds on the specific host the build is running on. This means we can test reproducibility builds between different host distributions over time on the Autobuilder. >>> + >> s/Shared State/:ref:`Shared State `/ >> >> since we already reference it earlier in this page. Oops, good catch. Thanks. >> >>> +If ``OEQA_DEBUGGING_SAVED_OUTPUT`` is set, any differing packages will be saved here. The test is also able to run the ``diffoscope`` command on the output to generate HTML files showing the differences between the packages, to aid debugging. On the Autobuilder, these appear under https://autobuilder.yocto.io/pub/repro-fail/ in the form ``oe-reproducible + + ``, e.g. ``oe-reproducible-20200202-1lm8o1th``. >>> + >> Would it make sense to document OEQA_DEBUGGING_SAVED_OUTPUT too? Richard, mailing list readers, any opinion on this? Cheers, Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com