Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94ABC636D4 for ; Wed, 15 Feb 2023 08:08:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F06406B0072; Wed, 15 Feb 2023 03:08:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB6D26B0073; Wed, 15 Feb 2023 03:08:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7E136B0074; Wed, 15 Feb 2023 03:08:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C52C86B0072 for ; Wed, 15 Feb 2023 03:08:10 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8ECE640ECC for ; Wed, 15 Feb 2023 08:08:10 +0000 (UTC) X-FDA: 80468798340.10.56F64DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 7DD14140021 for ; Wed, 15 Feb 2023 08:08:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BwPqbDV8; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676448488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9u9d4+mSA10ut2q7fk3wCmoZCnOirUoOM8gzSFKLCaI=; b=Z9gpbtHQfkI//oYafOhp9zDK+IyUrnUs7nlxsve4XUEjm6IWEvGQ7J5BKF2pnWJKEs9PBI bAA4h/KzgNWexHhs9+QhKjMyotjBiowgZ4f+sK0mdlf1dDhNFpZDPBxlLzT+NjIm1mCeS/ yHHEhj9BNjNK1+BODHxHnwuVvkb+bqU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BwPqbDV8; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676448488; a=rsa-sha256; cv=none; b=WANQOXTirAbyqawRLEdT/opUO5d82Ec9ADjm+fqiUBes4nF8wBZIaEw/krMDOtbCYFuw53 INu0Li9pAtQ2uABSoTCtNcyV+sJMmMUwXB4EmEG1QOiWsBiGNMw2GhLsYf88EzLD+dTLJ3 JufIDul+mVaarp+0XjZgSiFDm9OzFvY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676448486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9u9d4+mSA10ut2q7fk3wCmoZCnOirUoOM8gzSFKLCaI=; b=BwPqbDV8YGLf0X6/kGnr1n8srm6yWVSbFMfsyD9blBOhGQ15b9+gr6zwjp5RlJ1XklJb+F 9AQTOFrWhHM26748JeggPZUSxbEEHbdLrZsXncK6Pv/dZv0NsaRGrZ7LlBYVpagEAg+DU6 1BWjnELTpEQxLwEmLwkVqrixwB/K9G4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-QV-m0oUcNiaSK3dKwtDYaw-1; Wed, 15 Feb 2023 03:08:02 -0500 X-MC-Unique: QV-m0oUcNiaSK3dKwtDYaw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F46729AA2D5; Wed, 15 Feb 2023 08:08:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1FF6140EBF6; Wed, 15 Feb 2023 08:07:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <867e1e3e-681b-843b-1704-effed736e13d@kernel.dk> References: <867e1e3e-681b-843b-1704-effed736e13d@kernel.dk> <20230214171330.2722188-1-dhowells@redhat.com> <2877092.1676415412@warthog.procyon.org.uk> To: Jens Axboe Cc: dhowells@redhat.com, smfrench@gmail.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2895994.1676448478.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Feb 2023 08:07:58 +0000 Message-ID: <2895995.1676448478@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: o3ek5x3fpifb8dt3owy3u7uc76wbwqy5 X-Rspamd-Queue-Id: 7DD14140021 X-HE-Tag: 1676448487-42422 X-HE-Meta: U2FsdGVkX1+hi0XytjNY4h487HzRGRiPxsrUI265dMzKZp4VLZ9jhOUDWirsM0dxZzp8rFRqNDLxtdcujR8K89mFhZ/JX041csETLFCWAIbEGwtrYuOjY1eMCeBJa6Jhy8ju8fVXhy3O2BlyWdBl+DezbrS8FdICo1RAM9tc4z0NyG/NJh+uDZ+5O6NOw9W6+p13FOF8tX1JqEyIy4lPqb5LwBdx+098smg0sNuGyS3X+dtOoZVs7f0hIesfJn4jmSCkXkGKxkW2QLlrFM4dBPY85SkG7a1Lv3uz3DTRgLHRsgC362MK2nvz2jO1PFlyspasCdn2HT+C3hk4D6QRqEK2JoXaWcAGtsWfKZXvkrWzf9/d4PgjuJATjt3hVT/nDs8HSG86pY/5L3eSaQbHRTnXEudjLH4I7Lq/3l32kQeS+nh6HESlf5RkFIX7KivHRGKsP/3fXv7fZBzJeS3yteC4xmJX4EExZpxHros76k3Cys/NASHS0f7f4fYfCZjazn5csRaqpVKuOyBz51MmTosGgVPO9yJ0AZSzbnWpWMS7Mn7Bz9ozJ1rseCB0uj+uOBvzGxFVkFeA7GTmCrBwAMwNp4Ezw3OdkhGm2/4yfirfIBZw4esWqRnYKGGgrFmwqe817x/XIC2PrxM0gR4h2f6/8Pei+RZF1j44c07mvNJHfeYFj9X+Tw+vI7uzB8Ew3RRELeMV6CZJXCaoSaFa65gLEIwndU2RNuBI08lojdQsVRqUkkeINH1K+QVhplXTV94fit3XeQa/qWFHHmgW2TcqQFDducRg+TWtmZ/YaMO+Z4EUKzcBtCyS2Fpa0TU+saefkfdtAarLHNfTHF+ElbPm/TX+wqrlqy8PMCsl//1P4picsqbAKsP7BKYbjDDtSW7xshXTOqf232CBZ4EpOfupqZQTNPJk87bdEaumog9zzyYKe/3Fqdrd9olCj2/wPNNAi2gPnRt2hJBh5Rs erS1Cgv7 JZsZV38qk3Sd+DHnf98+qANBz9L0OriiAYxy1mMRHfXuiCgQr/e3gzxByX7eXe/IZePkw3bY2vacvhvHkQWWY51exbyK/GpIILvbfv6vhjHYN2O4weeHtLB9hN4DxHOlVOZTy7xinRi+yAr1GQ5jlA1y+RsqO8AumKTajuoYtHOucvlkzUuPoyXqTtK6XvvMr6vMi9qQQY0k6BqSZjnRpM6MaYBCeAM5rIbHfbKwHeha80yQxH1nyWHaw8UYJH0TAMWVuTGfe8VM9cm3pH3BJinVEIcnIEuepGNLYAY3XbXu9kwLw5Gkybh1VpiVXAe9rwOaFdmfIVOMr3Z7E49omxEfIGr76lnXZksBiImCHoEvoDklb8tv9lt1hH1CaEJRXDtoj5m+OXYA1RAEJWzaLgIkTxVHRIJNaNQ8ZzTUWcwI9Gm98FySzXb0lSGS92/zFb6fvoCk9mnD6ojbdnnBtyt/fl2CduMMz8vv3oEUH8Q3j90Oh5IIZOSNJLY01lHOQYNBc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jens Axboe wrote: > Let's update the branch and see how it goes... If there's more fallout, = then > let's make a fallback plan for the first few. I forgot to export the new functions, as Steve found out. Fix attached. David --- splice: Export filemap/direct_splice_read() filemap_splice_read() and direct_splice_read() should be exported. Signed-off-by: David Howells cc: Steve French cc: Jens Axboe cc: Christoph Hellwig cc: Al Viro cc: David Hildenbrand cc: John Hubbard cc: linux-cifs@vger.kernel.org cc: linux-mm@kvack.org cc: linux-block@vger.kernel.org cc: linux-fsdevel@vger.kernel.org --- fs/splice.c | 1 + mm/filemap.c | 1 + 2 files changed, 2 insertions(+) diff --git a/fs/splice.c b/fs/splice.c index 4c6332854b63..928c7be2f318 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -373,6 +373,7 @@ ssize_t direct_splice_read(struct file *in, loff_t *pp= os, kfree(bv); return ret; } +EXPORT_SYMBOL(direct_splice_read); = /** * generic_file_splice_read - splice data from file to a pipe diff --git a/mm/filemap.c b/mm/filemap.c index 8c7b135c8e23..570f86578f7c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2969,6 +2969,7 @@ ssize_t filemap_splice_read(struct file *in, loff_t = *ppos, = return total_spliced ? total_spliced : error; } +EXPORT_SYMBOL(filemap_splice_read); = static inline loff_t folio_seek_hole_data(struct xa_state *xas, struct address_space *mapping, struct folio *folio,