Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03500C2BA4C for ; Wed, 26 Jan 2022 14:48:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A649883090; Wed, 26 Jan 2022 15:48:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HzbejGpB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2EE8E83388; Wed, 26 Jan 2022 15:48:45 +0100 (CET) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 01C2F83090 for ; Wed, 26 Jan 2022 15:48:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.bossman075@gmail.com Received: by mail-qv1-xf2a.google.com with SMTP id a7so22233qvl.1 for ; Wed, 26 Jan 2022 06:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iKYdLl3SSWJC4MrUr9x22MZaoaL0ioYAGBRyKzZhu0E=; b=HzbejGpByavb4EQroqXc186adjgZ8Zl/Njeuo87sCHWA29nRHokSqojPJVm3K21/i2 1wfrDCz9kaAHi5BEEqYs2msL6dCMJtEWplW1NM5B7XXT+4rMwFZ3S11vLui92xAQESc/ 2UvrKpbo9Es5cAYEK3stbIohd+b6s3CWitkDeGyKVsdvWp8mTdUBFSDd1Y2TSetbyV8S Nt0Ll7fXriHAe/3XYgiIUqbOAjOTC8h7qpe3T+H7Dd1JhItQ5188WBs4ybBNvK4VbkwA wqyZ/zueaS7JElE6GbZoMeCNgSV3cT8h43V/Wiyf/DCTDg7q69vY7eC2gsV5fK7qJDMp K8uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iKYdLl3SSWJC4MrUr9x22MZaoaL0ioYAGBRyKzZhu0E=; b=mYU/Lvwu3vBVKiqzIAQvFOmInkPnwXnBUCyVTt/5s4kBKxZF+XJ6qc55WJnCo0+MpJ ZmhEdw07QzJhwbIhcDG7LnShrfR+tXxDAHmlKq6qnK5ld1m0Ku/zNZaH/zt8WPnxFce6 1nRzFD92xClNrTToF0vcTFSP2BhIKn3iUvobscvtEb6gZvO/L0uFuAtowwCeOOeTPWLw yEd2T0TPD1ms2zoSPkSobkfI7IMaVJuX0eW+DUAXquA/SP7yykV6Ji3j444Wr86RW6lm g+rcRJ/DAuOujX3X9RbZWimnNf2cIy6ZlpqQkQvCRxP654Ti58ZO6TXO+iucYw/QL32T AbyA== X-Gm-Message-State: AOAM533Y8ZRLMMavhQglCJ/gR4xkb9mLMNFZY7UGafLjxxseqCrj/+2J nse0AuEn9745PsQqr04Hens= X-Google-Smtp-Source: ABdhPJxej8RA5ixm/FaN/elKxgSc3RFW9vfgLcfqQ7RI7QP73rttJPbYaMSyWKQuHBMiL8ZmiaQttg== X-Received: by 2002:a05:6214:2aac:: with SMTP id js12mr23651117qvb.71.1643208520580; Wed, 26 Jan 2022 06:48:40 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id k190sm10765151qkf.59.2022.01.26.06.48.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 06:48:40 -0800 (PST) Message-ID: <2920452b-2cb8-9b2e-1471-bb0f9702542a@gmail.com> Date: Wed, 26 Jan 2022 09:48:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 11/11] configs: sunxi: Add support for Lichee Pi Nano Content-Language: en-US To: Andre Przywara Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, lokeshvutla@ti.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com References: <20220105003508.1143140-1-Mr.Bossman075@gmail.com> <20220105003508.1143140-12-Mr.Bossman075@gmail.com> <20220126141332.1c51f13e@donnerap.cambridge.arm.com> From: Jesse Taube In-Reply-To: <20220126141332.1c51f13e@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/26/22 09:13, Andre Przywara wrote: > On Tue, 4 Jan 2022 19:35:08 -0500 > Jesse Taube wrote: > > Hi, > >> From: Icenowy Zheng >> >> The Lichee Pi Nano is a board based on the F1C100s. >> Add defconfigs for it. >> >> Signed-off-by: Icenowy Zheng >> Signed-off-by: Jesse Taube >> --- >> configs/licheepi_nano_defconfig | 13 ++++++++++++ >> configs/licheepi_nano_spiflash_defconfig | 25 ++++++++++++++++++++++++ >> 2 files changed, 38 insertions(+) >> create mode 100644 configs/licheepi_nano_defconfig >> create mode 100644 configs/licheepi_nano_spiflash_defconfig >> >> diff --git a/configs/licheepi_nano_defconfig b/configs/licheepi_nano_defconfig >> new file mode 100644 >> index 0000000000..3a24870aaf >> --- /dev/null >> +++ b/configs/licheepi_nano_defconfig >> @@ -0,0 +1,13 @@ >> +CONFIG_ARM=y >> +CONFIG_ARCH_SUNXI=y >> +CONFIG_MACH_SUNIV=y >> +CONFIG_SYS_TEXT_BASE=0x81700000 > > This belongs into boot/Kconfig, where we set the values for the other SoCs. > Please reorder them on the way, Kconfig goes with the first match, so we > should have a "default 0x4a000000 if ARCH_SUNXI" line at the end, and the > special snowflakes first. No need for && ARCH_SUNXI, MACH_SUNxxx is always > a subet of that. hmm this is new to me, i will change it. >> +CONFIG_SYS_LOAD_ADDR=0x81000000 > > This should be set in /Kconfig, as for the other SoCs. > >> +CONFIG_SYS_MALLOC_LEN=0x120000 > > Same here, in /Kconfig, and reordering to simplify the expressions. > >> +CONFIG_DRAM_CLK=156 >> +CONFIG_SYS_DCACHE_OFF=y > > Mmh, why is this? doesn't boot when `enable_caches` gets called in mach-sunxi/board.c. > >> +CONFIG_DRAM_ZQ=0 >> +# CONFIG_VIDEO_SUNXI is not set >> +CONFIG_DEFAULT_DEVICE_TREE="suniv-f1c100s-licheepi-nano" >> +CONFIG_SPL=y >> +# CONFIG_SPL_DM_SERIAL is not set > > That should not be needed? Yup DM_SPL isnt set, ill remove it. >> diff --git a/configs/licheepi_nano_spiflash_defconfig b/configs/licheepi_nano_spiflash_defconfig >> new file mode 100644 >> index 0000000000..07b6a27dbe >> --- /dev/null >> +++ b/configs/licheepi_nano_spiflash_defconfig > > I dislike the idea of providing separate defconfigs for those board > variants. We have other examples where a SPI flash chip is not always > populated, but that should go well with one defconfig. If there is no SPI > flash, the code will see that and bail out gracefully, no problems with > that. Yes i already fixed. > So there should be one defconfig, including SPI flash support. I'd suggest > to drop that for now, as the current series does not cover this, AFAICT. > We can add this later, which should be simpler with my SPI fix series. > > Cheers, > Andre > >> @@ -0,0 +1,25 @@ >> +CONFIG_ARM=y >> +CONFIG_ARCH_SUNXI=y >> +CONFIG_ENV_SIZE=0x8000 >> +CONFIG_ENV_OFFSET=0xf8000 >> +CONFIG_MACH_SUNIV=y >> +CONFIG_DRAM_CLK=156 >> +CONFIG_DRAM_ZQ=0 >> +# CONFIG_VIDEO_SUNXI is not set >> +CONFIG_DEFAULT_DEVICE_TREE="suniv-f1c100s-licheepi-nano" >> +CONFIG_SPL=y >> +# CONFIG_CMD_FLASH is not set >> +# CONFIG_CMD_FPGA is not set >> +CONFIG_CMD_SF=y >> +CONFIG_CMD_SPI=y >> +CONFIG_ENV_IS_IN_SPI_FLASH=y >> +CONFIG_DM_SPI_FLASH=y >> +CONFIG_SPI_FLASH=y >> +CONFIG_SPI_FLASH_BAR=y >> +CONFIG_SPI_FLASH_GIGADEVICE=y >> +CONFIG_SPI_FLASH_MACRONIX=y >> +CONFIG_SPI_FLASH_WINBOND=y >> +CONFIG_SPL_SPI_SUNXI=y >> +# CONFIG_SPL_DM_SERIAL is not set >> +CONFIG_DM_SPI=y >> +CONFIG_SUN6I_SPI=y >