Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B62C2D0CE for ; Tue, 21 Jan 2020 14:29:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D302424653 for ; Tue, 21 Jan 2020 14:29:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HF2l5647" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D302424653 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ituWd-0001wD-Oe for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 09:29:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36700) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ittwH-00006S-Jc for qemu-devel@nongnu.org; Tue, 21 Jan 2020 08:51:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ittwD-0000WB-38 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 08:51:29 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30791 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ittwC-0000Vk-TW for qemu-devel@nongnu.org; Tue, 21 Jan 2020 08:51:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579614684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dIeexc3Ll1RtE14QBGDRC/W+OPSUXGgCBhAz9qQyROs=; b=HF2l5647LDd81z0sRPWESEV380dBGcO/H2AST4kxPvokzdhvnQpUb6RuOqRxxZpw96VGZl sf2ixPXov7QFiEzYTIM063Z1++FgkEtQnNboSsV+hl8wV7z3axXA7zQrsoFEKfv4fdSTk3 Mx28GaRwnYtJBTInCkU+bf+ZYG0Rf+s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-60HbP8q0NMeyMxzefIwBCQ-1; Tue, 21 Jan 2020 08:51:20 -0500 X-MC-Unique: 60HbP8q0NMeyMxzefIwBCQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E4B9800D48; Tue, 21 Jan 2020 13:51:19 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-117-116.ams2.redhat.com [10.36.117.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D56E1001DE1; Tue, 21 Jan 2020 13:51:18 +0000 (UTC) Subject: Re: [PATCH 2/2] iotests: add test for backup-top failure on permission activation To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" References: <20200116155452.30972-1-vsementsov@virtuozzo.com> <20200116155452.30972-3-vsementsov@virtuozzo.com> <0e865df2-7d21-b18f-b73c-2948577b9dcb@virtuozzo.com> <1313e55e-0eb1-890a-4e8e-2517f1e80d38@redhat.com> <04a32d71-31da-a3e3-5c5f-cc6465fc9402@virtuozzo.com> <6923bc19-d203-63af-b206-8fe18e4a01c6@redhat.com> <6e0c4e88-6745-a668-6946-237032fdbedd@virtuozzo.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <29434a72-d2cc-5976-cbd7-ceac714d4d65@redhat.com> Date: Tue, 21 Jan 2020 14:51:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <6e0c4e88-6745-a668-6946-237032fdbedd@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8R0So51TRF9pGUyQaW8Avl4BW4VWvu8hB" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kwolf@redhat.com" , "qemu-devel@nongnu.org" , "qemu-stable@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8R0So51TRF9pGUyQaW8Avl4BW4VWvu8hB Content-Type: multipart/mixed; boundary="MOxbylmV4dcuCgHwAoK6NprGhlsfNkEcf" --MOxbylmV4dcuCgHwAoK6NprGhlsfNkEcf Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 21.01.20 14:48, Vladimir Sementsov-Ogievskiy wrote: > 21.01.2020 15:39, Max Reitz wrote: >> On 21.01.20 11:40, Vladimir Sementsov-Ogievskiy wrote: >>> 21.01.2020 12:41, Max Reitz wrote: >>>> On 21.01.20 10:23, Vladimir Sementsov-Ogievskiy wrote: >>>>> 21.01.2020 12:14, Max Reitz wrote: >>>>>> On 20.01.20 18:20, Vladimir Sementsov-Ogievskiy wrote: >>>>>>> 20.01.2020 20:04, Max Reitz wrote: >>>>>>>> On 16.01.20 16:54, Vladimir Sementsov-Ogievskiy wrote: >>>>>>>>> This test checks that bug is really fixed by previous commit. >>>>>>>>> >>>>>>>>> Cc: qemu-stable@nongnu.org # v4.2.0 >>>>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>>>>>>>> --- >>>>>>>>> tests/qemu-iotests/283 | 75 ++++++++++++++++++++++++++++= ++++++++++ >>>>>>>>> tests/qemu-iotests/283.out | 8 ++++ >>>>>>>>> tests/qemu-iotests/group | 1 + >>>>>>>>> 3 files changed, 84 insertions(+) >>>>>>>>> create mode 100644 tests/qemu-iotests/283 >>>>>>>>> create mode 100644 tests/qemu-iotests/283.out >>>>>>>> >>>>>>>> The test looks good to me, I just have a comment nit and a note on= the >>>>>>>> fact that this should probably be queued only after Thomas=E2=80= =99s =E2=80=9CEnable >>>>>>>> more iotests during "make check-block"=E2=80=9D series. >>>>>>>> >>>>>>>>> diff --git a/tests/qemu-iotests/283 b/tests/qemu-iotests/283 >>>>>>>>> new file mode 100644 >>>>>>>>> index 0000000000..f0f216d109 >>>>>>>>> --- /dev/null >>>>>>>>> +++ b/tests/qemu-iotests/283 >>>>>>>>> @@ -0,0 +1,75 @@ >>>>>>>>> +#!/usr/bin/env python >>>>>>>>> +# >>>>>>>>> +# Test for backup-top filter permission activation failure >>>>>>>>> +# >>>>>>>>> +# Copyright (c) 2019 Virtuozzo International GmbH. >>>>>>>>> +# >>>>>>>>> +# This program is free software; you can redistribute it and/or = modify >>>>>>>>> +# it under the terms of the GNU General Public License as publis= hed by >>>>>>>>> +# the Free Software Foundation; either version 2 of the License,= or >>>>>>>>> +# (at your option) any later version. >>>>>>>>> +# >>>>>>>>> +# This program is distributed in the hope that it will be useful= , >>>>>>>>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>>>>>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>>>>>> +# GNU General Public License for more details. >>>>>>>>> +# >>>>>>>>> +# You should have received a copy of the GNU General Public Lice= nse >>>>>>>>> +# along with this program. If not, see . >>>>>>>>> +# >>>>>>>>> + >>>>>>>>> +import iotests >>>>>>>>> + >>>>>>>>> +# The test is unrelated to formats, restrict it to qcow2 to avoi= d extra runs >>>>>>>>> +iotests.verify_image_format(supported_fmts=3D['qcow2']) >>>>>>>>> + >>>>>>>>> +size =3D 1024 * 1024 >>>>>>>>> + >>>>>>>>> +""" >>>>>>>>> +On activation, backup-top is going to unshare write permission o= n its >>>>>>>>> +source child. It will be impossible for the following configurat= ion: >>>>>>>> >>>>>>>> =E2=80=9CThe following configuration will become impossible=E2=80= =9D? >>>>>>> >>>>>>> Hmm, no, the configuration is possible. But "it", i.e. "unshare wri= te permission", >>>>>>> is impossible with such configuration.. >>>>>> >>>>>> But backup_top always unshares the write permission on the source. >>>>> >>>>> Yes, and I just try to say, that this action will fail. And the test = checks that it >>>>> fails (and it crashes with current master instead of fail). >>>> >>>> OK. So what I was trying to say is that the comment currently only >>>> states that this will fail. I=E2=80=99d prefer it to also reassure me= that it=E2=80=99s >>>> correct that this fails (because all writes on the backup source must = go >>>> through backup_top), and that this is exactly what we want to test her= e. >>>> >>>> On first reading, I was wondering why exactly this comment would tell = me >>>> all these things, because I didn=E2=80=99t know what the test wants to= test in >>>> the first place. >>>> >>>> Max >>> >>> Hmm, something like: >>> >>> Backup wants to copy a point-in-time state of the source node. So, it c= atches all writes >>> to the source node by appending backup-top filter above it. So we handl= e all changes which >>> comes from source node parents. To prevent appearing of new writing par= ents during the >>> progress, backup-top unshares write permission on its source child. Thi= s has additional >>> implication: as this "unsharing" is propagated by default by backing/fi= le children, >>> backup-top conflicts with any side parents of source sub-tree with writ= e permission. >>> And this is in good relation with the general idea: with such parents w= e can't guarantee >>> point-in-time backup. >> >> Works for me (thanks :-)), but a shorter =E2=80=9CWhen performing a back= up, all >> writes on the source subtree must go through the backup-top filter so it >> can copy all data to the target before it is changed. Therefore, >> backup-top cannot allow other nodes to change data on its source child.= =E2=80=9D >> would work for me just as well. >> >>> So, trying to backup the configuration with writing side parents of >>> source sub-tree nodes should fail. Let's test it. >=20 > But than, we need somehow link part about appending backup-top and so-on.= .. >=20 > When performing a backup, all writes on the source subtree must go throug= h the backup-top filter so it can copy all data to the target before it is = changed. > backup-top filter is appended above source node, to achieve this thing, s= o all parents of source node are handled. > A configuration with side parents of source sub-tree with write permissio= n is unsupported (we'd have append several backup-top filter like nodes to = handle such parents). > The test create an example of such configuration and checks that backup f= ails. Sounds good! (Except maybe s/that backup fails/that a backup is then not allowed/? =E2=80=9Cbackup fails=E2=80=9D might also mean that the job just produces g= arbage.) Max --MOxbylmV4dcuCgHwAoK6NprGhlsfNkEcf-- --8R0So51TRF9pGUyQaW8Avl4BW4VWvu8hB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl4nAdQACgkQ9AfbAGHV z0CIewf/TxgDyjDNTKjcR4jyOncw85uAy1BWw7DDG+233s4Qdm4DRROf75gx+mSs 08S+/b1YaaPHJPRanOvezkIj7ibyt+pL1Ek/j3AK/0qFd5jMSJCtV5tY30oBIgQh oKEGjwWdZ36bYynymimCpMCGxhSBxN71IM2woqLsDSIvwgtTCq1XqCkJRjrdUSDj FaZF0YskY8tDUPOLP6L6sZrW77pL+KFbHkTHw+Ndt9Czqd4TFGFjlSsKmiZu4ZFx qb14GhFcDLgH2Gbw9Zl8VNd9nmkTMS7YRlaqiCIU2Aza+W7r2lckiq5J74KwELCJ qulpmVq8Zz3fZTSEjx1oKs/L32okUw== =VExs -----END PGP SIGNATURE----- --8R0So51TRF9pGUyQaW8Avl4BW4VWvu8hB--