From: Nish Aravamudan Date: Sun, 06 Feb 2005 22:19:29 +0000 Subject: Re: [KJ] Re: [PATCH 19/20] bluetooth/bluecard_cs: remove Message-Id: <29495f1d050206141977a6b4fa@mail.gmail.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============65989064418438259==" List-Id: References: <20050202225855.GY2546@us.ibm.com> <1107386189.11944.21.camel@pegasus> <20050203002502.GB2546@us.ibm.com> <1107562301.6921.115.camel@pegasus> In-Reply-To: <1107562301.6921.115.camel@pegasus> To: Marcel Holtmann Cc: Nishanth Aravamudan , kernel-janitors@lists.osdl.org, BlueZ Mailing List , Max Krasnyansky --===============65989064418438259== Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 05 Feb 2005 01:11:41 +0100, Marcel Holtmann wrote: > Hi Nish, > > > > > Please consider applying. > > > > > > > > Description: Remove deprecated interruptible_sleep_on_timeout() function calls > > > > and replace with direct wait-queue usage. Some naming conflicts occurred, which > > > > I tried to resolve appropriately. Patch is compile-tested. > > > > > > you introduce more code than you remove. Is our code a special case or > > > why don't exists a simple API function as replacement? > > > > Yes, I do. *sleep_on*() was the API, which has been replaced with wait_event*(). > > However, wait_event*() explicitly needs a condition (the "event"), which in > > thise case does not exist. If I had more background, I would have gone the > > wait_event*() route. I am looking into a better API to mask away all of the > > DEFINE_WAIT(), prepare_to_wait(), schedule()/schedule_timeout(), finish_wait() > > additions (the KJ list can attest to how many of these replacements I'm doing), > > but there simply does not exist such an API right now. > > > > Any input you could provide, though, would be greatly appreciated. > > I gave your patch a shot and the oops below happens on a 2.6.11-rc3 > after plugging in the card. Without the patch it is working. Sorry for the long delay without a response! That looks like I may have missed some wake-up related issues. I'll check on it and get back to you soon. Thanks, Nish --===============65989064418438259== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============65989064418438259==--