From: David Howells Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] Date: Tue, 29 Aug 2006 14:47:16 +0100 Message-ID: <29516.1156859236@warthog.cambridge.redhat.com> References: <200608281352.58281.arnd.bergmann@de.ibm.com> <20060825200455.GA2629@uranus.ravnborg.org> <20060825193707.11384.97372.stgit@warthog.cambridge.redhat.com> <22040.1156537104@warthog.cambridge.redhat.com> Cc: David Howells , Sam Ravnborg , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:57043 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750714AbWH2Nrb (ORCPT ); Tue, 29 Aug 2006 09:47:31 -0400 In-Reply-To: <200608281352.58281.arnd.bergmann@de.ibm.com> To: Arnd Bergmann Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Arnd Bergmann wrote: > You could write it as > > bounce-$(CONFIG_MMU) += bounce.o > obj-$(CONFIG_BLOCK) += $(bounce-y) I could, yes, but why? What does it buy? I think this: ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy) obj-y += bounce.o endif is clearer. David