Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC92821ADC7 for ; Wed, 7 Jan 2026 14:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767797960; cv=none; b=OkbY1arg4i07zyq6s0FzBoo7uV6n05y6duS6adaSM3u5ak+P9iHQoL07el2mMbm5zqm1opmS6GZYr3J03xtbuSRbmIJiVQuO5A5ete7yEvMsbE8dzrgW6lTwz7f4lHAZp6jzTqXgSq//pkydoJuOSrCiwU+T0lY4JbL+KHOvies= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767797960; c=relaxed/simple; bh=lZz8ZAu8vrs8Ru98ohAatnW1AHr7PhD4PTK1H1/KWrk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=anpnnHIbO5LrduDhGWX72/IeW7wiOBbAFXGRzs5gxEhJ4Pve79FFLggtf95rGE2a8eeZ6ANCBBm7phIAKPYy15m1YW6ubY1mo/nuo12SM8Gh2s+fGqdUDcFE0hYaJVsNlxo/nthiIBDr+A/k7bAIqKpYROSmQskCgbW7cNECKv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YziDo8/j; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YziDo8/j" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-432755545fcso1252376f8f.1 for ; Wed, 07 Jan 2026 06:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767797957; x=1768402757; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=SV1cZScFIWK8ylac8dKg4D7bUheGaqaRyP9KVJQ7iTw=; b=YziDo8/jjXzxLszplOUg1Yx6muPbjxZOE7bZ4LgGXuDk12djjYrsTa/4ZKQv2OSYjo /twTzpNbYWievfgD0Wy4NGc6q/mDd1YTJ4ljI7aPky8IscuhbuY35FVMA5m7sNnfGvnY //zEpK9WlpsGVuIRrpA8YRrFKk2+dVeHA1ZfdB+s4vJygrojTPAwc3VQXyDwwOTuizuG D4k2ytcIy0nkM/8iah+f+CR5+V+7KLkKA9JNyFEKwbsqJO4NbNpj4iYxrS5RnZc6yjov Vkp/ppKjuvvo/xEQ3I5Tb2Ffmm46xG87x8hmdcQV0mBGBv7m+jV80sAF0RK4xv/pxSNH 8Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767797957; x=1768402757; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SV1cZScFIWK8ylac8dKg4D7bUheGaqaRyP9KVJQ7iTw=; b=ml8z3LXmA2jqRHOhufN/Vb0CtCNySo0fHqTb7AGJama3qqek8aGUqY7GueUJzN59xk eKP4cPfVy+WOVidEeDyiC7Wkfe8kAT4McU0h+oAjZfVH+VPZjNpf3I3/58WV904D7vWS A0SERW8nRhCM2haGHd0V9o7Ufd200XFfuVgerYCUv1/Acak/jMIZaSfzBTvCjKeHZhWs uOqaiGyJta5ahct62gPPd8qsU0Z7JoZgEMfIU4Rn++27lJFenRdjVmrSyxrCEBhX/PAr QUabgEJ3xvDxYaBfxll22gmhMss4v4n19HTjobxL9w9kSCCXEePM0eXuwonXTsQ+/4bL 6kaA== X-Forwarded-Encrypted: i=1; AJvYcCX1wJS05haLvC1ETuxjDNJnK472xL4uMKLcCgSQ6QC6uJ9GrurLYePgtkDjbzAEwjmEbNuHtXDbnDq23CfjBuk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9ApfvNVtbu7PN5RdSK3UwX59AV6MlRcjX7ICA9/kC1AOPFy+J F11/ueMTaQHFI9LcMeUROWRvcrUP3jHaNtyvBTBSYRHp2eG3agDQGGwQu4nKug== X-Gm-Gg: AY/fxX6C43xN4g4wipo32AN3/GE4aQ13jKZ57PQb1Gb80uQYSjghTpDBRD1LpDNhPpv dSnZJqR/m7rQfV5eROU/gASiCTK9dE4Jd0f32wBREjQUmmu9Uc1Wk4Nfi3q6ghwEBgbBEenSXS+ u78capZ1dYUJaAay3xFbCv8ySt/nQdCkNe5QLFJ0pqOQKOm9a1CfcOZfvKPZhESt4Rm0al3p5yK x9+Atgu1h5tSKTvvln5kLyAn2/BnDuRGNTWdaKv4k4WT4Ger7e8BbozSzD5r3OxJZh4IeLNnVU1 hHiYuXmUb5r/lYa/Is9k16faj8zgMcXWAPKFo4N6wdqTiqwDURqR4NTqmDQCqNXQzejJCKOHkdh MnqHA5lfLXLGsomestwlPOQsmXfxUj3LPJEcjGNzTq+aF51R0IOncfm8kuuVvqN7r6iwBXGRgXe v14dTRbtzKz8yMY0+6angviD5g2ceoJu8Vt2128OGdYY7EtbXKRlTy3PdX882n5MmtS70= X-Google-Smtp-Source: AGHT+IG1YououSj/EXDwxzVarDQZ72uogU8BTCNy+0HLyFRU+zonnThKVMk8YKlAXuXT6L0Z4fcuMQ== X-Received: by 2002:a5d:5d11:0:b0:432:c0e6:cfcd with SMTP id ffacd0b85a97d-432c3632bc5mr3400757f8f.22.1767797957100; Wed, 07 Jan 2026 06:59:17 -0800 (PST) Received: from 0.1.2.1.2.0.a.2.dynamic.cust.swisscom.net ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10690182f8f.31.2026.01.07.06.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 06:59:16 -0800 (PST) Message-ID: <297860d547bb93b794e7b1cee4eb7b93b9e05e9d.camel@gmail.com> Subject: Re: [PATCH net-next] selftests: forwarding: update PTP tcpdump patterns From: Alexander Sverdlin To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Wed, 07 Jan 2026 15:59:17 +0100 In-Reply-To: <20260107145320.1837464-1-kuba@kernel.org> References: <20260107145320.1837464-1-kuba@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Jakub, On Wed, 2026-01-07 at 06:53 -0800, Jakub Kicinski wrote: > Recent version of tcpdump (tcpdump-4.99.6-1.fc43.x86_64) seems to have > removed the spurious space after msg type in PTP info, e.g.: >=20 > =C2=A0before:=C2=A0 PTPv2, majorSdoId: 0x0, msg type : sync msg, length: = 44 > =C2=A0after:=C2=A0=C2=A0 PTPv2, majorSdoId: 0x0, msg type: sync msg, leng= th: 44 >=20 > Update our patterns to match both. >=20 > Signed-off-by: Jakub Kicinski Reviewed-by: Alexander Sverdlin > --- > CC: shuah@kernel.org > CC: vladimir.oltean@nxp.com > CC: alexander.sverdlin@gmail.com > CC: linux-kselftest@vger.kernel.org > --- > =C2=A0.../net/forwarding/local_termination.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 18 +++++++++--------- > =C2=A01 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh = b/tools/testing/selftests/net/forwarding/local_termination.sh > index 892895659c7e..1f2bf6e81847 100755 > --- a/tools/testing/selftests/net/forwarding/local_termination.sh > +++ b/tools/testing/selftests/net/forwarding/local_termination.sh > @@ -306,39 +306,39 @@ run_test() > =C2=A0 > =C2=A0 if [ $skip_ptp =3D false ]; then > =C2=A0 check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \ > - "ethertype PTP (0x88f7).* PTPv2.* msg type : sync msg" \ > + "ethertype PTP (0x88f7).* PTPv2.* msg type *: sync msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \ > - "ethertype PTP (0x88f7).* PTPv2.* msg type : follow up msg" \ > + "ethertype PTP (0x88f7).* PTPv2.* msg type *: follow up msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Requ= est" \ > - "ethertype PTP (0x88f7).* PTPv2.* msg type : peer delay req msg" \ > + "ethertype PTP (0x88f7).* PTPv2.* msg type *: peer delay req msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \ > - "ethertype IPv4 (0x0800).* PTPv2.* msg type : sync msg" \ > + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: sync msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \ > - "ethertype IPv4 (0x0800).* PTPv2.* msg type : follow up msg" \ > + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: follow up msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \ > - "ethertype IPv4 (0x0800).* PTPv2.* msg type : peer delay req msg" \ > + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: peer delay req msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \ > - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : sync msg" \ > + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: sync msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \ > - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : follow up msg" \ > + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: follow up msg" \ > =C2=A0 true "$test_name" > =C2=A0 > =C2=A0 check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \ > - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : peer delay req msg" \ > + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: peer delay req msg" \ > =C2=A0 true "$test_name" > =C2=A0 fi > =C2=A0 --=20 Alexander Sverdlin.