From: David Howells Subject: Re: [PATCH 0/5] Permit NFS superblock sharing [try #3] Date: Mon, 06 Mar 2006 11:55:54 +0000 Message-ID: <29932.1141646154@warthog.cambridge.redhat.com> References: <20060304041647.6894ca62.akpm@osdl.org> <20060302213356.7282.26463.stgit@warthog.cambridge.redhat.com> Cc: David Howells , torvalds@osdl.org, steved@redhat.com, trond.myklebust@fys.uio.no, aviro@redhat.com, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:19668 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751278AbWCFL4I (ORCPT ); Mon, 6 Mar 2006 06:56:08 -0500 In-Reply-To: <20060304041647.6894ca62.akpm@osdl.org> To: Andrew Morton Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > The same happens with just #1 and #2 applied. The .config is at > http://www.zip.com.au/~akpm/linux/patches/stuff/config-vmm. Just #1 and #2? That's decidedly odd. Also odd is that it's _nfsd_ that's affected, not nfs. It also affects binfmt_misc, so it appears that it's something to do with get_sb_single(), and looking at that function, I can sort of see why it might be. I'll look into it further. > The kernel won't compile with just patch #1 applied. Patches shouldn't go > into git in that manner. It's easier to review them in that manner. If you don't think git is up to it, then combine them. David