Received: from eggs.gnu.org ([2001:4830:134:3::10]:51799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Vj3-0001zn-9n for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Vj0-0000Kg-3Y for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:46:53 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:54675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Viz-0000Ka-RD for qemu-devel@nongnu.org; Wed, 25 Nov 2015 03:46:50 -0500 Date: Wed, 25 Nov 2015 03:46:43 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <299465195.17021991.1448441203580.JavaMail.zimbra@redhat.com> In-Reply-To: <87mvu2ii6t.fsf@blackfin.pond.sub.org> References: <1448384789-14830-1-git-send-email-armbru@redhat.com> <1448384789-14830-5-git-send-email-armbru@redhat.com> <1442536458.16567531.1448385430286.JavaMail.zimbra@redhat.com> <87ziy3pap5.fsf@blackfin.pond.sub.org> <401942375.16589360.1448386975444.JavaMail.zimbra@redhat.com> <87a8q3mdox.fsf@blackfin.pond.sub.org> <1528668622.16663640.1448394742657.JavaMail.zimbra@redhat.com> <87mvu2ii6t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre lureau , claudio fontana , qemu-devel@nongnu.org, Paolo Bonzini Hi ----- Original Message ----- > Marc-Andr=C3=A9 Lureau writes: >=20 > > ----- Original Message ----- > >> Marc-Andr=C3=A9 Lureau writes: > >>=20 > >> > Hi > >> > > >> > ----- Original Message ----- > >> >> Marc-Andr=C3=A9 Lureau writes: > >> >>=20 > >> >> > ----- Original Message ----- > >> >> >> Signed-off-by: Markus Armbruster > >> >> >> --- > >> >> >> hw/misc/ivshmem.c | 1 + > >> >> >> 1 file changed, 1 insertion(+) > >> >> >>=20 > >> >> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > >> >> >> index 83d7bd3..a6bfdde 100644 > >> >> >> --- a/hw/misc/ivshmem.c > >> >> >> +++ b/hw/misc/ivshmem.c > >> >> >> @@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *d= ev, > >> >> >> Error > >> >> >> **errp) > >> >> >> memory_region_add_subregion(&s->bar, 0, mr); > >> >> >> pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); > >> >> >> } else if (s->server_chr !=3D NULL) { > >> >> >> + /* FIXME replace this test, it works basically by chanc= e */ > >> >> > > >> >> > I wouldn't say it like that, but ack anyway. > >> >>=20 > >> >> I'm happy to consider a rephrased comment. > >> > > >> > Although Paolo used "chance" too, I think the proper comment would b= e > >> > the following: > >> > > >> > FIXME: only pty and socket chardevs set chr->filename, other set to > >> > the default---the backend name. > >>=20 > >> I'm afraid that doesn't convey what needs fixing. > >>=20 > >> > ie, to me it's not just by "chance" :) > >>=20 > >> Well, it's certainly not by design! > >>=20 > >> What about: > >>=20 > >> + /* FIXME do not rely on what chr drivers put into filename */ > > > > ack >=20 > Will you prepare a pull request, or would you like me to do it? >=20 Please do it (I am not the ivshmem maintainer ;)