From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [Patch] fix canonicalize-existing vbd file
Date: Wed, 05 Dec 2007 23:05:20 +0900
Message-ID: <2C83747DEF0A9takebe_akio@jp.fujitsu.com>
References: <C37C2C00.1966D%Keir.Fraser@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Boundary-qnfjs685SmVeRcIhIPKpv"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C37C2C00.1966D%Keir.Fraser@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-devel <xen-devel@lists.xensource.com>
Cc: Akio Takebe <takebe_akio@jp.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

--Boundary-qnfjs685SmVeRcIhIPKpv
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Content-Description: Mail message body

Hi, Keir

>The -e option is not available in all versions of readlink.
Thank you for your review.
How about the blew?

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>


---
diff -r 3057f813da14 tools/examples/block
--- a/tools/examples/block	Thu Nov 29 19:30:33 2007 +0000
+++ b/tools/examples/block	Wed Dec 05 22:57:56 2007 +0900
@@ -219,7 +219,8 @@ case "$command" in
       file)
         # Canonicalise the file, for sharing check comparison, and the mode
         # for ease of use here.
-        file=$(readlink -f "$p") || fatal "$p does not exist."
+        test -f "$p" || fatal "$p does not exist."
+        file=$(readlink -f "$p")
         mode=$(canonicalise_mode "$mode")
 
         claim_lock "block"

--Boundary-qnfjs685SmVeRcIhIPKpv
Content-Type: application/octet-stream;
	name="fix_check-existing_vbd_file.patch"
Content-Disposition: attachment; filename="fix_check-existing_vbd_file.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtciAzMDU3ZjgxM2RhMTQgdG9vbHMvZXhhbXBsZXMvYmxvY2sKLS0tIGEvdG9vbHMv
ZXhhbXBsZXMvYmxvY2sJVGh1IE5vdiAyOSAxOTozMDozMyAyMDA3ICswMDAwCisrKyBiL3Rv
b2xzL2V4YW1wbGVzL2Jsb2NrCVdlZCBEZWMgMDUgMjI6NTc6NTYgMjAwNyArMDkwMApAQCAt
MjE5LDcgKzIxOSw4IEBAIGNhc2UgIiRjb21tYW5kIiBpbgogICAgICAgZmlsZSkKICAgICAg
ICAgIyBDYW5vbmljYWxpc2UgdGhlIGZpbGUsIGZvciBzaGFyaW5nIGNoZWNrIGNvbXBhcmlz
b24sIGFuZCB0aGUgbW9kZQogICAgICAgICAjIGZvciBlYXNlIG9mIHVzZSBoZXJlLgotICAg
ICAgICBmaWxlPSQocmVhZGxpbmsgLWYgIiRwIikgfHwgZmF0YWwgIiRwIGRvZXMgbm90IGV4
aXN0LiIKKyAgICAgICAgdGVzdCAtZiAiJHAiIHx8IGZhdGFsICIkcCBkb2VzIG5vdCBleGlz
dC4iCisgICAgICAgIGZpbGU9JChyZWFkbGluayAtZiAiJHAiKQogICAgICAgICBtb2RlPSQo
Y2Fub25pY2FsaXNlX21vZGUgIiRtb2RlIikKIAogICAgICAgICBjbGFpbV9sb2NrICJibG9j
ayIK

--Boundary-qnfjs685SmVeRcIhIPKpv
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--Boundary-qnfjs685SmVeRcIhIPKpv--