From: "stipa (Code Review)" Date: Tue, 3 Dec 2024 10:42:48 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2a60b90f6ec049ac566609923def0059fe656175-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="nyi8KD/DNU8="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: flichtenheld , plaisthos , openvpn-devel --nyi8KD/DNU8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 6: (1 comment) File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/b5d51f26_68cd5be8 : PS6, Line 543: msg(M_WARN, "No option found"); > I put it to avoid that in case of a correct message but without updates (= something like "PUSH_UPDATE [=E2=80=A6] How about "No updatable options found in incoming PUSH_UPDATE message" - I = think it is verbose enough to let user/admin know what has happened. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 6 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Tue, 03 Dec 2024 10:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: mrbff Comment-In-Reply-To: stipa Gerrit-MessageType: comment --nyi8KD/DNU8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/push.c:

    • Patch Set #6, Line 543: msg(M_WAR= N, "No option found");

      I put it to avoid th= at in case of a correct message but without updates (something like "P= USH_UPDATE [=E2=80=A6]

      How about "No updatable options found in incomi= ng PUSH_UPDATE message" - I think it is verbose enough to let user/adm= in know what has happened.

To view, visit change 808. = To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 6
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Tue, 03 Dec 2024 10:42:48= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mrbff <marco@...2804...= .>
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--nyi8KD/DNU8=--