Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81FE8C38145 for ; Thu, 8 Sep 2022 19:31:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96D9C84AF4; Thu, 8 Sep 2022 21:31:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="BH750So5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9630384B0F; Thu, 8 Sep 2022 21:31:35 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 088DC84A5B for ; Thu, 8 Sep 2022 21:31:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1662665490; bh=imb7KHOZnu6ETZXw+EJUOgYKDALO88fjQanMC5uCRHg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=BH750So5jZVE29ZdCk4kXLGaS0HnqjN7tfvBnHTuD9bdrlEAy46XZ09/lnAjAhvlX SR1sJqsLu6kpx5ElcX5z5/YVi1y133QWio5kqO7EoGRGHJDk6mRhLEyc7Yg/NCbwDE yQHMwgs1zRtd5g+AWL5FmVMUzMfTyZdWtJMMH624= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.94] ([84.118.157.2]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M7JzQ-1oQu8E0SZo-007kFS; Thu, 08 Sep 2022 21:31:30 +0200 Message-ID: <2a65b417-1d5b-e013-4d59-cfc2b2116632@gmx.de> Date: Thu, 8 Sep 2022 21:31:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v1] 3: Added dcp_rng driver device binding code Content-Language: en-US To: Simon Glass , Kshitiz Varshney Cc: U-Boot Mailing List , Horia Geanta , Pankaj Gupta , Varun Sethi , Gaurav Jain , Rahul Kumar Yadav , Vabhav Sharma , Sahil Malhotra , Ye Li , Stefano Babic , Fabio Estevam , Peng Fan , Sughosh Ganu References: <20220908085735.437808-1-kshitiz.varshney@nxp.com> <20220908085735.437808-3-kshitiz.varshney@nxp.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wouaM/Rp32OzJKfm/3Ogc9BtLl7AxNG/3fIXlT8rtFIOw44lWCw cZs1BRLb8dapXTU16SG0JzP8eEI6ALlLCXeS61WqBOumpVN91YICWf3YycBhT3CaCpiGW7+ NsjKtdBbpQiPSZISYuIBUWDWaJ/lnIpw57BFoFZY9SxQNCRppxQLjIlL4eC4P6RgR5yCfAn 9grfL4gLR8I+U7eTvJ9/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:7grxa1oaI7U=:43KD9wxOFdcO1LMEpV8CmD sv8fiykkQAktIqqrffwCdK+JRwbv8XSJsGXLWxiGSnmjVEde5+vX5FE+hB6Lm/EhqeU25XdR9 5kRkip4b1tu6EfDEHLcEqHjMEcwFYNdQ70DOFhmxuGgH2cxheVrC0MoHSGobQqJ7fov6A7J1d mHXz8XeHcricyY243lHEE57e/26sAG/1/Hw/ST64qc0pYGLmohMRtKXt4kvCOcDUkEEFQE2Mk bffEoWub7wzZitsiOYdhanRVumQUlr1jNqLvh13Q1nioG6J44qGcgWN6D7I1QDGuxAK39R0/L go+1f/nP1s/gUPRoU3YTJFOUD4M9pa8/auk47aZq6ZAGJU4dRvOH8LgvQCg90mlUX7eyN4XK7 MBDKdC1uzUoJbQfr11oicIB2SW5+0DLfph9dTcOliqqTmiTRf0eEkN6YsiHM2PQ3fnEQmJ/TU FuMB01Z4v8zss8YKktqRgZAdNjlNryud05QevIR24soXUvedp7UURIJizq3l4r3CuPXG6YpTt nsglu4Vz5pzZdB5XaPi6NoqfVRH+sfwoloTC6YgnigOa9mCID3jXvRdC31wCUxDnP/oVs+pgl VeCJY2jtLvPIwfMuihu2h2K35rzjFptroMl85wLDgT3qgiMXAxVB5Fpg4fteTVIEl5lDZOAOb /CkkA7W7WVUk732mr+VCqUSOzkzrc1YtG8KDXpEvqBofGeX08DXcX9NpvdhvZi6rccx4vrYfN 6lTiSN7FSj8166v63NaXfCrdTcYsC+FVaawNkDQEY7PgtnuiET0csC6rRnTGaSrqZ4QZmwhU3 gVjuTetO9YHMVpmWGfGWVImm7/MsYOE7iU7yLEUm5ssQRkjdbpsfhMEDxPJRU2WOOhrWIm1sd eVdC37ihREFrlhsk0xPGgNH65/toSS7rMX007XWRUIChQJLIrauNvMTUad7y7NPtAGfna2Alz KVgyxtVwy/LQrxSS5BNpa7PPCLah+l7PzzCKTUz7jocAt5RLTdQNMtFfVEZMbFjvSyruKYF0N ZCUKXzgKN67+5Amtea44QuT7hhT2WV+SCTXF3Ts0qAOEMFopJHB0HeqyVz8ij7q7CDjFdCsUA D5xpaEKJaNAHv2rhZwwzyyZowjcAVFnl6eKLh17I+smwcRgO4pz/LM18Rbur3v7M9QXqhDaGO seBTte0QE0gyGA8oLNxTvXNR32 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/8/22 20:18, Simon Glass wrote: > Hi Kshitiz, > > +Ilias Apalodimas > > > On Thu, 8 Sept 2022 at 02:59, Kshitiz Varshney wrote: >> >> From: Kshitiz >> >> This commit manually binds dcp_rng device driver and initalizes it insi= de >> arch_misc_init() function. >> >> Signed-off-by: Kshitiz Varshney >> Reviewed-by: Ye Li CC the maintainer of RNG Sughosh Ganu >> --- >> arch/arm/mach-imx/mx6/soc.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c >> index 3e538754d9..9bf16119c2 100644 >> --- a/arch/arm/mach-imx/mx6/soc.c >> +++ b/arch/arm/mach-imx/mx6/soc.c >> @@ -31,6 +31,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> DECLARE_GLOBAL_DATA_PTR; >> >> @@ -1005,6 +1007,20 @@ int arch_misc_init(void) >> if (ret) >> printf("Failed to initialize caam_jr: %d\n", r= et); >> } >> + >> + if (IS_ENABLED(CONFIG_FSL_DCP_RNG)) { >> + struct udevice *dev; >> + int ret; >> + >> + ret =3D device_bind_driver(NULL, "dcp_rng", "dcp_rng", = NULL); > > This needs to be in the device tree. This it the kind of madness I was > warning about with Ilias, so I have copied him here. > > We need to stop manually binding devices when they should be in the DT. > >> + if (ret) >> + printf("Couldn't bind dcp rng driver (%d)\n", r= et); >> + >> + ret =3D uclass_get_device_by_driver(UCLASS_RNG, DM_DRIV= ER_GET(dcp_rng), &dev); >> + if (ret) >> + printf("Failed to initialize dcp rng: %d\n", re= t); >> + } >> + >> setup_serial_number(); >> return 0; >> } >> -- >> 2.25.1 >> > > Regards, > SImon