From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/5] drm/amdgpu: move ring macros into amdgpu_ring header Date: Fri, 3 Aug 2018 13:16:28 +0200 Message-ID: <2a85ee73-0495-073f-d913-d881fc06df22@gmail.com> References: <1533294709-13622-1-git-send-email-ray.huang@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1533294709-13622-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Huang Rui , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMDMuMDguMjAxOCB1bSAxMzoxMSBzY2hyaWViIEh1YW5nIFJ1aToKPiBEZW1hbmdsZSBhbWRn cHUuaC4KPgo+IFNpZ25lZC1vZmYtYnk6IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+CgpB Y2tlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPiBmb3Ig dGhlIGVudGlyZSBzZXJpZXMuCgpUaGFua3MgYSBsb3QgZm9yIHRha2luZyBjYXJlIG9mIHRoaXMs CkNocmlzdGlhbi4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUu aCAgICAgIHwgMjMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmggfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPiAg IDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IGluZGV4IGUzNzQzZWIuLmE1MDA0NjYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IEBAIC0xMjYxLDI5ICsxMjYxLDYg QEAgaW50IGVtdV9zb2NfYXNpY19pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsKPiAg ICNkZWZpbmUgYW1kZ3B1X3ZtX2NvcHlfcHRlKGFkZXYsIGliLCBwZSwgc3JjLCBjb3VudCkgKChh ZGV2KS0+dm1fbWFuYWdlci52bV9wdGVfZnVuY3MtPmNvcHlfcHRlKChpYiksIChwZSksIChzcmMp LCAoY291bnQpKSkKPiAgICNkZWZpbmUgYW1kZ3B1X3ZtX3dyaXRlX3B0ZShhZGV2LCBpYiwgcGUs IHZhbHVlLCBjb3VudCwgaW5jcikgKChhZGV2KS0+dm1fbWFuYWdlci52bV9wdGVfZnVuY3MtPndy aXRlX3B0ZSgoaWIpLCAocGUpLCAodmFsdWUpLCAoY291bnQpLCAoaW5jcikpKQo+ICAgI2RlZmlu ZSBhbWRncHVfdm1fc2V0X3B0ZV9wZGUoYWRldiwgaWIsIHBlLCBhZGRyLCBjb3VudCwgaW5jciwg ZmxhZ3MpICgoYWRldiktPnZtX21hbmFnZXIudm1fcHRlX2Z1bmNzLT5zZXRfcHRlX3BkZSgoaWIp LCAocGUpLCAoYWRkciksIChjb3VudCksIChpbmNyKSwgKGZsYWdzKSkpCj4gLSNkZWZpbmUgYW1k Z3B1X3JpbmdfcGFyc2VfY3MociwgcCwgaWIpICgociktPmZ1bmNzLT5wYXJzZV9jcygocCksIChp YikpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX3BhdGNoX2NzX2luX3BsYWNlKHIsIHAsIGliKSAo KHIpLT5mdW5jcy0+cGF0Y2hfY3NfaW5fcGxhY2UoKHApLCAoaWIpKSkKPiAtI2RlZmluZSBhbWRn cHVfcmluZ190ZXN0X3JpbmcocikgKHIpLT5mdW5jcy0+dGVzdF9yaW5nKChyKSkKPiAtI2RlZmlu ZSBhbWRncHVfcmluZ190ZXN0X2liKHIsIHQpIChyKS0+ZnVuY3MtPnRlc3RfaWIoKHIpLCAodCkp Cj4gLSNkZWZpbmUgYW1kZ3B1X3JpbmdfZ2V0X3JwdHIocikgKHIpLT5mdW5jcy0+Z2V0X3JwdHIo KHIpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2dldF93cHRyKHIpIChyKS0+ZnVuY3MtPmdldF93 cHRyKChyKSkKPiAtI2RlZmluZSBhbWRncHVfcmluZ19zZXRfd3B0cihyKSAociktPmZ1bmNzLT5z ZXRfd3B0cigocikpCj4gLSNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF9pYihyLCBpYiwgdm1pZCwg YykgKHIpLT5mdW5jcy0+ZW1pdF9pYigociksIChpYiksICh2bWlkKSwgKGMpKQo+IC0jZGVmaW5l IGFtZGdwdV9yaW5nX2VtaXRfcGlwZWxpbmVfc3luYyhyKSAociktPmZ1bmNzLT5lbWl0X3BpcGVs aW5lX3N5bmMoKHIpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfdm1fZmx1c2gociwgdm1p ZCwgYWRkcikgKHIpLT5mdW5jcy0+ZW1pdF92bV9mbHVzaCgociksICh2bWlkKSwgKGFkZHIpKQo+ IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfZmVuY2UociwgYWRkciwgc2VxLCBmbGFncykgKHIp LT5mdW5jcy0+ZW1pdF9mZW5jZSgociksIChhZGRyKSwgKHNlcSksIChmbGFncykpCj4gLSNkZWZp bmUgYW1kZ3B1X3JpbmdfZW1pdF9nZHNfc3dpdGNoKHIsIHYsIGRiLCBkcywgd2IsIHdzLCBhYiwg YXMpIChyKS0+ZnVuY3MtPmVtaXRfZ2RzX3N3aXRjaCgociksICh2KSwgKGRiKSwgKGRzKSwgKHdi KSwgKHdzKSwgKGFiKSwgKGFzKSkKPiAtI2RlZmluZSBhbWRncHVfcmluZ19lbWl0X2hkcF9mbHVz aChyKSAociktPmZ1bmNzLT5lbWl0X2hkcF9mbHVzaCgocikpCj4gLSNkZWZpbmUgYW1kZ3B1X3Jp bmdfZW1pdF9zd2l0Y2hfYnVmZmVyKHIpIChyKS0+ZnVuY3MtPmVtaXRfc3dpdGNoX2J1ZmZlcigo cikpCj4gLSNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF9jbnR4Y250bChyLCBkKSAociktPmZ1bmNz LT5lbWl0X2NudHhjbnRsKChyKSwgKGQpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfcnJl ZyhyLCBkKSAociktPmZ1bmNzLT5lbWl0X3JyZWcoKHIpLCAoZCkpCj4gLSNkZWZpbmUgYW1kZ3B1 X3JpbmdfZW1pdF93cmVnKHIsIGQsIHYpIChyKS0+ZnVuY3MtPmVtaXRfd3JlZygociksIChkKSwg KHYpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfcmVnX3dhaXQociwgZCwgdiwgbSkgKHIp LT5mdW5jcy0+ZW1pdF9yZWdfd2FpdCgociksIChkKSwgKHYpLCAobSkpCj4gLSNkZWZpbmUgYW1k Z3B1X3JpbmdfZW1pdF9yZWdfd3JpdGVfcmVnX3dhaXQociwgZDAsIGQxLCB2LCBtKSAociktPmZ1 bmNzLT5lbWl0X3JlZ193cml0ZV9yZWdfd2FpdCgociksIChkMCksIChkMSksICh2KSwgKG0pKQo+ IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfdG16KHIsIGIpIChyKS0+ZnVuY3MtPmVtaXRfdG16 KChyKSwgKGIpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX3BhZF9pYihyLCBpYikgKChyKS0+ZnVu Y3MtPnBhZF9pYigociksIChpYikpKQo+IC0jZGVmaW5lIGFtZGdwdV9yaW5nX2luaXRfY29uZF9l eGVjKHIpIChyKS0+ZnVuY3MtPmluaXRfY29uZF9leGVjKChyKSkKPiAtI2RlZmluZSBhbWRncHVf cmluZ19wYXRjaF9jb25kX2V4ZWMocixvKSAociktPmZ1bmNzLT5wYXRjaF9jb25kX2V4ZWMoKHIp LChvKSkKPiAgICNkZWZpbmUgYW1kZ3B1X2Rpc3BsYXlfdmJsYW5rX2dldF9jb3VudGVyKGFkZXYs IGNydGMpIChhZGV2KS0+bW9kZV9pbmZvLmZ1bmNzLT52YmxhbmtfZ2V0X2NvdW50ZXIoKGFkZXYp LCAoY3J0YykpCj4gICAjZGVmaW5lIGFtZGdwdV9kaXNwbGF5X2JhY2tsaWdodF9zZXRfbGV2ZWwo YWRldiwgZSwgbCkgKGFkZXYpLT5tb2RlX2luZm8uZnVuY3MtPmJhY2tsaWdodF9zZXRfbGV2ZWwo KGUpLCAobCkpCj4gICAjZGVmaW5lIGFtZGdwdV9kaXNwbGF5X2JhY2tsaWdodF9nZXRfbGV2ZWwo YWRldiwgZSkgKGFkZXYpLT5tb2RlX2luZm8uZnVuY3MtPmJhY2tsaWdodF9nZXRfbGV2ZWwoKGUp KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5o IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuaAo+IGluZGV4IGQyNDJi OWEuLjkwNjg5N2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3JpbmcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5n LmgKPiBAQCAtMjIxLDYgKzIyMSwzMCBAQCBzdHJ1Y3QgYW1kZ3B1X3Jpbmcgewo+ICAgI2VuZGlm Cj4gICB9Owo+ICAgCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfcGFyc2VfY3MociwgcCwgaWIpICgo ciktPmZ1bmNzLT5wYXJzZV9jcygocCksIChpYikpKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX3Bh dGNoX2NzX2luX3BsYWNlKHIsIHAsIGliKSAoKHIpLT5mdW5jcy0+cGF0Y2hfY3NfaW5fcGxhY2Uo KHApLCAoaWIpKSkKPiArI2RlZmluZSBhbWRncHVfcmluZ190ZXN0X3JpbmcocikgKHIpLT5mdW5j cy0+dGVzdF9yaW5nKChyKSkKPiArI2RlZmluZSBhbWRncHVfcmluZ190ZXN0X2liKHIsIHQpIChy KS0+ZnVuY3MtPnRlc3RfaWIoKHIpLCAodCkpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZ2V0X3Jw dHIocikgKHIpLT5mdW5jcy0+Z2V0X3JwdHIoKHIpKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX2dl dF93cHRyKHIpIChyKS0+ZnVuY3MtPmdldF93cHRyKChyKSkKPiArI2RlZmluZSBhbWRncHVfcmlu Z19zZXRfd3B0cihyKSAociktPmZ1bmNzLT5zZXRfd3B0cigocikpCj4gKyNkZWZpbmUgYW1kZ3B1 X3JpbmdfZW1pdF9pYihyLCBpYiwgdm1pZCwgYykgKHIpLT5mdW5jcy0+ZW1pdF9pYigociksIChp YiksICh2bWlkKSwgKGMpKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfcGlwZWxpbmVfc3lu YyhyKSAociktPmZ1bmNzLT5lbWl0X3BpcGVsaW5lX3N5bmMoKHIpKQo+ICsjZGVmaW5lIGFtZGdw dV9yaW5nX2VtaXRfdm1fZmx1c2gociwgdm1pZCwgYWRkcikgKHIpLT5mdW5jcy0+ZW1pdF92bV9m bHVzaCgociksICh2bWlkKSwgKGFkZHIpKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfZmVu Y2UociwgYWRkciwgc2VxLCBmbGFncykgKHIpLT5mdW5jcy0+ZW1pdF9mZW5jZSgociksIChhZGRy KSwgKHNlcSksIChmbGFncykpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF9nZHNfc3dpdGNo KHIsIHYsIGRiLCBkcywgd2IsIHdzLCBhYiwgYXMpIChyKS0+ZnVuY3MtPmVtaXRfZ2RzX3N3aXRj aCgociksICh2KSwgKGRiKSwgKGRzKSwgKHdiKSwgKHdzKSwgKGFiKSwgKGFzKSkKPiArI2RlZmlu ZSBhbWRncHVfcmluZ19lbWl0X2hkcF9mbHVzaChyKSAociktPmZ1bmNzLT5lbWl0X2hkcF9mbHVz aCgocikpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF9zd2l0Y2hfYnVmZmVyKHIpIChyKS0+ ZnVuY3MtPmVtaXRfc3dpdGNoX2J1ZmZlcigocikpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1p dF9jbnR4Y250bChyLCBkKSAociktPmZ1bmNzLT5lbWl0X2NudHhjbnRsKChyKSwgKGQpKQo+ICsj ZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfcnJlZyhyLCBkKSAociktPmZ1bmNzLT5lbWl0X3JyZWco KHIpLCAoZCkpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF93cmVnKHIsIGQsIHYpIChyKS0+ ZnVuY3MtPmVtaXRfd3JlZygociksIChkKSwgKHYpKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX2Vt aXRfcmVnX3dhaXQociwgZCwgdiwgbSkgKHIpLT5mdW5jcy0+ZW1pdF9yZWdfd2FpdCgociksIChk KSwgKHYpLCAobSkpCj4gKyNkZWZpbmUgYW1kZ3B1X3JpbmdfZW1pdF9yZWdfd3JpdGVfcmVnX3dh aXQociwgZDAsIGQxLCB2LCBtKSAociktPmZ1bmNzLT5lbWl0X3JlZ193cml0ZV9yZWdfd2FpdCgo ciksIChkMCksIChkMSksICh2KSwgKG0pKQo+ICsjZGVmaW5lIGFtZGdwdV9yaW5nX2VtaXRfdG16 KHIsIGIpIChyKS0+ZnVuY3MtPmVtaXRfdG16KChyKSwgKGIpKQo+ICsjZGVmaW5lIGFtZGdwdV9y aW5nX3BhZF9pYihyLCBpYikgKChyKS0+ZnVuY3MtPnBhZF9pYigociksIChpYikpKQo+ICsjZGVm aW5lIGFtZGdwdV9yaW5nX2luaXRfY29uZF9leGVjKHIpIChyKS0+ZnVuY3MtPmluaXRfY29uZF9l eGVjKChyKSkKPiArI2RlZmluZSBhbWRncHVfcmluZ19wYXRjaF9jb25kX2V4ZWMocixvKSAocikt PmZ1bmNzLT5wYXRjaF9jb25kX2V4ZWMoKHIpLChvKSkKPiArCj4gICBpbnQgYW1kZ3B1X3Jpbmdf YWxsb2Moc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLCB1bnNpZ25lZCBuZHcpOwo+ICAgdm9pZCBh bWRncHVfcmluZ19pbnNlcnRfbm9wKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywgdWludDMyX3Qg Y291bnQpOwo+ICAgdm9pZCBhbWRncHVfcmluZ19nZW5lcmljX3BhZF9pYihzdHJ1Y3QgYW1kZ3B1 X3JpbmcgKnJpbmcsIHN0cnVjdCBhbWRncHVfaWIgKmliKTsKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo=