Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3E43C7EE23 for ; Fri, 26 May 2023 07:02:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 991468612C; Fri, 26 May 2023 09:02:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1685084572; bh=Y9wanAyCJVZiKz2IeWZIRUeBk/Sb1a0F4zr01r+9aNI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e9c11CRkckrNuE1MKqiw3sKZepM1zRfN84g76a98mbGyHSH5GzJE9ploCwK7LEwzj Ca9NpZFFVXekl7Xj1yd3WAizoRPK7Ijo7UYT/QXI5UHZutmxEmg+ysrN5sQ6fiS6OB TD1Jqbjlw7qhXMfBkonZzKEzcv8b6FC9TA2rzX8qiCKb6r7iPDIPbzKMd4xK+kQ/4N aLBWqM00ZInFNLGI43nlfWmxTsXNU7UD2LGJ2OI25GJoByKsCt3aJCyg7SAwrCjMnM Kgc+Aalp82wCwe2W6/9sVF6pUhPb66g3sZ8aMBLZx3cC/9NncbDSmU/yU6VBZp+6U6 DrgDuxksTPifw== Received: by phobos.denx.de (Postfix, from userid 109) id 4047686139; Fri, 26 May 2023 09:02:51 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 010E986128 for ; Fri, 26 May 2023 09:02:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4QSG8L4QnNz9sWL; Fri, 26 May 2023 09:02:42 +0200 (CEST) Message-ID: <2a863f0c-2cf6-e381-3c3e-ca763cf9d9d4@denx.de> Date: Fri, 26 May 2023 09:02:41 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2] PCI: zynqmp: Add ZynqMP NWL PCIe root port driver To: Michal Simek , u-boot@lists.denx.de Cc: Simon Glass , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Bin Meng References: <20230525094918.111949-1-sr@denx.de> Content-Language: en-US From: Stefan Roese In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Michal, On 5/25/23 17:53, Michal Simek wrote: > > > On 5/25/23 11:49, Stefan Roese wrote: >> This patch adds the PCIe controller driver for the Xilinx / AMD ZynqMP >> NWL PCIe Bridge as root port. The driver source is partly copied from >> the Linux PCI driver and modified to enable usage in U-Boot (e.g. >> simplified and interrupt support removed). >> >> Signed-off-by: Stefan Roese >> Cc: Simon Glass >> Cc: Pali Rohár >> Cc: Bin Meng >> Cc: Michal Simek >> --- >> v2: >> - Remove some unused members from struct nwl_pcie >> - Fix usage of dev_seq() in nwl_pcie_config_address() >> - Remove writing to PCI_PRIMARY_BUS reg as this is done by the >>    common U-Boot PCI code later >> >>   MAINTAINERS                   |   1 + >>   drivers/pci/Kconfig           |   7 + >>   drivers/pci/Makefile          |   1 + >>   drivers/pci/pcie-xilinx-nwl.c | 352 ++++++++++++++++++++++++++++++++++ >>   4 files changed, 361 insertions(+) >>   create mode 100644 drivers/pci/pcie-xilinx-nwl.c > > Tested-by: Michal Simek > Acked-by: Michal Simek Thanks for testing. > I am happy to take this via my tree if you like. Please do so. > We should also enable this driver by default in > xilinx_zynqmp_virt_defconfig and likely any pcie driver to be able to > test it. Perfect. Please do this. > I used e1000 based card and it works as expected. Good. Thanks, Stefan