From: "selvanair (Code Review)" Date: Wed, 29 Apr 2026 22:59:22 +0000 References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <2b446e4886089cd1ef70eff454ea6292b696be88-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="F0HCbicSayc="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dns: minimalist fix for dnssec setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --F0HCbicSayc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=3Demail to review the following change. Change subject: dns: minimalist fix for dnssec setting ...................................................................... dns: minimalist fix for dnssec setting Github: fixes OpenVPN/openvpn#1024 Change-Id: I0cb093e0116e92d874162d51be777aa43674c115 --- M src/openvpn/dns.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/1644/1 diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c index ce23f1f..954ed52 100644 --- a/src/openvpn/dns.c +++ b/src/openvpn/dns.c @@ -442,7 +442,7 @@ .header =3D { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(= nrpt_dns_cfg_message_t), 0 }, .iface =3D { .index =3D tt->adapter_index, .name =3D "" }, - .flags =3D server->dnssec =3D=3D DNS_SECURITY_NO ? 0 : nrpt_dnssec, + .flags =3D server->dnssec =3D=3D DNS_SECURITY_YES ? nrpt_dnssec : = 0, }; strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.iface.name)); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1644?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0cb093e0116e92d874162d51be777aa43674c115 Gerrit-Change-Number: 1644 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --F0HCbicSayc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

selvanair would like plaisthos to review this change.

V= iew Change

dns: minimalist fix for dnssec setting
<= br>Github: fixes OpenVPN/openvpn#1024

Change-Id: I0cb093e0116e92d874= 162d51be777aa43674c115
---
M src/openvpn/dns.c
1 file changed, 1 i= nsertion(+), 1 deletion(-)

git pull ssh://gerrit=
.openvpn.net:29418/openvpn refs/changes/44/1644/1
diff --git a/src/=
openvpn/dns.c b/src/openvpn/dns.c
index ce23f1f..954ed52 10= 0644
--- a/src/openvpn/dns.c
+++ b/src/open= vpn/dns.c
@@ -442,7 +442,7 @@
.hea= der =3D { (add ? msg_add_nrpt_cfg : msg_del_nrpt_cfg), sizeof(nrpt_dns_cfg_= message_t),
0 },
= .iface =3D { .index =3D tt->adapter_index, .name =3D "" },=
- .flags =3D se= rver->dnssec =3D=3D DNS_SECURITY_NO ? 0 : nrpt_dnssec,
+ .flags =3D server->dnssec = =3D=3D DNS_SECURITY_YES ? nrpt_dnssec : 0,
}; strncpynt(nrpt.iface.name, tt->actual_name, sizeof(nrpt.ifa= ce.name));


To view, v= isit cha= nge 1644. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0cb093e0116e92d874162d51be7= 77aa43674c115
Gerrit-Change-Number: 1644
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --F0HCbicSayc=--