Message-ID: <2bb3487e-6762-40ea-b6ad-2622a879ca21@...2889...> Date: Sun, 25 May 2025 22:27:56 +0200 MIME-Version: 1.0 References: <1e8ccfd451cbf9e6d090bd6a6886e366.squirrel@...2890...> <20250507074438.1326755-1-walter.openvpn@...2889...> <8ba925a1-85c9-4274-a512-32dcec35b147@...1227...> Content-Language: en-US, sv-SE, nl From: Walter Doekes In-Reply-To: <8ba925a1-85c9-4274-a512-32dcec35b147@...1227...> Subject: Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Good. Your understanding of the situation is the same. I did not yet make a reproducer config -- mostly because I don't think we're doing anything non-standard. But I did double check that latest 2.6 is affected, tested both client and server. And, I added some tracing code, and I observed the following: > else if (verdict == VERDICT_VALID_CONTROL_V1 || verdict == VERDICT_VALID_ACK_V1) > { > /* ACK_V1 contains the peer id (our id) while CONTROL_V1 can but does not > * need to contain the peer id */ > struct gc_arena gc = gc_new(); > > bool ret = check_session_id_hmac(state, from, hmac, handwindow); > > const char *peer = print_link_socket_actual(&m->top.c2.from, &gc); > if (!ret) > { > msg(D_MULTI_MEDIUM, "Packet with invalid or missing SID from %s", peer); > } > else > { > msg(D_MULTI_DEBUG, "Valid packet with HMAC challenge from peer (%s), " > "accepting new connection.", peer); > //ret = false; // setting false here makes all setup fail > } > gc_free(&gc); > > msg(D_MULTI_MEDIUM, "do_pre_decrypt_check: verdict %d (%d)", verdict, ret); > return ret; > } This is the code that has the changed behaviour. In the before situation, we had this: > --- a/src/openvpn/mudp.c > +++ b/src/openvpn/mudp.c > @@ -55,8 +55,10 @@ do_pre_decrypt_check(struct multi_context *m) > > if (verdict == VERDICT_INVALID || verdict == VERDICT_VALID_CONTROL_V1) > { > + msg(D_MULTI_MEDIUM, "do_pre_decrypt_check: verdict %d (false)", verdict); > return false; > } > + msg(D_MULTI_MEDIUM, "do_pre_decrypt_check: verdict %d (true)", verdict); > return true; > } >