Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC99C433E0 for ; Mon, 25 Jan 2021 11:04:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67C6022583 for ; Mon, 25 Jan 2021 11:04:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67C6022583 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.74011.133019 (Exim 4.92) (envelope-from ) id 1l3zet-0003Cl-PO; Mon, 25 Jan 2021 11:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 74011.133019; Mon, 25 Jan 2021 11:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l3zet-0003Ce-M8; Mon, 25 Jan 2021 11:03:47 +0000 Received: by outflank-mailman (input) for mailman id 74011; Mon, 25 Jan 2021 11:03:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l3zet-0003CZ-4M for xen-devel@lists.xenproject.org; Mon, 25 Jan 2021 11:03:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 67eecc7b-cbd3-4498-86a7-756149fc3f43; Mon, 25 Jan 2021 11:03:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E19AAD8C; Mon, 25 Jan 2021 11:03:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67eecc7b-cbd3-4498-86a7-756149fc3f43 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611572625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S39/bDzsIvY8wZJwPoX2Sm0DQ94xYju2x7QSfr1JP5g=; b=jfXz4duSD8LcY6TAgBqYJcXlEb1JMZeFdnp3+Pf4TosSB1hhmYtaxnNNnO5goNCDwh5VQh bziH/ysqDgn8Ft5pNc4QpO3tOq/sx5mryMJHwRQtG6Q85K1ot0tdGqidihcVdd1NNIN2/3 EMxF52Sg7RJvgZQl9rDw3MYuUIiDJ20= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] xen/include: compat/xlat.h may change with .config changes Message-ID: <2bd62f36-e878-8a0b-6e64-d25f5818331c@suse.com> Date: Mon, 25 Jan 2021 12:03:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit $(xlat-y) getting derived from $(headers-y) means its contents may change with changes to .config. The individual files $(xlat-y) refers to, otoh, may not change, and hence not trigger rebuilding of xlat.h. (Note that the issue was already present before the commit referred to below, but it was far more limited in affecting only changes to CONFIG_XSM_FLASK.) Fixes: 2c8fabb2232d ("x86: only generate compat headers actually needed") Signed-off-by: Jan Beulich --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -81,7 +81,7 @@ compat/.xlat/%.lst: xlat.lst Makefile xlat-y := $(shell sed -ne 's,@arch@,$(compat-arch-y),g' -re 's,^[?!][[:blank:]]+[^[:blank:]]+[[:blank:]]+,,p' xlat.lst | uniq) xlat-y := $(filter $(patsubst compat/%,%,$(headers-y)),$(xlat-y)) -compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) Makefile +compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) config/auto.conf Makefile cat $(filter %.h,$^) >$@.new mv -f $@.new $@