Received: from eggs.gnu.org ([209.51.188.92]:35298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glshf-0008Sf-75 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 04:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glshd-0003Sp-Et for qemu-devel@nongnu.org; Tue, 22 Jan 2019 04:50:43 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:32804) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1glshd-0003QP-9b for qemu-devel@nongnu.org; Tue, 22 Jan 2019 04:50:41 -0500 Received: by mail-wr1-f67.google.com with SMTP id c14so26591982wrr.0 for ; Tue, 22 Jan 2019 01:50:39 -0800 (PST) References: <20190117185628.21862-1-crosa@redhat.com> <20190117185628.21862-3-crosa@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <2bdb9bcc-e99f-e0d1-297d-50396571b364@redhat.com> Date: Tue, 22 Jan 2019 10:50:32 +0100 MIME-Version: 1.0 In-Reply-To: <20190117185628.21862-3-crosa@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/18] Acceptance tests: show avocado test execution by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cleber Rosa , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefan Markovic , Aleksandar Markovic , Eduardo Habkost , Caio Carrara , qemu-s390x@nongnu.org, Aurelien Jarno , Cornelia Huck , Fam Zheng , Wainer dos Santos Moschetta , Aleksandar Rikalo On 1/17/19 7:56 PM, Cleber Rosa wrote: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test alone that takes on average ~5 seconds > to run, we intend to adapt the list of tests to match the user's build > environment (among other choices). > > Because of that, let's present the default Avocado UI by default. > Users can always choose a different output by setting the AVOCADO_SHOW > variable. > > Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé > --- > .travis.yml | 2 +- > tests/Makefile.include | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 93fd0164a0..844d514afa 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -188,7 +188,7 @@ matrix: > # Acceptance (Functional) tests > - env: > - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu" > - - TEST_CMD="make AVOCADO_SHOW=app check-acceptance" > + - TEST_CMD="make check-acceptance" > addons: > apt: > packages: > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f403a6571d..c73298740d 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results > # Controls the output generated by Avocado when running tests. > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > -AVOCADO_SHOW=none > +AVOCADO_SHOW=app > > PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3, 0) else 0)') > ifeq ($(PYTHON3), 1) >