From: "flichtenheld (Code Review)" Date: Wed, 1 Apr 2026 10:41:52 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <2beb65171e2877f65324341967abd0ce5dc223c0-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="5djQ4/zRtvE="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not access internals of ASN1_INTEGER to print hex of serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --5djQ4/zRtvE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1589?usp=3Demail ) Change subject: Do not access internals of ASN1_INTEGER to print hex of ser= ial ...................................................................... Patch Set 4: (1 comment) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1589/comment/f70e7e3e_124725d2?usp=3D= email : PS4, Line 320: char *ret =3D format_hex_ex(buf, len_serial, 0, 1, ":", = gc); So why can't we use `BN_bn2hex` here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1589?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5158fbb0762443ea4954e5745f520e83e019ed30 Gerrit-Change-Number: 1589 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-CC: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 01 Apr 2026 10:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --5djQ4/zRtvE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

View = Change

1 comment:

    =
  • File src/openvpn/ssl_verify_openssl= .c:

    • Pa= tch Set #4, Line 320: = char *ret =3D format_hex_ex(buf, len_serial, 0, 1, ":", gc);

      So why can't we use `BN_bn2hex` here?

=

To view, visit change 1589. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5158fbb0762443ea4954e5745f5= 20e83e019ed30
Gerrit-Change-Number: 1589
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-CC: flichtenheld <frank@...2641...&g= t;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:41:52= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --5djQ4/zRtvE=--