From: "flichtenheld (Code Review)" Date: Wed, 13 Dec 2023 14:57:14 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <2bfb0f1a7b269ca362d630b5c40e5f3cecea74dc-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tHYtk9P0vh8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Move get_tmp_dir to win32-util.c and error out on failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --tHYtk9P0vh8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/481?usp=3Demail ) Change subject: Move get_tmp_dir to win32-util.c and error out on failure ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/481/comment/466d524c_f6e1e499 : PS1, Line 891: /* Warn if we can't find a valid temporary directory= , which should M_USAGE is not really "Warn" File src/openvpn/win32-util.h: http://gerrit.openvpn.net/c/openvpn/+/481/comment/14243ada_3a632f04 : PS1, Line 44: const char *win_get_tempdir(void); corresponding removal from win32.h is missing? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/481?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I525ccf7872880367b248ebebb0ddc83551498042 Gerrit-Change-Number: 481 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 13 Dec 2023 14:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --tHYtk9P0vh8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

2 comments:

  • File src/openvpn/options.c:

    =
    • Patch Set #1, Line 891= : /* Warn if we= can't find a valid temporary directory, which should

      M_USAGE is not really &= quot;Warn"

  • F= ile src/openvpn/win32-util.h:

To view, visit change 481. To unsubscribe,= or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I525ccf7872880367b248ebebb0d= dc83551498042
Gerrit-Change-Number: 481
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 13 Dec 2023 14:57:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--tHYtk9P0vh8=--