From: Jason Wang Subject: Re: [PATCH V4 5/5] vdpasim: vDPA device simulator Date: Fri, 21 Feb 2020 16:50:10 +0800 Message-ID: <2c0ad54d-c8bd-bb2e-5dff-ce79cf0d45b9@redhat.com> References: <20200220061141.29390-1-jasowang@redhat.com> <20200220061141.29390-6-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Harpreet Singh Anand , "mst@redhat.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" Cc: "tiwei.bie@intel.com" , "jgg@mellanox.com" , "maxime.coquelin@redhat.com" , "cunming.liang@intel.com" , "zhihong.wang@intel.com" , "rob.miller@broadcom.com" , "xiao.w.wang@intel.com" , "haotian.wang@sifive.com" , "lingshan.zhu@intel.com" , "eperezma@redhat.com" , "lulu@redhat.com" , "parav@mellanox.com" , "kevin.tian@intel.com" , "stefanha@redhat.com" , "rdunlap@infradead.org" , "hch@infradead.org" , aadam@r List-Id: virtualization@lists.linuxfoundation.org On 2020/2/21 =E4=B8=8B=E5=8D=884:33, Harpreet Singh Anand wrote: > + ret =3D device_register(&vdpasim->dev); > + if (ret) > + goto err_init; > + > + vdpasim->vdpa =3D vdpa_alloc_device(dev, dev, &vdpasim_net_conf= ig_ops); > + if (ret) > + goto err_vdpa; > > [HSA] Incorrect checking of the return value of vdpa_alloc_device. Yes, fixed. Thanks