From: "flichtenheld (Code Review)" Date: Thu, 12 Mar 2026 13:26:01 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <2c181e679686ad41007eb59198f01abae95f202b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1XIhGYRJeog="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dns: Change arguments to setenv_dns_option to avoid sign-compare warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --1XIhGYRJeog= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://g= errit.openvpn.net/c/openvpn/+/1558?usp=3Demail ) Change subject: dns: Change arguments to setenv_dns_option to avoid sign-co= mpare warning ...................................................................... Patch Set 3: (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/1558/comment/afed0dee_70196530?usp=3D= email : PS2, Line 487: if (!j) > technically this is fine, but it takes me as a reader few more seconds to= understand what this check [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1558?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b1625dcb7e6fb5 Gerrit-Change-Number: 1558 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Thu, 12 Mar 2026 13:26:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 --1XIhGYRJeog= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: cron2, plaisthos.

View = Change

1 comment:

    =
  • File src/openvpn/dns.c:

    • Patch Set #2, Lin= e 487: if (!j)

      technically this is fine, but it takes me as a reader few= more seconds to understand what this check [=E2=80=A6]

      Do= ne

To view, visit change 1558. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibfcc350c772227cfc0f2244fa2b= 1625dcb7e6fb5
Gerrit-Change-Number: 1558
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Thu, 12 Mar 2026 13:26:01= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
= --1XIhGYRJeog=--