Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6584CC433EF for ; Fri, 14 Jan 2022 15:41:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EBB2C8354B; Fri, 14 Jan 2022 16:41:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642174876; bh=RCcE2L+SrOlhQhBqKLE/EjXbdKIoaiEXAT8B2xmhcOg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=J+/wnqacnGx8hqMgFaGRkLVp1THxJ9PxwWWoeLmD2FSpQi7gfr8oV545NTkHBNe3I 7iMWZIN6pPq9uNzMVnhl3cRGi/UunFR/2C1QArF/vzom56jPskm8o4imn32vLmP1mD dSPptr6GNEgtOSTATngUwtGVDUNYz5gMLPhxSNpY7UddDd+2uct5uCZKFk9l4VOLAU Z0nCphcY8oT4yXsryOsHz4pbR/l2KFsAebJfsbSFIKyBInZ9ghy5yA6X+duUlwXt+u Zvz9RHez3ZrsXCIAIJNi3Z8cYWR5AF2xfrhQtL0FOHR3J+1kQVvENebD5gAxm9H5Mw b4u94f7h8XiXQ== Received: by phobos.denx.de (Postfix, from userid 109) id 8184383520; Fri, 14 Jan 2022 16:41:13 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A8BF08351A for ; Fri, 14 Jan 2022 16:41:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4Jb59y47nyzQkH3; Fri, 14 Jan 2022 16:41:10 +0100 (CET) Message-ID: <2c4a445a-7c5a-ab9d-5abb-b7c4bbcdc103@denx.de> Date: Fri, 14 Jan 2022 16:41:07 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] arm: mvebu: db-88f6720: Fix CONFIG_SPL_TEXT_BASE and remove wrong memory layout Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: u-boot@lists.denx.de References: <20220112173009.6459-1-pali@kernel.org> From: Stefan Roese In-Reply-To: <20220112173009.6459-1-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/12/22 18:30, Pali Rohár wrote: > Memory layout in the comment is from Armada XP platform which uses load > address 0x40004030. DB-88f6720 is Armada 375 platform which uses same load > address as Armada 38x which is 0x40000030. > > Currently SPL support for Armada 375 is unfinished and does not work. There > is missing Serdes initialization and DDR3 training code. So nobody noticed > that CONFIG_SPL_* options are not correct. > > Fix at least CONFIG_SPL_TEXT_BASE constant and remove incorrect comments > about memory layout. So it is not misleading. > > Signed-off-by: Pali Rohár Applied to u-boot-marvell/master Thanks, Stefan > --- > configs/db-88f6720_defconfig | 2 +- > include/configs/db-88f6720.h | 15 +-------------- > 2 files changed, 2 insertions(+), 15 deletions(-) > > diff --git a/configs/db-88f6720_defconfig b/configs/db-88f6720_defconfig > index 32a7349993ca..2e8f4c00de50 100644 > --- a/configs/db-88f6720_defconfig > +++ b/configs/db-88f6720_defconfig > @@ -11,7 +11,7 @@ CONFIG_ENV_SIZE=0x10000 > CONFIG_ENV_OFFSET=0x100000 > CONFIG_ENV_SECT_SIZE=0x10000 > CONFIG_DEFAULT_DEVICE_TREE="armada-375-db" > -CONFIG_SPL_TEXT_BASE=0x40004030 > +CONFIG_SPL_TEXT_BASE=0x40000030 > CONFIG_SPL_SERIAL=y > CONFIG_SPL=y > CONFIG_DEBUG_UART_BASE=0xf1012000 > diff --git a/include/configs/db-88f6720.h b/include/configs/db-88f6720.h > index 19fc669f89d1..cf9e44d17c32 100644 > --- a/include/configs/db-88f6720.h > +++ b/include/configs/db-88f6720.h > @@ -32,22 +32,9 @@ > */ > #include "mv-common.h" > > -/* > - * Memory layout while starting into the bin_hdr via the > - * BootROM: > - * > - * 0x4000.4000 - 0x4003.4000 headers space (192KiB) > - * 0x4000.4030 bin_hdr start address > - * 0x4003.4000 - 0x4004.7c00 BootROM memory allocations (15KiB) > - * 0x4007.fffc BootROM stack top > - * > - * The address space between 0x4007.fffc and 0x400f.fff is not locked in > - * L2 cache thus cannot be used. > - */ > - > /* SPL */ > /* Defines for SPL */ > -#define CONFIG_SPL_MAX_SIZE ((128 << 10) - 0x4030) > +#define CONFIG_SPL_MAX_SIZE ((128 << 10) - 0x0030) > > #define CONFIG_SPL_BSS_START_ADDR (0x40000000 + (128 << 10)) > #define CONFIG_SPL_BSS_MAX_SIZE (16 << 10) > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de