Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46C80C433EF for ; Fri, 28 Jan 2022 22:38:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BBC082135; Fri, 28 Jan 2022 23:37:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="g2YQxUMH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7CE8A82DB7; Fri, 28 Jan 2022 23:37:57 +0100 (CET) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 232F78210D for ; Fri, 28 Jan 2022 23:37:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x635.google.com with SMTP id ah7so20676981ejc.4 for ; Fri, 28 Jan 2022 14:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fwBBS0LwfZJbkUnkKE7dWQQGUbywP5tvFdP9dv7St88=; b=g2YQxUMHRSA7RVdYvimj5dlkB0JkSVaJA8UNJtqTPwBb8F5wbBi/BUX7SGu9Ib+3lK 07nQHFv2tGq85IyWI8qI2SVvteikVUahIEE9qtc/mPgu9EaXRYzcAPvlW5JBMg372q1B qc+FlhjqqF6uHYaVI7VAbnBE6B9Tw0bmPZzYBZkUwWnTSPjZn9C41/3sDT+8oadBAU/0 fAS4Boj5ksnFqqf84K4NgZogTsOHK0XBV5741xkdI+dVQpia8WzLN5ITjuIR9QzByynb ezzzGh3sLgI8/u26kz3uAYDwK8q+c2HcO5f9rT4QLIEDFcAFbSfBiY9HuMMP7PHnnYE4 qYcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fwBBS0LwfZJbkUnkKE7dWQQGUbywP5tvFdP9dv7St88=; b=xV58E4M7DxdKM8Ih8wBK63bf71ClpQKherqtJYoiTif2wU7yRADpxHW6NFAEt/x9q7 +8B/jHBNYiUJqe0xDSDDaVS1b8WH4zfpjpBC32PMKNoQn4nQG2TKmVhpJ8QES7FuIqy3 EM4VkYiSs45e6cax6tmMUkjutRse4RT4x3eNdT/AWeuUT2inpGMsihnOZXQO8WPGjcjl oUWXucAs4GgBfJaqqJNs86nLrLHpub6zBZGkMkgXm377Rfjp1XN15aF5VxIhjQt1JoVN hYXlNKCU1MmDFvVN9qqVoHJiWcnm7k2CYEKGHhmioQm5bBVKcurw+SJ9y+vPVVUxbpeI Z4UQ== X-Gm-Message-State: AOAM5320o/TPh631dEGJoCuqPgI6mZhee0PIc8DmgwxhDj6+WjqE3sy6 WyIf2v2gpYiQruAJLorciQ0= X-Google-Smtp-Source: ABdhPJz2EdXgjG/3kRDM1EdM99jUkksFKitT+ujazcPG+bQzcFnlNOumT+LYBzkmFRLUnLQ/x0L43A== X-Received: by 2002:a17:907:16a3:: with SMTP id hc35mr8788425ejc.299.1643409474575; Fri, 28 Jan 2022 14:37:54 -0800 (PST) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id jl17sm10620188ejc.16.2022.01.28.14.37.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 14:37:53 -0800 (PST) Message-ID: <2c4ac683-08c2-22fa-2b22-8173b2648cf4@gmail.com> Date: Sat, 29 Jan 2022 01:37:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling Content-Language: en-US To: Simon Glass , Kever Yang Cc: U-Boot Mailing List , Yifeng Zhao , Peng Fan , Ashok Reddy Soma , Samuel Dionne-Riel , Aswath Govindraju , Philipp Tomsich , Jagan Teki , Stephen Carlson , Michal Simek , Faiz Abbas , Peter Robinson , Jaehoon Chung , Jack Mitchell References: <20220111133931.7866-1-alpernebiyasak@gmail.com> <20220111133931.7866-3-alpernebiyasak@gmail.com> From: Alper Nebi Yasak In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 21/01/2022 18:20, Simon Glass wrote: > On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak wrote: >> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c >> index 278473899c7c..f0d7ba4774d6 100644 >> --- a/drivers/mmc/rockchip_sdhci.c >> +++ b/drivers/mmc/rockchip_sdhci.c >> @@ -90,9 +90,10 @@ struct rockchip_sdhc { >> }; >> >> struct sdhci_data { >> - int (*emmc_set_clock)(struct sdhci_host *host, unsigned int clock); >> int (*emmc_phy_init)(struct udevice *dev); >> int (*get_phy)(struct udevice *dev); >> + void (*set_control_reg)(struct sdhci_host *host); >> + int (*set_ios_post)(struct sdhci_host *host); > > These should each have a full function comment. I tried to write some words for these and set_enhanced_strobe() in the other patches, will send as v4 now. > I don't see the kevin patches applied yet...what is happening there? They're still not applied. I don't know what I can do about that besides trying to send a pull request myself. Not feeling confident about that, though, should I? OTOH, I expect this series are testable and should be working with or without those patches.