From: Michel Thierry Subject: Re: [PATCH v4 06/13] drm/i915/guc: Prepare to handle messages from CT RECV buffer Date: Fri, 23 Mar 2018 15:39:50 -0700 Message-ID: <2c5d4ade-c257-89f0-9221-c9f534563fe6@intel.com> References: <20180323144728.61548-1-michal.wajdeczko@intel.com> <20180323144728.61548-7-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78F276E071 for ; Fri, 23 Mar 2018 22:39:51 +0000 (UTC) In-Reply-To: <20180323144728.61548-7-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMy8yMy8yMDE4IDc6NDcgQU0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gR3VDIGNhbiBy ZXNwb25kIHRvIG91ciBjb21tYW5kcyBub3Qgb25seSBieSB1cGRhdGluZyBTRU5EIGJ1ZmZlcgo+ IGRlc2NyaXB0b3IsIGJ1dCBjYW4gYWxzbyBzZW5kIGEgcmVzcG9uc2UgbWVzc2FnZSBvdmVyIFJF Q1YgYnVmZmVyLgo+IEd1YyBjYW4gYWxzbyBzZW5kIHVuc29saWNpdGVkIHJlcXVlc3QgbWVzc2Fn ZXMgb3ZlciBSRUNWIGJ1ZmZlci4KPiBMZXQncyBzdGFydCByZWFkaW5nIHRob3NlIG1lc3NhZ2Vz IGFuZCBtYWtlIHBsYWNlaG9sZGVycwo+IGZvciBhY3R1YWwgcmVzcG9uc2UvcmVxdWVzdCBoYW5k bGVycy4KPiAKPiB2MjogbWlzYyBpbXByb3ZlbWVudHMgKE1pY2hhbCkKPiB2MzogY2hhbmdlIHJl c3BvbnNlIGRldGVjdGlvbiAoTWljaGFsKQo+ICAgICAgaW52YWxpZCBzdGF0dXMgaXMgcHJvdG9j b2wgZXJyb3IgKE1pY2hhbCkKPiB2NDogcmViYXNlCj4gCj4gU2lnbmVkLW9mZi1ieTogTWljaGFs IFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IE9zY2FyIE1hdGVv IDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gQ2M6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhp ZXJyeUBpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2Vy YW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ndWNfY3QuYyB8IDEzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAg IDEgZmlsZSBjaGFuZ2VkLCAxMzkgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfY3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Y19jdC5jCj4gaW5kZXggYTU0YmY1OC4uZjAyOWZmMyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfY3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Y19jdC5jCj4gQEAgLTQyNyw2ICs0MjcsMTQzIEBAIHN0YXRpYyBpbnQgaW50 ZWxfZ3VjX3NlbmRfY3Qoc3RydWN0IGludGVsX2d1YyAqZ3VjLCBjb25zdCB1MzIgKmFjdGlvbiwg dTMyIGxlbiwKPiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgdW5z aWduZWQgaW50IGN0X2hlYWRlcl9nZXRfbGVuKHUzMiBoZWFkZXIpCj4gK3sKPiArCXJldHVybiAo aGVhZGVyID4+IEdVQ19DVF9NU0dfTEVOX1NISUZUKSAmIEdVQ19DVF9NU0dfTEVOX01BU0s7Cj4g K30KPiArCj4gK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IGN0X2hlYWRlcl9nZXRfYWN0aW9u KHUzMiBoZWFkZXIpCj4gK3sKPiArCXJldHVybiAoaGVhZGVyID4+IEdVQ19DVF9NU0dfQUNUSU9O X1NISUZUKSAmIEdVQ19DVF9NU0dfQUNUSU9OX01BU0s7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxp bmUgYm9vbCBjdF9oZWFkZXJfaXNfcmVzcG9uc2UodTMyIGhlYWRlcikKPiArewo+ICsJcmV0dXJu IGN0X2hlYWRlcl9nZXRfYWN0aW9uKGhlYWRlcikgPT0gSU5URUxfR1VDX0FDVElPTl9ERUZBVUxU Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGN0Yl9yZWFkKHN0cnVjdCBpbnRlbF9ndWNfY3RfYnVm ZmVyICpjdGIsIHUzMiAqZGF0YSkKPiArewo+ICsJc3RydWN0IGd1Y19jdF9idWZmZXJfZGVzYyAq ZGVzYyA9IGN0Yi0+ZGVzYzsKPiArCXUzMiBoZWFkID0gZGVzYy0+aGVhZCAvIDQ7CS8qIGluIGR3 b3JkcyAqLwo+ICsJdTMyIHRhaWwgPSBkZXNjLT50YWlsIC8gNDsJLyogaW4gZHdvcmRzICovCj4g Kwl1MzIgc2l6ZSA9IGRlc2MtPnNpemUgLyA0OwkvKiBpbiBkd29yZHMgKi8KPiArCXUzMiAqY21k cyA9IGN0Yi0+Y21kczsKPiArCXMzMiBhdmFpbGFibGU7CQkJLyogaW4gZHdvcmRzICovCj4gKwl1 bnNpZ25lZCBpbnQgbGVuOwo+ICsJdW5zaWduZWQgaW50IGk7Cj4gKwo+ICsJR0VNX0JVR19PTihk ZXNjLT5zaXplICUgNCk7Cj4gKwlHRU1fQlVHX09OKGRlc2MtPmhlYWQgJSA0KTsKPiArCUdFTV9C VUdfT04oZGVzYy0+dGFpbCAlIDQpOwo+ICsJR0VNX0JVR19PTih0YWlsID49IHNpemUpOwo+ICsJ R0VNX0JVR19PTihoZWFkID49IHNpemUpOwo+ICsKPiArCS8qIHRhaWwgPT0gaGVhZCBjb25kaXRp b24gaW5kaWNhdGVzIGVtcHR5ICovCj4gKwlhdmFpbGFibGUgPSB0YWlsIC0gaGVhZDsKPiArCWlm ICh1bmxpa2VseShhdmFpbGFibGUgPT0gMCkpCj4gKwkJcmV0dXJuIC1FTk9EQVRBOwo+ICsKPiAr CS8qIGJld2FyZSBvZiBidWZmZXIgd3JhcCBjYXNlICovCj4gKwlpZiAodW5saWtlbHkoYXZhaWxh YmxlIDwgMCkpCj4gKwkJYXZhaWxhYmxlICs9IHNpemU7Cj4gKwlHRU1fQlVHX09OKGF2YWlsYWJs ZSA8IDApOwo+ICsKPiArCWRhdGFbMF0gPSBjbWRzW2hlYWRdOwo+ICsJaGVhZCA9IChoZWFkICsg MSkgJSBzaXplOwo+ICsKPiArCS8qIG1lc3NhZ2UgbGVuIHdpdGggaGVhZGVyICovCj4gKwlsZW4g PSBjdF9oZWFkZXJfZ2V0X2xlbihkYXRhWzBdKSArIDE7Cj4gKwlpZiAodW5saWtlbHkobGVuID4g KHUzMilhdmFpbGFibGUpKSB7Cj4gKwkJRFJNX0VSUk9SKCJDVDogaW5jb21wbGV0ZSBtZXNzYWdl ICUqcGhuICUqcGhuICUqcGhuXG4iLAo+ICsJCQkgIDQsIGRhdGEsCj4gKwkJCSAgNCAqIChoZWFk ICsgYXZhaWxhYmxlIC0gMSA+IHNpemUgPwo+ICsJCQkgICAgICAgc2l6ZSAtIGhlYWQgOiBhdmFp bGFibGUgLSAxKSwgJmNtZHNbaGVhZF0sCj4gKwkJCSAgNCAqIChoZWFkICsgYXZhaWxhYmxlIC0g MSA+IHNpemUgPwo+ICsJCQkgICAgICAgYXZhaWxhYmxlIC0gMSAtIHNpemUgKyBoZWFkIDogMCks ICZjbWRzWzBdKTsKPiArCQlyZXR1cm4gLUVQUk9UTzsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAx OyBpIDwgbGVuOyBpKyspIHsKPiArCQlkYXRhW2ldID0gY21kc1toZWFkXTsKPiArCQloZWFkID0g KGhlYWQgKyAxKSAlIHNpemU7Cj4gKwl9Cj4gKwo+ICsJZGVzYy0+aGVhZCA9IGhlYWQgKiA0Owo+ ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgY3RfaGFuZGxlX3Jlc3BvbnNlKHN0 cnVjdCBpbnRlbF9ndWNfY3QgKmN0LCBjb25zdCB1MzIgKm1zZykKPiArewo+ICsJdTMyIGhlYWRl ciA9IG1zZ1swXTsKPiArCXUzMiBzdGF0dXMgPSBtc2dbMl07Cj4gKwl1MzIgbGVuID0gY3RfaGVh ZGVyX2dldF9sZW4oaGVhZGVyKSArIDE7IC8qIHRvdGFsIGxlbiB3aXRoIGhlYWRlciAqLwo+ICsK PiArCUdFTV9CVUdfT04oIWN0X2hlYWRlcl9pc19yZXNwb25zZShoZWFkZXIpKTsKPiArCj4gKwkv KiBSZXNwb25zZSBtZXNzYWdlIHNoYWxsIGF0IGxlYXN0IGluY2x1ZGUgaGVhZGVyLCBmZW5jZSBh bmQgc3RhdHVzICovCj4gKwlpZiAodW5saWtlbHkobGVuIDwgMykpIHsKPiArCQlEUk1fRVJST1Io IkNUOiBjb3JydXB0ZWQgcmVzcG9uc2UgJSpwaG5cbiIsIDQqbGVuLCBtc2cpOwpGaS5DSS5DSEVD S1BBVENIIHdhbnRzIGEgc3BhY2UgYXJvdW5kIHRoYXQgJzQqbGVuJwoKPiArCQlyZXR1cm4gLUVQ Uk9UTzsKPiArCX0KPiArCS8qIEZvcm1hdCBvZiB0aGUgc3RhdHVzIGZvbGxvd3MgUkVTUE9OU0Ug bWVzc2FnZSAqLwo+ICsJaWYgKHVubGlrZWx5KCFJTlRFTF9HVUNfTVNHX0lTX1JFU1BPTlNFKHN0 YXR1cykpKSB7Cj4gKwkJRFJNX0VSUk9SKCJDVDogY29ycnVwdGVkIHJlc3BvbnNlICUqcGhuXG4i LCA0KmxlbiwgbXNnKTsKYWxzbyBoZXJlCgo+ICsJCXJldHVybiAtRVBST1RPOwo+ICsJfQo+ICsK PiArCS8qIFhYWCAqLwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgY3RfaGFu ZGxlX3JlcXVlc3Qoc3RydWN0IGludGVsX2d1Y19jdCAqY3QsIGNvbnN0IHUzMiAqbXNnKQo+ICt7 Cj4gKwl1MzIgaGVhZGVyID0gbXNnWzBdOwo+ICsKPiArCUdFTV9CVUdfT04oY3RfaGVhZGVyX2lz X3Jlc3BvbnNlKGhlYWRlcikpOwo+ICsKPiArCS8qIFhYWCAqLwo+ICsJcmV0dXJuIDA7Cj4gK30K PiArCj4gK3N0YXRpYyB2b2lkIGN0X3Byb2Nlc3NfaG9zdF9jaGFubmVsKHN0cnVjdCBpbnRlbF9n dWNfY3QgKmN0KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZ3VjX2N0X2NoYW5uZWwgKmN0Y2ggPSAm Y3QtPmhvc3RfY2hhbm5lbDsKPiArCXN0cnVjdCBpbnRlbF9ndWNfY3RfYnVmZmVyICpjdGIgPSAm Y3RjaC0+Y3Ric1tDVEJfUkVDVl07Cj4gKwl1MzIgbXNnW0dVQ19DVF9NU0dfTEVOX01BU0srMV07 IC8qIG9uZSBleHRyYSBkdyBmb3IgdGhlIGhlYWRlciAqYW5kIGhlcmUuCgpPdGhlcndpc2UKClJl dmlld2VkLWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgoKPiAr CWludCBlcnIgPSAwOwo+ICsKPiArCWlmICghY3RjaF9pc19vcGVuKGN0Y2gpKQo+ICsJCXJldHVy bjsKPiArCj4gKwlkbyB7Cj4gKwkJZXJyID0gY3RiX3JlYWQoY3RiLCBtc2cpOwo+ICsJCWlmIChl cnIpCj4gKwkJCWJyZWFrOwo+ICsKPiArCQlpZiAoY3RfaGVhZGVyX2lzX3Jlc3BvbnNlKG1zZ1sw XSkpCj4gKwkJCWVyciA9IGN0X2hhbmRsZV9yZXNwb25zZShjdCwgbXNnKTsKPiArCQllbHNlCj4g KwkJCWVyciA9IGN0X2hhbmRsZV9yZXF1ZXN0KGN0LCBtc2cpOwo+ICsJfSB3aGlsZSAoIWVycik7 Cj4gKwo+ICsJaWYgKEdFTV9XQVJOX09OKGVyciA9PSAtRVBST1RPKSkgewo+ICsJCURSTV9FUlJP UigiQ1Q6IGNvcnJ1cHRlZCBtZXNzYWdlIGRldGVjdGVkIVxuIik7Cj4gKwkJY3RiLT5kZXNjLT5p c19pbl9lcnJvciA9IDE7Cj4gKwl9Cj4gK30KPiArCj4gKy8qCj4gKyAqIFdoZW4gd2UncmUgY29t bXVuaWNhdGluZyB3aXRoIHRoZSBHdUMgb3ZlciBDVCwgR3VDIHVzZXMgZXZlbnRzCj4gKyAqIHRv IG5vdGlmeSB1cyBhYm91dCBuZXcgbWVzc2FnZXMgYmVpbmcgcG9zdGVkIG9uIHRoZSBSRUNWIGJ1 ZmZlci4KPiArICovCj4gK3N0YXRpYyB2b2lkIGludGVsX2d1Y190b19ob3N0X2V2ZW50X2hhbmRs ZXJfY3Qoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZ3VjX2N0 ICpjdCA9ICZndWMtPmN0Owo+ICsKPiArCWN0X3Byb2Nlc3NfaG9zdF9jaGFubmVsKGN0KTsKPiAr fQo+ICsKPiAgIC8qKgo+ICAgICogaW50ZWxfZ3VjX2N0X2VuYWJsZSAtIEVuYWJsZSBidWZmZXIg YmFzZWQgY29tbWFuZCB0cmFuc3BvcnQuCj4gICAgKiBAY3Q6IHBvaW50ZXIgdG8gQ1Qgc3RydWN0 Cj4gQEAgLTQ1MCw2ICs1ODcsNyBAQCBpbnQgaW50ZWxfZ3VjX2N0X2VuYWJsZShzdHJ1Y3QgaW50 ZWxfZ3VjX2N0ICpjdCkKPiAgIAo+ICAgCS8qIFN3aXRjaCBpbnRvIGNtZCB0cmFuc3BvcnQgYnVm ZmVyIGJhc2VkIHNlbmQoKSAqLwo+ICAgCWd1Yy0+c2VuZCA9IGludGVsX2d1Y19zZW5kX2N0Owo+ ICsJZ3VjLT5oYW5kbGVyID0gaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9jdDsKPiAg IAlEUk1fSU5GTygiQ1Q6ICVzXG4iLCBlbmFibGVkZGlzYWJsZWQodHJ1ZSkpOwo+ICAgCXJldHVy biAwOwo+ICAgfQo+IEBAIC00NzUsNSArNjEzLDYgQEAgdm9pZCBpbnRlbF9ndWNfY3RfZGlzYWJs ZShzdHJ1Y3QgaW50ZWxfZ3VjX2N0ICpjdCkKPiAgIAo+ICAgCS8qIERpc2FibGUgc2VuZCAqLwo+ ICAgCWd1Yy0+c2VuZCA9IGludGVsX2d1Y19zZW5kX25vcDsKPiArCWd1Yy0+aGFuZGxlciA9IGlu dGVsX2d1Y190b19ob3N0X2V2ZW50X2hhbmRsZXJfbm9wOwo+ICAgCURSTV9JTkZPKCJDVDogJXNc biIsIGVuYWJsZWRkaXNhYmxlZChmYWxzZSkpOwo+ICAgfQo+IApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK