From: "cron2 (Code Review)" Date: Mon, 27 Jan 2025 11:40:10 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2c9956c27b79e88f6e7b31f25e777850e541a7fe-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="54u1T7Pugyo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove comparing username to NULL in tls_lock_username List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --54u1T7Pugyo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/871?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove comparing username to NULL in tls_lock_username ...................................................................... Remove comparing username to NULL in tls_lock_username tls_lock_username is only called in a single place and that place calls this is function with up->username, which is always defined. Change-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20250121161247.37883-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 520.html Signed-off-by: Gert Doering --- M src/openvpn/ssl_verify.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/871/3 diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 4c4b58d..e7d7ed6 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -153,11 +153,11 @@ { if (multi->locked_username) { - if (!username || strcmp(username, multi->locked_username)) + if (strcmp(username, multi->locked_username) !=3D 0) { msg(D_TLS_ERRORS, "TLS Auth Error: username attempted to chang= e from '%s' to '%s' -- tunnel disabled", multi->locked_username, - np(username)); + username); /* disable the tunnel */ tls_deauthenticate(multi); @@ -166,10 +166,7 @@ } else { - if (username) - { - multi->locked_username =3D string_alloc(username, NULL); - } + multi->locked_username =3D string_alloc(username, NULL); } return true; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/871?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20 Gerrit-Change-Number: 871 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --54u1T7Pugyo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #3 to the change originally cr= eated by plaisthos.

View Change

The following approvals got outdated= and were removed: Code-Review+2 by flichtenheld

Remove comparing username to NULL in tls_lock=
_username

tls_lock_username is only called in a single place and tha= t place
calls this is function with up->username, which is always def= ined.

Change-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20
Signed= -off-by: Arne Schwabe <arne@...1227...>
Acked-by: Frank Lichtenhel= d <frank@...2641...>
Message-Id: <20250121161247.37883-1-frank@= ...2641...>
URL: https://www.mail-archive.com/openvpn-devel@...1885...= rceforge.net/msg30520.html
Signed-off-by: Gert Doering <gert@...1725...= ..>
---
M src/openvpn/ssl_verify.c
1 file changed, 3 insertions= (+), 6 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openv=
pn refs/changes/71/871/3
diff --git a/src/openvpn/ssl_verify.c b/sr=
c/openvpn/ssl_verify.c
index 4c4b58d..e7d7ed6 100644=
--- a/src/openvpn/ssl_verify.c
+++ b/src/openvpn/= ssl_verify.c
@@ -153,11 +153,11 @@
{
if (multi->locked_username)
{
- if (!username || st= rcmp(username, multi->locked_username))
+ if (strcmp(username, multi->locked_userna= me) !=3D 0)
{
msg(D_T= LS_ERRORS, "TLS Auth Error: username attempted to change from '%s&= #39; to '%s' -- tunnel disabled",
= multi->locked_username,
- np(username));
+ username);
/* disable the tunnel */
t= ls_deauthenticate(multi);
@@ -166,10 +166,7 @@
}

else
{
- if (username)

- {
- multi->locked_username =3D string_= alloc(username, NULL);
= - }
+ m= ulti->locked_username =3D string_alloc(username, NULL);
= }
return true;
}

To view, visit change 871. To unsubscribe, or for help writ= ing mail filters, visit sett= ings.

<= link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/871?usp= =3Demail"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib8adf7b31cae02e2de3d45da23b= 76a2d79f13e20
Gerrit-Change-Number: 871
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--54u1T7Pugyo=--